From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Schake Subject: [PATCH 0/2] drm/vc4: Correctly uninstall interrupts Date: Fri, 10 Nov 2017 02:05:05 +0100 Message-ID: <1510275907-993-1-git-send-email-stschake@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5436F6E1AA for ; Fri, 10 Nov 2017 01:05:40 +0000 (UTC) Received: by mail-wm0-x235.google.com with SMTP id b14so5424677wme.2 for ; Thu, 09 Nov 2017 17:05:40 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: David Airlie , linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org VGhpcyBzZXQgb2YgcGF0Y2hlcyBmaXhlcyBpc3N1ZXMgd2l0aCB2YzRfaXJxX3VuaW5zdGFsbC4K VGhlIGZpcnN0IHBhdGNoIGZpeGVzIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIHdoZW4gdGhl IGJpbm5lciBCTwp3b3VsZCBkaXNhcHBlYXIgZHVyaW5nIGFuIGluIGZsaWdodCBvdmVyZmxvdyBt ZW0gd29yayBjYWxsYmFjay4KClRoZSBzZWNvbmQgcGF0Y2ggZW5zdXJlcyB3ZSByZXR1cm4gd2l0 aCBhbGwgaW50ZXJydXB0cyBkaXNhYmxlZC4gVGhpcyB3YXMKc3VzcGVjdGVkIHRvIGNhdXNlIHRo ZSBOVUxMIGRlcmVmZXJlbmNlIGJ1dCB0dXJuZWQgb3V0IHRvIGJlIHVucmVsYXRlZC4KClRlc3Rl ZCB3aXRoIGEgUmFzcGJlcnJ5IFBpIENNIDMgdGhhdCB3YXMgcHJldmlvdXNseSBzdHVjayBpbiBh IGJvb3QgbG9vcApkdWUgdG8gdGhlIGlzc3VlLiBXaXRoIHRoZSBwYXRjaCBhcHBsaWVkLCB0aGUg TlVMTCBkZXJlZmVyZW5jZSB3YXMgbm8KbG9uZ2VyIG9ic2VydmVkIHRocm91Z2ggbnVtZXJvdXMg cmVzZXRzLgoKU3RlZmFuIFNjaGFrZSAoMik6CiAgZHJtL3ZjNDogQWNjb3VudCBmb3IgaW50ZXJy dXB0cyBpbiBmbGlnaHQKICBkcm0vdmM0OiBFbnN1cmUgaW50ZXJydXB0cyBhcmUgZGlzYWJsZWQK CiBkcml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9pcnEuYyB8IDE1ICsrKysrKysrKysrKysrLQogMSBm aWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCi0tIAoxLjkuMQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbdKJBFl (ORCPT ); Thu, 9 Nov 2017 20:05:41 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:48557 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755439AbdKJBFj (ORCPT ); Thu, 9 Nov 2017 20:05:39 -0500 X-Google-Smtp-Source: AGs4zMapyGVg9cgtMGBUApnJFkkk4ZqWPpr3EpvCLaSSsY146wwYKFVapIB8kfpKi+NeuzQQA96TTA== From: Stefan Schake To: dri-devel@lists.freedesktop.org Cc: linux-rpi-kernel@lists.infradead.org, Stefan Schake , Eric Anholt , David Airlie , linux-kernel@vger.kernel.org Subject: [PATCH 0/2] drm/vc4: Correctly uninstall interrupts Date: Fri, 10 Nov 2017 02:05:05 +0100 Message-Id: <1510275907-993-1-git-send-email-stschake@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This set of patches fixes issues with vc4_irq_uninstall. The first patch fixes a NULL pointer dereference when the binner BO would disappear during an in flight overflow mem work callback. The second patch ensures we return with all interrupts disabled. This was suspected to cause the NULL dereference but turned out to be unrelated. Tested with a Raspberry Pi CM 3 that was previously stuck in a boot loop due to the issue. With the patch applied, the NULL dereference was no longer observed through numerous resets. Stefan Schake (2): drm/vc4: Account for interrupts in flight drm/vc4: Ensure interrupts are disabled drivers/gpu/drm/vc4/vc4_irq.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) -- 1.9.1