Re: [RFC 0/3] GuC functions name/prototype update

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On Fri, 2017-11-10 at 10:04 +0000, Chris Wilson wrote:
> Quoting Sagar Arun Kamble (2017-11-10 09:59:44)
> > We want to have consistent function/structure/file naming and
> > function parameter semantics. Suggestion from Michal Wajdeczko about
> > using "genx_" prefix (or better _genx" suffix for all hw related
> > structures types, offsets), "i915_" prefix for driver entry calls and
> > "intel_" in all other seems to be the good scheme to go ahead.
> > Also we need to adhere to practise of passing drm_i915_private to
> > functions with "i915_" prefix and component structure to functions
> > with "intel_" prefix. This series updates GuC submission related code
> > with these changes.
> > 
> > With GuC submission being hardware interface for i915, we should name
> > those functions with prefix "intel_guc" and pass struct intel_guc as
> > parameter. Also i915_guc_client struct is kernel-hw interaction
> > structure hence rename that to intel_guc_client.
> > With these changes GuC submission source files are now named with
> > "intel_" prefix.
> 
> Lgtm.
> 
> Having intel_guc_client be the HW facing struct, leaves i915_guc_client
> in case we ever need something to track uabi.

Yep,

Please make sure that make htmldocs keeps working after the renames.

Under Documentation/gpu

i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_loader.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/i915_guc_submission.c
i915.rst:.. kernel-doc:: drivers/gpu/drm/i915/intel_guc_fwif.h

With that fixed, the series is;

Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx