From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] binutils: Allow upstream 2.29 to be chosen for ARC
Date: Fri, 10 Nov 2017 15:42:40 +0000 [thread overview]
Message-ID: <1510328560.1303.25.camel@synopsys.com> (raw)
In-Reply-To: <e30aedee-15f1-a8eb-c959-4c9269ce1929@mind.be>
Hi Arnout,
On Fri, 2017-11-10 at 16:40 +0100, Arnout Vandecappelle wrote:
> ?Small nit...
>
> On 09-11-17 22:59, Alexey Brodkin wrote:
> [snip]
> >
> > diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> > index d2bf5b9..8654239 100644
> > --- a/package/binutils/binutils.mk
> > +++ b/package/binutils/binutils.mk
> > @@ -15,7 +15,7 @@ BINUTILS_VERSION = 2.28.1
> > ?endif
> > ?endif # BINUTILS_VERSION
> > ?
> > -ifeq ($(BR2_arc),y)
> > +ifneq ($(BR2_BINUTILS_VERSION_ARC),)
>
> ?Use positive logic:
>
> ifeq ($(BR2_BINUTILS_VERSION_ARC),y)
For some reason I used to do it the other way around :)
But indeed may follow your suggestion.
-Alexey
prev parent reply other threads:[~2017-11-10 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 21:59 [Buildroot] [PATCH] binutils: Allow upstream 2.29 to be chosen for ARC Alexey Brodkin
2017-11-10 15:40 ` Arnout Vandecappelle
2017-11-10 15:42 ` Alexey Brodkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510328560.1303.25.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.