From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750943AbdKKNxR (ORCPT ); Sat, 11 Nov 2017 08:53:17 -0500 Received: from smtprelay0034.hostedemail.com ([216.40.44.34]:59752 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750742AbdKKNxP (ORCPT ); Sat, 11 Nov 2017 08:53:15 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:967:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6117:6691:7901:7974:9025:10004:10400:10848:11232:11658:11914:12043:12555:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21063:21067:21080:21325:21326:21451:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: pail50_3957b10aaa456 X-Filterd-Recvd-Size: 1884 Message-ID: <1510408392.10883.5.camel@perches.com> Subject: Re: [PATCH v3] checkpatch.pl: Add SPDX license tag check From: Joe Perches To: Rob Herring , linux-kernel@vger.kernel.org Cc: Andy Whitcroft , Greg Kroah-Hartman Date: Sat, 11 Nov 2017 05:53:12 -0800 In-Reply-To: <20171110201909.6144-1-robh@kernel.org> References: <20171110201909.6144-1-robh@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-11-10 at 14:19 -0600, Rob Herring wrote: > SPDX license tags are a thing now in the kernel[1]. It has also been > decided to make them the first line in files. As Linus put it: Yes, SPDX tags are used in about a quarter of the files in the kernel. Again, where is this shown to be desired that this goes into _every_ file? If that is so, it needs to be specified _first_ somewhere in the Documentation/ tree. Probably in the process - 1.5 Licensing section. > "The real reason _I_ personally would like to see at least all the new > SPDX lines to go at the very top of the file is that every time when > we have some kind of ambiguity about placement, we end up with > multiple cases, and then people don't notice when merging, and you end > up having two - or you just end up having unnecessary merge conflicts > because two different people picked two different choices)." > > Add a warning if SPDX-License-Identifier tag is not present in the first > line (or 2nd for #! scripts) of files. > > [1] https://lwn.net/Articles/738235/ subscription only link