From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5I66-000759-NS for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5I60-0003fT-Oh for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:33 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:49057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5I60-0003fL-Gf for qemu-devel@nongnu.org; Tue, 24 May 2016 15:34:28 -0400 Date: Tue, 24 May 2016 15:34:24 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1510504332.743167.1464118464547.JavaMail.zimbra@redhat.com> In-Reply-To: <1464097171.20136.4.camel@redhat.com> References: <1455873289-349-1-git-send-email-kraxel@redhat.com> <1458307049.6882.54.camel@redhat.com> <1458555845.4299.49.camel@redhat.com> <1464011569.29367.27.camel@redhat.com> <1464097171.20136.4.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Spice-devel] [PATCH v2 10/12] spice/gl: create dummy primary surface (RfC) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , spice-devel , QEMU Hi ----- Original Message ----- > On Mo, 2016-05-23 at 16:03 +0200, Marc-Andr=C3=A9 Lureau wrote: > > Hi > >=20 > > On Mon, May 23, 2016 at 3:52 PM, Gerd Hoffmann wrot= e: > > > Hi, > > > > > > Resuming to work on this after 2.6 freeze break ... > > > > > >> I have done some more testing and sent a series for spice-gtk fixing > > >> display with gl scanout-only case. And a minor patch to spice server > > >> to solve a cursor initialization when there is no canvas. >=20 > What is the upstream status of this? Built a bunch of fresh packages > today, including new spice-server and spice-gtk from master branch. And > a bunch spice-gtk dependencies, due to soname change. Still not working > without the dummy primary surface. spicy from master works for me. However I found an issue with virt-viewer, = due to delayed widget realize in this gl-only case, see: https://lists.free= desktop.org/archives/spice-devel/2016-May/029446.html >=20 > > >> (process:21117): Spice-CRITICAL **: > > >> red-qxl.c:900:spice_qxl_gl_draw_async: condition > > >> `qxl_state->scanout.drm_dma_buf_fd !=3D -1' failed >=20 > > I can't really make sense of a call to spice_qxl_gl_draw_async() if > > there is no scanout backing. So I can imagine the fix is on qemu side. >=20 > Indeed. That one should be fixed now. Thanks >=20 > > Do you have an up to date branch for testing? >=20 > Pushed fresh branch to the usual work/virgl location. I found a cursor issue, due to spice worker being idle, and this solves it:= What do you think? commit bae34dde7b229cc87347639ac34d835b80725e1f Author: Marc-Andr=C3=A9 Lureau Date: Tue May 24 20:34:05 2016 +0200 spice: wakeup worker to pick up mouse changes =20 Signed-off-by: Marc-Andr=C3=A9 Lureau diff --git a/ui/spice-display.c b/ui/spice-display.c index 5ed7630..a04432c 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -766,6 +766,7 @@ static void display_mouse_set(DisplayChangeListener *dc= l, g_free(ssd->ptr_move); ssd->ptr_move =3D qemu_spice_create_cursor_update(ssd, NULL, on); qemu_mutex_unlock(&ssd->lock); + qemu_spice_wakeup(ssd); } =20 static void display_mouse_define(DisplayChangeListener *dcl, @@ -784,6 +785,7 @@ static void display_mouse_define(DisplayChangeListener = *dcl, g_free(ssd->ptr_define); ssd->ptr_define =3D qemu_spice_create_cursor_update(ssd, c, 0); qemu_mutex_unlock(&ssd->lock); + qemu_spice_wakeup(ssd); } =20 static const DisplayChangeListenerOps display_listener_ops =3D {