From mboxrd@z Thu Jan  1 00:00:00 1970
From: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [net-next] tcp: allow drivers to tweak TSQ logic
Date: Mon, 13 Nov 2017 10:21:17 +0100
Message-ID: <1510564877.30497.3.camel@sipsolutions.net>
References: <1510281664.2849.143.camel@edumazet-glaptop3.roam.corp.google.com>
         <1510410439.12037.10.camel@sipsolutions.net>
         <1510443535.2849.147.camel@edumazet-glaptop3.roam.corp.google.com>
         (sfid-20171112_003900_506756_66B2F6DE)
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>,
        Kir Kolyshkin <kir@openvz.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from s3.sipsolutions.net ([144.76.63.242]:47630 "EHLO
        sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751161AbdKMJVV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 13 Nov 2017 04:21:21 -0500
In-Reply-To: <1510443535.2849.147.camel@edumazet-glaptop3.roam.corp.google.com> (sfid-20171112_003900_506756_66B2F6DE)
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 2017-11-11 at 15:38 -0800, Eric Dumazet wrote:

> > Hm. I wish we wouldn't have to do this on every skb, but perhaps it
> > doesn't matter that much.
> 
> Yes, it does not matter, even at 40Gbit ;)

:)

> Same cache line already ;)

Hah. It seemed so far away, but actually looking at the layout helps :)

> > Unrelated to that, I think this is missing a documentation update since
> > the struct has kernel-doc comments.
> 
> Yeah, I believe these kernel-doc on gigantic struct sock are useless and
> we should remove them, they have zero useful info.

No argument from me, but while it's there ... anyway I see you resent
this, thanks for doing this.

I'll try to get people to run some tests for our driver.

johannes