Re: [PATCH] IW: Zero or Uninitialized value of keylen passing

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2017-11-02 at 11:28 +0000, Amit Khatri wrote:
> From b755c8ee282abbd0008e9e7241c457662c90f2c3 Mon Sep 17 00:00:00 2001
> From: Amit Khatri <amit.khatri@samsung.com>
> Date: Thu, 2 Nov 2017 15:55:16 +0530
> Subject: [PATCH] IW: Zero or Uninitialized value of keylen passing
> 
> In case of hexadeciaml keydata, keylen is not gettig updated
> and passing in NLA_PUT(msg, NL80211_KEY_DATA, keylen, keydata)
> as zero (becasue of local variable).
> 
> This patch initilalize keylen variable in case of hexkey data.

Uh. Please re-read the code. I'll selectively quote for you (without
your changes):

>  		case 10:
>  			keydata = hex2bin(keydata, keybuf);
>  		case 5:
>  			NLA_PUT_U32(msg, NL80211_KEY_CIPHER, 0x000FAC01);
>  			keylen = 5;
>  			break;

johannes