All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net: improve vlan header type alignment
Date: Fri, 18 Oct 2024 11:11:18 +0200	[thread overview]
Message-ID: <15105967.O6BkTfRZtg@thomas> (raw)
In-Reply-To: <20241013083554.97489-1-mb@smartsharesystems.com>

13/10/2024 10:35, Morten Brørup:
> Ethernet packets can be VLAN tagged, i.e. an Ethernet header can have a
> VLAN tag (a.k.a. VLAN header) embedded.
> Since the Ethernet header is 2 byte aligned, and the VLAN tag is directly
> related to the Ethernet header, the VLAN tag is also 2 byte aligned, so
> packing the VLAN tag structure is not necessary.
> 
> Furthermore, the Ethernet header type is implictly 2 byte aligned, so
> removed the superfluous explicit 2 byte alignment.
> 
> Added static_asserts to verify the size and alignment of the various
> Ethernet types.
> 
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>

Applied, thanks.




      parent reply	other threads:[~2024-10-18  9:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-13  8:35 [PATCH] net: improve vlan header type alignment Morten Brørup
2024-10-13  8:51 ` Morten Brørup
2024-10-14  5:42 ` fengchengwen
2024-10-14  8:04 ` Bruce Richardson
2024-10-17 20:44 ` Thomas Monjalon
2024-10-17 23:41   ` Morten Brørup
2024-10-18  9:11 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15105967.O6BkTfRZtg@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.