From: Patrick Ohly <patrick.ohly@intel.com>
To: Ross Burton <ross.burton@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] oeqa/selftest/runtime_test: fix postinst_rootfs_and_boot
Date: Tue, 14 Nov 2017 13:06:05 +0100 [thread overview]
Message-ID: <1510661165.5979.6.camel@intel.com> (raw)
In-Reply-To: <20171106175558.24581-1-ross.burton@intel.com>
On Mon, 2017-11-06 at 17:55 +0000, Ross Burton wrote:
> testcommand = 'ls /etc/' + fileboot_name
Can't this be removed?
> with runqemu('core-image-minimal') as qemu:
> - ssh = SSHControl(ip=qemu.ip, logfile=qemu.sshlog)
> - status, output = ssh.run(testcommand)
> + status, output = qemu.run_serial("-f /etc/" + fileboot_name)
Did you mean "test -f"?
> self.assertEqual(status, 0, 'File %s was not created at first boot (%s)' % (fileboot_name, output))
run_serial has the quirk that status == 1 on *success*. Yes, weird.
The test probably passed because it was testing for failure, and the
missing "test" ensured that the command failed.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2017-11-14 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:55 [PATCH] oeqa/selftest/runtime_test: fix postinst_rootfs_and_boot Ross Burton
2017-11-14 12:06 ` Patrick Ohly [this message]
2017-11-14 12:45 ` Burton, Ross
-- strict thread matches above, loose matches on Subject: below --
2017-11-07 10:32 Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510661165.5979.6.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.