From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: Fwd: [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines Date: Wed, 15 Nov 2017 13:38:39 +0200 Message-ID: <1510745919.25007.234.camel@linux.intel.com> References: <1510096056-13765-3-git-send-email-timur@codeaurora.org> <20171115062837.GA22802@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga07.intel.com ([134.134.136.100]:36382 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932347AbdKOLkO (ORCPT ); Wed, 15 Nov 2017 06:40:14 -0500 In-Reply-To: <20171115062837.GA22802@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Varadarajan Narayanan , timur@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Linus Walleij , Mika Westerberg , thierry.reding@gmail.com, Stephen Boyd , david.brown@linaro.org, andy.gross@linaro.org, Bjorn Andersson On Wed, 2017-11-15 at 11:58 +0530, Varadarajan Narayanan wrote: > > + if (gpiochip->irq_need_valid_mask) { > > + gpiochip->irq_valid_mask = > > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio), > > + sizeof(long), GFP_KERNEL); > > Since 'irq_valid_mask' is getting filled below wouldn't a kmalloc > suffice? I suppose you meant kmalloc_array. Anyway, it's a separate change if you wish, because Timur didn't change the original approach here. > > + if (!gpiochip->irq_valid_mask) > > + return -ENOMEM; > > > > + /* Assume by default all GPIOs are valid */ > > + bitmap_fill(gpiochip->irq_valid_mask, gpiochip- > > >ngpio); > > + } > > > > + if (gpiochip->line_need_valid_mask) { > > + gpiochip->line_valid_mask = > > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio), > > + sizeof(long), GFP_KERNEL); > > Since 'line_valid_mask' is getting filled below wouldn't a kmalloc > suffice? This one just mimics previous, so, see above. -- Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 From: andriy.shevchenko@linux.intel.com (Andy Shevchenko) Date: Wed, 15 Nov 2017 13:38:39 +0200 Subject: Fwd: [PATCH 2/4] gpiolib: add bitmask for valid GPIO lines In-Reply-To: <20171115062837.GA22802@codeaurora.org> References: <1510096056-13765-3-git-send-email-timur@codeaurora.org> <20171115062837.GA22802@codeaurora.org> Message-ID: <1510745919.25007.234.camel@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2017-11-15 at 11:58 +0530, Varadarajan Narayanan wrote: > > + if (gpiochip->irq_need_valid_mask) { > > + gpiochip->irq_valid_mask = > > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio), > > + sizeof(long), GFP_KERNEL); > > Since 'irq_valid_mask' is getting filled below wouldn't a kmalloc > suffice? I suppose you meant kmalloc_array. Anyway, it's a separate change if you wish, because Timur didn't change the original approach here. > > + if (!gpiochip->irq_valid_mask) > > + return -ENOMEM; > > > > + /* Assume by default all GPIOs are valid */ > > + bitmap_fill(gpiochip->irq_valid_mask, gpiochip- > > >ngpio); > > + } > > > > + if (gpiochip->line_need_valid_mask) { > > + gpiochip->line_valid_mask = > > + kcalloc(BITS_TO_LONGS(gpiochip->ngpio), > > + sizeof(long), GFP_KERNEL); > > Since 'line_valid_mask' is getting filled below wouldn't a kmalloc > suffice? This one just mimics previous, so, see above. -- Andy Shevchenko Intel Finland Oy