From: Knut Omang <knut.omang@oracle.com>
To: Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org
Cc: Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter
Date: Thu, 16 Nov 2017 18:43:28 +0100 [thread overview]
Message-ID: <1510854208.3063.33.camel@oracle.com> (raw)
In-Reply-To: <1510852186.31559.37.camel@perches.com>
On Thu, 2017-11-16 at 09:09 -0800, Joe Perches wrote:
> (adding Andrew Morton)
>
> On Thu, 2017-11-16 at 18:01 +0100, Knut Omang wrote:
> > This parameter is intended to be used in a subsequent commit to kbuild to allow
> > a convenient way to run checkpatch from make.
>
> _why_ is this useful?
The cover letter and the following documentation patch hopefully makes it
clearer.
I realize the cc: list on the cover letter was a little too narrow, sorry about that!
> > By accepting comments and multiple lines of commands, the idea is that the
> > maintainer or someone else with good knowledge of the code can maintain a file
> > per directory and group the different commands into commented sections that can
> > serve both as documentation of the current checkpatch status, a way to define
> > the line of tolerance (and gradually tighten it as fixes comes in) and as
> > documentation of TODOs and dont's if there are well justified exceptions.
>
> checkpatch can be run any time over individual files
> so I don't find this compelling.
The problem with that in general is the noise level.
What this patch set gives is in short:
* a way to filter out the noise to focus on one type of error at the time
* the means to automate prevention of reoccurrence of some types of checkpatch
errors that have been removed from a file, even when that file has
100s of checkpatch issues of other types.
> Does anyone else?
I did subject the set to a couple of internal reviews with positive feedback.
We have also had automated checkin regression testing going with
a similar system for some time. I was just going to improve upon that system
when I realized that we should really make it available for the broader community.
I hope this helps,
thanks,
Knut
next prev parent reply other threads:[~2017-11-16 17:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 17:01 [PATCH 0/7] Support for automatic checkpatch running in the kernel Knut Omang
2017-11-16 17:01 ` [PATCH 1/7] checkpatch: Implement new --ignore-cfg parameter Knut Omang
2017-11-16 17:09 ` Joe Perches
2017-11-16 17:43 ` Knut Omang [this message]
2017-11-16 17:01 ` [PATCH 2/7] kbuild: Add P= command line flag to run checkpatch Knut Omang
2017-11-20 16:18 ` Masahiro Yamada
2017-11-20 19:48 ` Jim Davis
2017-11-20 20:08 ` Luc Van Oostenryck
2017-11-20 21:10 ` Knut Omang
2017-11-20 21:22 ` Luc Van Oostenryck
2017-11-21 0:00 ` Jim Davis
2017-11-21 8:10 ` Knut Omang
2017-11-21 19:48 ` Jim Davis
2017-11-21 20:03 ` Joe Perches
2017-11-20 21:04 ` Knut Omang
2017-11-16 17:01 ` [PATCH 3/7] checkpatch: Add a few convenience options to disable/modify features Knut Omang
2017-11-16 17:01 ` [PATCH 4/7] Documentation: Add documentation for the new P= Makefile option Knut Omang
2017-11-16 17:01 ` [PATCH 5/7] checkpatch: Improve --fix-inplace for TABSTOP Knut Omang
2017-11-16 17:01 ` [PATCH 6/7] checkpatch: Make --ignore-cfg look recursively for the file Knut Omang
2017-11-16 17:01 ` [PATCH 7/7] Documentation: Update checkpatch --ignore-cfg description Knut Omang
2017-11-16 22:57 ` [PATCH 0/7] Support for automatic checkpatch running in the kernel Kees Cook
2017-11-17 4:47 ` Knut Omang
2017-11-17 9:08 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510854208.3063.33.camel@oracle.com \
--to=knut.omang@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.