From mboxrd@z Thu Jan 1 00:00:00 1970 From: l.stach@pengutronix.de (Lucas Stach) Date: Fri, 17 Nov 2017 15:36:23 +0100 Subject: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display In-Reply-To: <20171117151334.041c4684@jawa> References: <20171117102404.6678-1-lukma@denx.de> <20171117131047.GE25390@dragon> <20171117151334.041c4684@jawa> Message-ID: <1510929383.8104.3.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski: > Hi Shawn, > > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote: > > > This is the support for aa070mc01-ca1 Mitsubishi display. > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > > ?arch/arm/boot/dts/Makefile?????????????????????????|??1 + > > > ?.../imx6q-display5-mitsubishi-aa070-800x480.dts????| 51 > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+) > > > ?create mode 100644 > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile > > > b/arch/arm/boot/dts/Makefile > > > index d9d0c82e7d20..10b3ad078dea 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > > > ? imx6q-cm-fx6.dtb \ > > > ? imx6q-cubox-i.dtb \ > > > ? imx6q-dfi-fs700-m60.dtb \ > > > + imx6q-display5-mitsubishi-aa070-800x480.dtb \ > > > ? imx6q-display5-tianma-tm070-1280x768.dtb \ > > > ? imx6q-dmo-edmqmx6.dtb \ > > > ? imx6q-evi.dtb \?? > > > > > > > > > +#include "imx6q-display5.dtsi" > > > + > > > +&panel { > > > + compatible = "mitsubishi,aa070mc01-ca1"; > > > +};?? > > > > How many DTB files do you want to add for this display5 board??? > > This is a single board, which can support panels which I've posted. > > Those dtbs I do pack to u-boot' FIT image and don't need to worry > that > some display is not working (after setting bootloader env variable). > > > It's > > obvious no fun to maintain a bunch of DTB files for all the panels > > this board can support. > > Please note that those files excessively use #include directive, and > there is not so much code added (the longest part is license and > comments). > > > ?Let's stop right here. > > If I may ask - how shall I proceed? What would be your suggestion to > move on (dtb overlays) ? The solution we use for the ZII RDU1 and RDU2 boards is to have the bootloader patch in the correct panel compatible strings. This is quite a bit simpler than using overlays and if you already have a environment variable for this it should be easy to do. > > > > Shawn > > > > > + > > > +&ldb { > > > + lvds0: lvds-channel at 0 { > > > + fsl,data-mapping = "spwg"; > > > + fsl,data-width = <24>; > > > + }; > > > +}; This isn't needed. The panel compatible implies the data mapping and bus width (at least if you properly filled in this information in the panel driver). Regards, Lucas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display Date: Fri, 17 Nov 2017 15:36:23 +0100 Message-ID: <1510929383.8104.3.camel@pengutronix.de> References: <20171117102404.6678-1-lukma@denx.de> <20171117131047.GE25390@dragon> <20171117151334.041c4684@jawa> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20171117151334.041c4684@jawa> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lukasz Majewski , Shawn Guo Cc: Mark Rutland , Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Sascha Hauer , Fabio Estevam , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski: > Hi Shawn, > > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote: > > > This is the support for aa070mc01-ca1 Mitsubishi display. > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > >  arch/arm/boot/dts/Makefile                         |  1 + > > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51 > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+) > > >  create mode 100644 > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile > > > b/arch/arm/boot/dts/Makefile > > > index d9d0c82e7d20..10b3ad078dea 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > > >   imx6q-cm-fx6.dtb \ > > >   imx6q-cubox-i.dtb \ > > >   imx6q-dfi-fs700-m60.dtb \ > > > + imx6q-display5-mitsubishi-aa070-800x480.dtb \ > > >   imx6q-display5-tianma-tm070-1280x768.dtb \ > > >   imx6q-dmo-edmqmx6.dtb \ > > >   imx6q-evi.dtb \   > > > > > > > > > +#include "imx6q-display5.dtsi" > > > + > > > +&panel { > > > + compatible = "mitsubishi,aa070mc01-ca1"; > > > +};   > > > > How many DTB files do you want to add for this display5 board?   > > This is a single board, which can support panels which I've posted. > > Those dtbs I do pack to u-boot' FIT image and don't need to worry > that > some display is not working (after setting bootloader env variable). > > > It's > > obvious no fun to maintain a bunch of DTB files for all the panels > > this board can support. > > Please note that those files excessively use #include directive, and > there is not so much code added (the longest part is license and > comments). > > >  Let's stop right here. > > If I may ask - how shall I proceed? What would be your suggestion to > move on (dtb overlays) ? The solution we use for the ZII RDU1 and RDU2 boards is to have the bootloader patch in the correct panel compatible strings. This is quite a bit simpler than using overlays and if you already have a environment variable for this it should be easy to do. > > > > Shawn > > > > > + > > > +&ldb { > > > + lvds0: lvds-channel@0 { > > > + fsl,data-mapping = "spwg"; > > > + fsl,data-width = <24>; > > > + }; > > > +}; This isn't needed. The panel compatible implies the data mapping and bus width (at least if you properly filled in this information in the panel driver). Regards, Lucas -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964890AbdKQOgh (ORCPT ); Fri, 17 Nov 2017 09:36:37 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55685 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbdKQOgb (ORCPT ); Fri, 17 Nov 2017 09:36:31 -0500 Message-ID: <1510929383.8104.3.camel@pengutronix.de> Subject: Re: [PATCH 1/2] ARM: dts: Add the support for display5 equipped with Mitsubishi (800x480) display From: Lucas Stach To: Lukasz Majewski , Shawn Guo Cc: Mark Rutland , Rob Herring , devicetree@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org Date: Fri, 17 Nov 2017 15:36:23 +0100 In-Reply-To: <20171117151334.041c4684@jawa> References: <20171117102404.6678-1-lukma@denx.de> <20171117131047.GE25390@dragon> <20171117151334.041c4684@jawa> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 17.11.2017, 15:13 +0100 schrieb Lukasz Majewski: > Hi Shawn, > > > On Fri, Nov 17, 2017 at 11:24:03AM +0100, Lukasz Majewski wrote: > > > This is the support for aa070mc01-ca1 Mitsubishi display. > > > > > > Signed-off-by: Lukasz Majewski > > > --- > > >  arch/arm/boot/dts/Makefile                         |  1 + > > >  .../imx6q-display5-mitsubishi-aa070-800x480.dts    | 51 > > > ++++++++++++++++++++++ 2 files changed, 52 insertions(+) > > >  create mode 100644 > > > arch/arm/boot/dts/imx6q-display5-mitsubishi-aa070-800x480.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile > > > b/arch/arm/boot/dts/Makefile > > > index d9d0c82e7d20..10b3ad078dea 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -407,6 +407,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \ > > >   imx6q-cm-fx6.dtb \ > > >   imx6q-cubox-i.dtb \ > > >   imx6q-dfi-fs700-m60.dtb \ > > > + imx6q-display5-mitsubishi-aa070-800x480.dtb \ > > >   imx6q-display5-tianma-tm070-1280x768.dtb \ > > >   imx6q-dmo-edmqmx6.dtb \ > > >   imx6q-evi.dtb \   > > > > > > > > > +#include "imx6q-display5.dtsi" > > > + > > > +&panel { > > > + compatible = "mitsubishi,aa070mc01-ca1"; > > > +};   > > > > How many DTB files do you want to add for this display5 board?   > > This is a single board, which can support panels which I've posted. > > Those dtbs I do pack to u-boot' FIT image and don't need to worry > that > some display is not working (after setting bootloader env variable). > > > It's > > obvious no fun to maintain a bunch of DTB files for all the panels > > this board can support. > > Please note that those files excessively use #include directive, and > there is not so much code added (the longest part is license and > comments). > > >  Let's stop right here. > > If I may ask - how shall I proceed? What would be your suggestion to > move on (dtb overlays) ? The solution we use for the ZII RDU1 and RDU2 boards is to have the bootloader patch in the correct panel compatible strings. This is quite a bit simpler than using overlays and if you already have a environment variable for this it should be easy to do. > > > > Shawn > > > > > + > > > +&ldb { > > > + lvds0: lvds-channel@0 { > > > + fsl,data-mapping = "spwg"; > > > + fsl,data-width = <24>; > > > + }; > > > +}; This isn't needed. The panel compatible implies the data mapping and bus width (at least if you properly filled in this information in the panel driver). Regards, Lucas