From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Frank Ch. Eigler" <fche@redhat.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint
Date: Thu, 13 Mar 2014 18:22:52 +0000 (UTC) [thread overview]
Message-ID: <1510944043.2892.1394734972867.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <1394734673.26600.10.camel@pippen.local.home>
----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: "Frank Ch. Eigler" <fche@redhat.com>, linux-kernel@vger.kernel.org, "Ingo Molnar" <mingo@kernel.org>, "Frederic
> Weisbecker" <fweisbec@gmail.com>, "Andrew Morton" <akpm@linux-foundation.org>, "Johannes Berg"
> <johannes.berg@intel.com>
> Sent: Thursday, March 13, 2014 2:17:53 PM
> Subject: Re: [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint
>
> On Thu, 2014-03-13 at 16:54 +0000, Mathieu Desnoyers wrote:
>
> > The other use-case is if the tracer has a module coming/going notifier
> > tracking the module's tracepoint callsites. The going notifier should
> > be run before the tracepoint.c going notifier. A notifier with negative
> > priority should have this effect, since the tracepoint.c notifier has
> > priority 0.
> >
>
> The tracepoint should change to have two different notifiers that
> represent one for coming and one for going (as ftrace does). The coming
> one should have a priority of 0 (or INT_MIN (all other notifiers
> dependent on this should have > 0)
>
> The going notifier should have a INT_MAX to run after all other
> tracepoint notifiers. (see kernel/trace/ftrace.c ftrace_module_enter_nb
> and ftrace_module_exit_nb)
OK, I'll spin a v4 with this change.
Thanks!
Mathieu
>
> -- Steve
>
>
>
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2014-03-13 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 16:10 [RFC PATCH v2] Tracepoint: register/unregister struct tracepoint Mathieu Desnoyers
2014-03-13 16:35 ` Frank Ch. Eigler
2014-03-13 16:54 ` Mathieu Desnoyers
2014-03-13 18:17 ` Steven Rostedt
2014-03-13 18:22 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1510944043.2892.1394734972867.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=akpm@linux-foundation.org \
--cc=fche@redhat.com \
--cc=fweisbec@gmail.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.