From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761910AbdKROkN (ORCPT ); Sat, 18 Nov 2017 09:40:13 -0500 Received: from smtprelay0180.hostedemail.com ([216.40.44.180]:34401 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761783AbdKROkF (ORCPT ); Sat, 18 Nov 2017 09:40:05 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:1981:2194:2199:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:8985:9025:9108:10004:10400:10848:11026:11232:11658:11914:12043:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: food31_24d8bc51d5a X-Filterd-Recvd-Size: 1359 Message-ID: <1511015995.31022.11.camel@perches.com> Subject: Re: [PATCH] checkpatch: allow URL >80 chars From: Joe Perches To: Andreas Brauchli , Andy Whitcroft Cc: linux-kernel@vger.kernel.org Date: Sat, 18 Nov 2017 06:39:55 -0800 In-Reply-To: <1510999663.4806.28.camel@elementarea.net> References: <1510934219.2407.4.camel@elementarea.net> <1510982478.31022.3.camel@perches.com> <1510999663.4806.28.camel@elementarea.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-11-18 at 11:07 +0100, Andreas Brauchli wrote: > Is the patch acceptable if it only catches URL with protocol specifiers > foo:// ? That would catch most cases and doesn't show false positives: > $ git grep -E '://\S{75}.*' -- '*.[ch]' Of course. but I suggest using a prefix like \b[\w\.\+\-]+:// so the URL scheme is properly described. It might be best if there was some generic mechanism to identify possible URIs and not just URLs instead. https://en.wikipedia.org/wiki/Uniform_Resource_Identifier