From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:41475 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170AbdKRRjv (ORCPT ); Sat, 18 Nov 2017 12:39:51 -0500 From: Trond Myklebust To: "boris.ostrovsky@oracle.com" , "Anna.Schumaker@Netapp.com" CC: "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" Subject: Re: Commit fcd8843c40 breaks old compilers Date: Sat, 18 Nov 2017 17:39:45 +0000 Message-ID: <1511026783.10238.2.camel@primarydata.com> References: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> In-Reply-To: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gU2F0LCAyMDE3LTExLTE4IGF0IDEyOjE5IC0wNTAwLCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6 DQo+IENvbW1pdCBmY2Q4ODQzYzQwNmI0NjQzMzg1N2FlNDVlNWU5ZDg0YjAxYTdkMjBiIGJyZWFr cyBvbiBvbGRlcg0KPiBjb21waWxlcnMgd2hpY2ggY2Fubm90IHByb2Nlc3MgaW5pdGlhbGl6ZXJz IGZvciBhbm9ueW1vdXMgc3RydWN0dXJlczoNCj4gDQo+ICtjb25zdCBuZnM0X3N0YXRlaWQgaW52 YWxpZF9zdGF0ZWlkID0gew0KPiArICAgICAgIHsNCj4gKyAgICAgICAgICAgICAgIC5zZXFpZCA9 IGNwdV90b19iZTMyKDB4ZmZmZmZmZmZVKSwNCj4gKyAgICAgICAgICAgICAgIC5vdGhlciA9IHsg MCB9LA0KPiArICAgICAgIH0sDQo+ICsgICAgICAgLnR5cGUgPSBORlM0X0lOVkFMSURfU1RBVEVJ RF9UWVBFLA0KPiArfTsNCj4gDQo+IA0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMv bmZzNHN0YXRlLmM6NzQ6IGVycm9yOiB1bmtub3duIGZpZWxkDQo+IOKAmHNlcWlk4oCZIHNwZWNp ZmllZCBpbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZz NHN0YXRlLmM6NzQ6IHdhcm5pbmc6IG1pc3NpbmcNCj4gYnJhY2VzDQo+IGFyb3VuZCBpbml0aWFs aXplcg0KPiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzQ6IHdh cm5pbmc6IChuZWFyDQo+IGluaXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFu b255bW91cz4uZGF0YeKAmSkNCj4gL2hvbWUvYnVpbGQvbGludXgtbGludXMvZnMvbmZzL25mczRz dGF0ZS5jOjc0OiB3YXJuaW5nOiBvdmVyZmxvdyBpbg0KPiBpbXBsaWNpdCBjb25zdGFudCBjb252 ZXJzaW9uDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTog ZXJyb3I6IHVua25vd24gZmllbGQNCj4g4oCYb3RoZXLigJkgc3BlY2lmaWVkIGluIGluaXRpYWxp emVyDQo+IC9ob21lL2J1aWxkL2xpbnV4LWxpbnVzL2ZzL25mcy9uZnM0c3RhdGUuYzo3NTogZXJy b3I6IGV4dHJhIGJyYWNlDQo+IGdyb3VwDQo+IGF0IGVuZCBvZiBpbml0aWFsaXplcg0KPiAvaG9t ZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IGVycm9yOiAobmVhcg0K PiBpbml0aWFsaXphdGlvbiBmb3Ig4oCYaW52YWxpZF9zdGF0ZWlkLjxhbm9ueW1vdXM+4oCZKQ0K PiAvaG9tZS9idWlsZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6 IGV4Y2Vzcw0KPiBlbGVtZW50cw0KPiBpbiB1bmlvbiBpbml0aWFsaXplcg0KPiAvaG9tZS9idWls ZC9saW51eC1saW51cy9mcy9uZnMvbmZzNHN0YXRlLmM6NzU6IHdhcm5pbmc6IChuZWFyDQo+IGlu aXRpYWxpemF0aW9uIGZvciDigJhpbnZhbGlkX3N0YXRlaWQuPGFub255bW91cz7igJkpDQo+IG1h a2VbNF06ICoqKiBbZnMvbmZzL25mczRzdGF0ZS5vXSBFcnJvciAxDQo+IG1ha2VbM106ICoqKiBb ZnMvbmZzXSBFcnJvciAyDQo+IA0KPiANCj4gRkMtNjQgPGJ1aWxkQGJ1aWxkLW1rMjp+PiBnY2Mg LS12ZXJzaW9uDQo+IGdjYyAoR0NDKSA0LjQuNCAyMDEwMDUwMyAoUmVkIEhhdCA0LjQuNC0yKQ0K PiANCj4gDQo+IEEgc2ltaWxhciBidWcgd2FzIGZpeGVkIGJ5IGUwNzE0ZWM0ZjllZmU3Yjg2ODI4 YjBkY2MwNzdmZDhmNWQ4ZTVlOTENCj4gYnV0DQo+IEkgZG9uJ3QgdGhpbmsgdGhlIHNhbWUgYXBw cm9hY2ggY2FuIHdvcmsgaGVyZS4NCg0KDQpJIGRvbid0IGhhdmUgYW55IHNldHVwcyB3aXRoIGdj YyA0LjQuNC4gV2hhdCBpcyBpdCBleHBlY3RpbmcgaGVyZT8gSXMNCml0IGV4cGVjdGluZyBhbiBl eHRyYSBzZXQgb2YgYnJhY2VzIGR1ZSB0byB0aGUgYW5vbnltb3VzICJzdHJ1Y3QiPw0KDQotLSAN ClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyLCBQcmltYXJ5RGF0 YQ0KdHJvbmQubXlrbGVidXN0QHByaW1hcnlkYXRhLmNvbQ0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764891AbdKRRkC (ORCPT ); Sat, 18 Nov 2017 12:40:02 -0500 Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:20577 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762890AbdKRRjv (ORCPT ); Sat, 18 Nov 2017 12:39:51 -0500 From: Trond Myklebust To: "boris.ostrovsky@oracle.com" , "Anna.Schumaker@Netapp.com" CC: "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" Subject: Re: Commit fcd8843c40 breaks old compilers Thread-Topic: Commit fcd8843c40 breaks old compilers Thread-Index: AQHTYJGKUkJnaosyNE65IzhKw2g0qqMaZ0yA Date: Sat, 18 Nov 2017 17:39:45 +0000 Message-ID: <1511026783.10238.2.camel@primarydata.com> References: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> In-Reply-To: <09a3d9ca-d191-5899-613d-8d0dbe0b68ea@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0075;20:m+3ZLG/4/3thR6bGIGF4Dpuv69e7L5ok1ckkimxVLr9eV3bUPx08bF5hqxyNUHEyzOaZBbLXZCTa+VMr0ESDJMMWZuBnzyFLVfOD52EvPd5+8aKSQovxEP4JSI5ZOgfVh5LyHW2ek7IKes9ty3UURWi2FkatVQzGnxu8kkmFU7w= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 33c3468a-e807-4105-3214-08d52eab5c05 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603199);SRVR:DM5PR11MB0075; x-ms-traffictypediagnostic: DM5PR11MB0075: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(131327999870524); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(2016111802025)(20161123562025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR11MB0075;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR11MB0075; x-forefront-prvs: 04953B1F22 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39830400002)(346002)(376002)(377424004)(199003)(189002)(24454002)(189998001)(4326008)(3660700001)(6116002)(6436002)(2501003)(81156014)(33646002)(2950100002)(81166006)(3846002)(103116003)(99286004)(6246003)(102836003)(3280700002)(316002)(8676002)(66066001)(2900100001)(110136005)(54906003)(575784001)(86362001)(4001150100001)(25786009)(2906002)(54356999)(76176999)(101416001)(36756003)(5660300001)(68736007)(478600001)(97736004)(50986999)(8936002)(7736002)(106356001)(105586002)(14454004)(229853002)(6506006)(53936002)(6486002)(77096006)(305945005)(6512007);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB0075;H:DM5PR11MB0075.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <566D4C4FC8A55C4AAC8D1EAD056F19E2@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33c3468a-e807-4105-3214-08d52eab5c05 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2017 17:39:45.9829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0075 X-MC-Unique: vhk0yyV1OCqNRXMEX8aMJA-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAIHe8KC016659 On Sat, 2017-11-18 at 12:19 -0500, Boris Ostrovsky wrote: > Commit fcd8843c406b46433857ae45e5e9d84b01a7d20b breaks on older > compilers which cannot process initializers for anonymous structures: > > +const nfs4_stateid invalid_stateid = { > + { > + .seqid = cpu_to_be32(0xffffffffU), > + .other = { 0 }, > + }, > + .type = NFS4_INVALID_STATEID_TYPE, > +}; > > > /home/build/linux-linus/fs/nfs/nfs4state.c:74: error: unknown field > ‘seqid’ specified in initializer > /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: missing > braces > around initializer > /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: (near > initialization for ‘invalid_stateid..data’) > /home/build/linux-linus/fs/nfs/nfs4state.c:74: warning: overflow in > implicit constant conversion > /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: unknown field > ‘other’ specified in initializer > /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: extra brace > group > at end of initializer > /home/build/linux-linus/fs/nfs/nfs4state.c:75: error: (near > initialization for ‘invalid_stateid.’) > /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: excess > elements > in union initializer > /home/build/linux-linus/fs/nfs/nfs4state.c:75: warning: (near > initialization for ‘invalid_stateid.’) > make[4]: *** [fs/nfs/nfs4state.o] Error 1 > make[3]: *** [fs/nfs] Error 2 > > > FC-64 gcc --version > gcc (GCC) 4.4.4 20100503 (Red Hat 4.4.4-2) > > > A similar bug was fixed by e0714ec4f9efe7b86828b0dcc077fd8f5d8e5e91 > but > I don't think the same approach can work here. I don't have any setups with gcc 4.4.4. What is it expecting here? Is it expecting an extra set of braces due to the anonymous "struct"? -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com