From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP
Date: Mon, 20 Nov 2017 14:17:54 +0200 [thread overview]
Message-ID: <1511180274.25007.326.camel@linux.intel.com> (raw)
In-Reply-To: <CAEUhbmV_ZT0BNGgcPG5+CaR-Ga26QFgs+gCZWrgBQOyGif2ERA@mail.gmail.com>
On Mon, 2017-11-20 at 15:07 +0800, Bin Meng wrote:
> Hi Andy,
>
> On Sat, Nov 11, 2017 at 1:33 AM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > FLIS IP since now gets its own ACPI ID.
> > Drop PRP0001 workaround in favour of official ACPI HID.
> >
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Thanks, though I think it would be better to add _CRS as well to be
fully complete with device resources.
So, taking into consideration your below comment let me send v2 after
the ID makes Linux kernel.
> BTW: can you put some xrefs in the commit message like where the new
> ACPI ID is introduced? I did not find the "INTC1002" in my kernel
> tree.
The patch is under review, I'm pretty sure it will be in after merge
window closed.
> > Device (FLIS)
> > {
> > - Name (_HID, "PRP0001")
> > + Name (_HID, "INTC1002")
> > Name (_DDN, "Intel Merrifield Family-Level Interface Shim")
> > Name (RBUF, ResourceTemplate()
> > {
> > @@ -284,13 +284,6 @@ Device (FLIS)
> > Return (RBUF)
> > }
> >
> > - Name (_DSD, Package () {
> > - ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> > - Package () {
> > - Package () {"compatible", "intel,merrifield-pinctrl"},
> > - }
> > - })
> > -
> > Method (_STA, 0, NotSerialized)
> > {
> > Return (STA_VISIBLE)
> > --
>
> Regards,
> Bin
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-11-20 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 17:33 [U-Boot] [PATCH v1] x86: tangier: Use official ACPI HID for FLIS IP Andy Shevchenko
2017-11-20 7:07 ` Bin Meng
2017-11-20 12:17 ` Andy Shevchenko [this message]
2017-11-20 14:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511180274.25007.326.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.