Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions

From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "noralf@tronnes.org" <noralf@tronnes.org>
Cc: "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>,
	"marex@denx.de" <marex@denx.de>,
	"boris.brezillon@free-electrons.com"
	<boris.brezillon@free-electrons.com>,
	"z.liuxinliang@hisilicon.com" <z.liuxinliang@hisilicon.com>,
	"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
	"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
	"david@lechnology.com" <david@lechnology.com>,
	"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
	"jsarha@ti.com" <jsarha@ti.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"vincent.abriou@st.com" <vincent.abriou@st.com>,
	"alison.wang@freescale.com" <alison.wang@freescale.com>,
	"philippe.cornu@st.com" <philippe.cornu@st.com>,
	"yannick.fertre@st.com" <yannick.fertre@st.com>,
	zourongrong@gmail.c
Subject: Re: [PATCH v2 00/22] drm/cma-helper: Remove drm_fbdev_cma* functions
Date: Tue, 21 Nov 2017 16:47:55 +0000	[thread overview]
Message-ID: <1511282874.3409.14.camel@synopsys.com> (raw)
In-Reply-To: <bcae7694-bc76-150f-aeb3-286c34beaa75@tronnes.org>

Hi Noralf,

On Tue, 2017-11-21 at 00:52 +0100, Noralf Trønnes wrote:
> Den 17.11.2017 10.10, skrev Alexey Brodkin:
> > 
> > Hi Noralf,
> > 
> > On Thu, 2017-11-16 at 21:11 +0100, Noralf Trønnes wrote:
> > > 
> > > Den 16.11.2017 09.14, skrev Shawn Guo:
> > > > 
> > > > On Wed, Nov 15, 2017 at 03:19:39PM +0100, Noralf Trønnes wrote:
> > > > > 
> > > > > This patchset adds drm_fb_cma_fbdev_init/fini() functions that replaces
> > > > > drm_fbdev_cma_init/fini(). The reason for doing so is to get rid of
> > > > > struct drm_fbdev_cma and it's wrapper functions. The final piece will
> > > > > happen when tinydrm moves away from the cma helper and we can remove the
> > > > > struct.
> > > > > 
> > > > > Note:
> > > > > Patches 19-22 depends on patchset:
> > > > > [v3] drm: Add simple modeset suspend/resume helpers
> > > > Is there a git branch somewhere we can test?
> > > > 
> > > Here you go: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notro_linux_tree_drm-5Ffb-5Fcma-5Ffbdev-5Finit&d=DwIDaQ&c=DPL6_X_6J
> > > kXFx
> > > 7AXWqB0tg&r=OtZvQ4lNHIbjtyysXrNW8RbX6WFkigcev-xByzJ_fLk&m=McbBjcx46wmGkpM3GHmk9URB1xbd6ywS-
> > > Z5tpdWwDX8&s=BewulagwMNQa5xW19olMnlzV5DI5cZ_7eDSPyUpzMV8&e=
> > Thanks for that this really helps to test your patches.
> > And looks like something is broken for ARC PGU + ADV7511 with your tree:
> > -------------------------->8------------------------
> > adv7511: probe of 1-0039 failed with error -2
> 
> Maybe the problem is with the cec support added after 4.14:
> 
> drm: adv7511/33: add HDMI CEC support
> https://urldefense.proofpoint.com/v2/url?u=https-3A__cgit.freedesktop.org_drm_drm-2Dmisc_commit_drivers_gpu_drm_bridge_adv7511-3Fid-3D3b1b975003e4a3
> da4b93ab032487a3ae4afca7b5&d=DwIDaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=H7HSEHrOweYdtYmtV7QQ7l6ndVPGq1aUigPo3Wq
> DlNg&s=67zDRPjQ2iyMOhroP6wat67ESWhYnGPAhKgbmgHwxQ0&e=
> 
> Apparently there's a problem with it:
> 
> [PATCHv2] drm: adv7511/33: Fix adv7511_cec_init() failure handling
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_archives_dri-2Ddevel_2017-2DNovember_158024.html&d=DwIDaQ&c=DPL6_X_6JkXFx
> 7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=H7HSEHrOweYdtYmtV7QQ7l6ndVPGq1aUigPo3WqDlNg&s=ecprlgbDaK04JzdFl4w5JR7J-
> HoHaHCMwB0BfgRxufY&e=

Thanks a lot for the pointer!

Indeed this patch fixes a problem:
------------------------------------>8--------------------------------
arcpgu e0017000.pgu: arc_pgu ID: 0x41440304
arcpgu e0017000.pgu: assigned reserved memory node frame_buffer@9e000000
Console: switching to colour frame buffer device 160x45
arcpgu e0017000.pgu: fb0:  frame buffer device
[drm] Initialized arcpgu 1.0.0 20160219 for e0017000.pgu on minor 0
------------------------------------>8--------------------------------

So I'll reply with my ack for ARC PGU patch then as it works perfectly fine for me.

-Alexey
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel