From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751555AbdKVQD3 (ORCPT ); Wed, 22 Nov 2017 11:03:29 -0500 Received: from smtprelay0138.hostedemail.com ([216.40.44.138]:49048 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbdKVQD2 (ORCPT ); Wed, 22 Nov 2017 11:03:28 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3871:3873:4250:4321:5007:6691:7514:7903:10004:10400:10848:11026:11232:11473:11658:11914:12043:12296:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21434:21451:21627:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: meat58_583a701d44f14 X-Filterd-Recvd-Size: 2021 Message-ID: <1511366604.6989.93.camel@perches.com> Subject: Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues From: Joe Perches To: Patryk Kocielnik , sudipm.mukherjee@gmail.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 22 Nov 2017 08:03:24 -0800 In-Reply-To: <20171122154226.9493-1-patryk.kocielnik@gmail.com> References: <20171122154226.9493-1-patryk.kocielnik@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-22 at 16:42 +0100, Patryk Kocielnik wrote: > Cleaned checkpatch warnings by fixing coding style issues. checkpatch is not always correct. > Signed-off-by: Patryk Kocielnik > --- > drivers/staging/sm750fb/sm750.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c [] > @@ -32,7 +32,7 @@ > static int g_hwcursor = 1; > static int g_noaccel; > static int g_nomtrr; > -static const char *g_fbmode[] = {NULL, NULL}; > +static const char * const g_fbmode[] = {NULL, NULL}; Make sure you compile any file modified by a patch _before_ submitting the proposed patch. > static const char *g_def_fbmode = "1024x768-32@60"; > static char *g_settings; > static int g_dualview; > @@ -749,7 +749,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index) > lynx750_ext, NULL, vesa_modes, > }; > int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE}; > - static const char *mdb_desc[] = { > + static const char * const mdb_desc[] = { > "driver prepared modes", > "kernel prepared default modedb", > "kernel HELPERS prepared vesa_modes",