From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752084AbdKVRpv (ORCPT ); Wed, 22 Nov 2017 12:45:51 -0500 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:49453 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751292AbdKVRpu (ORCPT ); Wed, 22 Nov 2017 12:45:50 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:152:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2559:2562:3138:3139:3140:3141:3142:3352:3622:3653:3866:3867:3868:3870:3872:3873:4321:4605:5007:9040:10004:10400:10848:11026:11232:11658:11914:12043:12679:12740:12895:13069:13311:13357:13894:14181:14659:14721:21080:21434:21451:21627:30025:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sink66_6ce3c490ea938 X-Filterd-Recvd-Size: 2312 Message-ID: <1511372746.6989.102.camel@perches.com> Subject: Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues From: Joe Perches To: Patryk Kocielnik Cc: Sudip Mukherjee , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 22 Nov 2017 09:45:46 -0800 In-Reply-To: References: <20171122154226.9493-1-patryk.kocielnik@gmail.com> <1511366604.6989.93.camel@perches.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-22 at 18:33 +0100, Patryk Kocielnik wrote: > Joe, > > Thank you for your comments! > > I did compile it beforehand and it was clean. Did I miss anything? You also have to compile it afterhand... i.e.: with your patch applied $ make allyesconfig [] $ make drivers/staging/sm750fb/ [] CC drivers/staging/sm750fb/sm750.o drivers/staging/sm750fb/sm750.c: In function ‘lynxfb_set_fbinfo’: drivers/staging/sm750fb/sm750.c:807:19: error: assignment of read-only location ‘g_fbmode[index]’ g_fbmode[index] = g_def_fbmode; ^ drivers/staging/sm750fb/sm750.c:809:20: error: assignment of read-only location ‘g_fbmode[index]’ g_fbmode[index] = g_fbmode[0]; ^ drivers/staging/sm750fb/sm750.c: In function ‘sm750fb_setup’: drivers/staging/sm750fb/sm750.c:978:17: error: assignment of read-only location ‘g_fbmode[0]’ g_fbmode[0] = opt; ^ drivers/staging/sm750fb/sm750.c:982:17: error: assignment of read-only location ‘g_fbmode[1]’ g_fbmode[1] = opt; ^ scripts/Makefile.build:310: recipe for target 'drivers/staging/sm750fb/sm750.o' failed make[1]: *** [drivers/staging/sm750fb/sm750.o] Error 1 Makefile:1674: recipe for target 'drivers/staging/sm750fb/' failed make: *** [drivers/staging/sm750fb/] Error 2 >