diff for duplicates of <1511460616.16595.2.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 4062498..f914a8f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,8 +4,8 @@ On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading -> for both IPv4 and IPv6 packets.??So L3 checksum offload was -> getting enabled for IPv6 pkts.??And HW is dropping these pkts +> for both IPv4 and IPv6 packets. So L3 checksum offload was +> getting enabled for IPv6 pkts. And HW is dropping these pkts > as it assumes the pkt is IPv4 when IP csum offload is set > in the SQ descriptor. > @@ -14,15 +14,15 @@ On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > Signed-off-by: Sunil Goutham <sgoutham@cavium.com> > Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com> > --- -> ?drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 - -> ?1 file changed, 1 deletion(-) +> drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 - +> 1 file changed, 1 deletion(-) > > v2: > - Don't enable checksum offloading both for IPv4 and IPv6 (Eric > Dumazet) > > v1: -> ? https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov at au +> https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov@au > riga.com > > diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c @@ -32,13 +32,13 @@ On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > @@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, > struct snd_queue *sq, int qentry, -> ? -> ? /* Offload checksum calculation to HW */ -> ? if (skb->ip_summed == CHECKSUM_PARTIAL) { +> +> /* Offload checksum calculation to HW */ +> if (skb->ip_summed == CHECKSUM_PARTIAL) { > - hdr->csum_l3 = 1; /* Enable IP csum calculation */ -> ? hdr->l3_offset = skb_network_offset(skb); -> ? hdr->l4_offset = skb_transport_offset(skb); -> ? +> hdr->l3_offset = skb_network_offset(skb); +> hdr->l4_offset = skb_transport_offset(skb); +> Reviewed-by: Eric Dumazet <edumazet@google.com> diff --git a/a/content_digest b/N1/content_digest index a8d138c..b93d5c2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,17 @@ "ref\020171123144158.26111-1-aleksey.makarov@auriga.com\0" - "From\0eric.dumazet@gmail.com (Eric Dumazet)\0" - "Subject\0[PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts\0" + "From\0Eric Dumazet <eric.dumazet@gmail.com>\0" + "Subject\0Re: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts\0" "Date\0Thu, 23 Nov 2017 10:10:16 -0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Aleksey Makarov <aleksey.makarov@auriga.com>" + " netdev@vger.kernel.org\0" + "Cc\0linux-kernel@vger.kernel.org" + Goutham + Sunil <Sunil.Goutham@cavium.com> + Robert Richter <rric@kernel.org> + Florian Westphal <fw@strlen.de> + Aleksey Makarov <aleksey.makarov@cavium.com> + Sunil Goutham <sgoutham@cavium.com> + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote:\n" @@ -11,8 +20,8 @@ "> Don't offload IP header checksum to NIC.\n" "> \n" "> This fixes a previous patch which enabled checksum offloading\n" - "> for both IPv4 and IPv6 packets.??So L3 checksum offload was\n" - "> getting enabled for IPv6 pkts.??And HW is dropping these pkts\n" + "> for both IPv4 and IPv6 packets.\302\240\302\240So L3 checksum offload was\n" + "> getting enabled for IPv6 pkts.\302\240\302\240And HW is dropping these pkts\n" "> as it assumes the pkt is IPv4 when IP csum offload is set\n" "> in the SQ descriptor.\n" "> \n" @@ -21,15 +30,15 @@ "> Signed-off-by: Sunil Goutham <sgoutham@cavium.com>\n" "> Signed-off-by: Aleksey Makarov <aleksey.makarov@auriga.com>\n" "> ---\n" - "> ?drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -\n" - "> ?1 file changed, 1 deletion(-)\n" + "> \302\240drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 -\n" + "> \302\2401 file changed, 1 deletion(-)\n" "> \n" "> v2:\n" "> - Don't enable checksum offloading both for IPv4 and IPv6 (Eric\n" "> Dumazet)\n" "> \n" "> v1:\n" - "> ? https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov at au\n" + "> \302\240 https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov@au\n" "> riga.com\n" "> \n" "> diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c\n" @@ -39,16 +48,16 @@ "> +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c\n" "> @@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic,\n" "> struct snd_queue *sq, int qentry,\n" - "> ?\n" - "> ?\t/* Offload checksum calculation to HW */\n" - "> ?\tif (skb->ip_summed == CHECKSUM_PARTIAL) {\n" + "> \302\240\n" + "> \302\240\t/* Offload checksum calculation to HW */\n" + "> \302\240\tif (skb->ip_summed == CHECKSUM_PARTIAL) {\n" "> -\t\thdr->csum_l3 = 1; /* Enable IP csum calculation */\n" - "> ?\t\thdr->l3_offset = skb_network_offset(skb);\n" - "> ?\t\thdr->l4_offset = skb_transport_offset(skb);\n" - "> ?\n" + "> \302\240\t\thdr->l3_offset = skb_network_offset(skb);\n" + "> \302\240\t\thdr->l4_offset = skb_transport_offset(skb);\n" + "> \302\240\n" "\n" "Reviewed-by: Eric Dumazet <edumazet@google.com>\n" "\n" Thanks ! -4989a232822e01bfa02295d37fc2fae277c73318f269c33a824a2bba8bd7b1d6 +145ee3d9c0a33b5a8e7c67912b6394dee8bf600b251d5fadd25c03cbe2a3de3e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.