From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.dumazet@gmail.com (Eric Dumazet) Date: Thu, 23 Nov 2017 10:10:16 -0800 Subject: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts In-Reply-To: <20171123144158.26111-1-aleksey.makarov@auriga.com> References: <20171123144158.26111-1-aleksey.makarov@auriga.com> Message-ID: <1511460616.16595.2.camel@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > From: Sunil Goutham > > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading > for both IPv4 and IPv6 packets.??So L3 checksum offload was > getting enabled for IPv6 pkts.??And HW is dropping these pkts > as it assumes the pkt is IPv4 when IP csum offload is set > in the SQ descriptor. > > Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads > for ipv6") > Signed-off-by: Sunil Goutham > Signed-off-by: Aleksey Makarov > --- > ?drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 - > ?1 file changed, 1 deletion(-) > > v2: > - Don't enable checksum offloading both for IPv4 and IPv6 (Eric > Dumazet) > > v1: > ? https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov at au > riga.com > > diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > index d4496e9afcdf..8b2c31e2a2b0 100644 > --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > @@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, > struct snd_queue *sq, int qentry, > ? > ? /* Offload checksum calculation to HW */ > ? if (skb->ip_summed == CHECKSUM_PARTIAL) { > - hdr->csum_l3 = 1; /* Enable IP csum calculation */ > ? hdr->l3_offset = skb_network_offset(skb); > ? hdr->l4_offset = skb_transport_offset(skb); > ? Reviewed-by: Eric Dumazet Thanks ! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbdKWSKW (ORCPT ); Thu, 23 Nov 2017 13:10:22 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:37901 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753117AbdKWSKS (ORCPT ); Thu, 23 Nov 2017 13:10:18 -0500 X-Google-Smtp-Source: AGs4zMbLAYyF/tgywqhU2y92DGRk65d77yvLPmRuNgUh/NA4h3oA1V7rDr/hj9w19Uxx49s1bQ5v4A== Message-ID: <1511460616.16595.2.camel@gmail.com> Subject: Re: [PATCH net v2] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts From: Eric Dumazet To: Aleksey Makarov , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Goutham, Sunil" , Robert Richter , Florian Westphal , Aleksey Makarov , Sunil Goutham , linux-arm-kernel@lists.infradead.org Date: Thu, 23 Nov 2017 10:10:16 -0800 In-Reply-To: <20171123144158.26111-1-aleksey.makarov@auriga.com> References: <20171123144158.26111-1-aleksey.makarov@auriga.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-23 at 17:41 +0300, Aleksey Makarov wrote: > From: Sunil Goutham > > Don't offload IP header checksum to NIC. > > This fixes a previous patch which enabled checksum offloading > for both IPv4 and IPv6 packets.  So L3 checksum offload was > getting enabled for IPv6 pkts.  And HW is dropping these pkts > as it assumes the pkt is IPv4 when IP csum offload is set > in the SQ descriptor. > > Fixes: bbbb494fd005 ("net: thunderx: Enable TSO and checksum offloads > for ipv6") > Signed-off-by: Sunil Goutham > Signed-off-by: Aleksey Makarov > --- >  drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 1 - >  1 file changed, 1 deletion(-) > > v2: > - Don't enable checksum offloading both for IPv4 and IPv6 (Eric > Dumazet) > > v1: >   https://lkml.kernel.org/r/20171122123727.23580-1-aleksey.makarov@au > riga.com > > diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > index d4496e9afcdf..8b2c31e2a2b0 100644 > --- a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > +++ b/drivers/net/ethernet/cavium/thunder/nicvf_queues.c > @@ -1355,7 +1355,6 @@ nicvf_sq_add_hdr_subdesc(struct nicvf *nic, > struct snd_queue *sq, int qentry, >   >   /* Offload checksum calculation to HW */ >   if (skb->ip_summed == CHECKSUM_PARTIAL) { > - hdr->csum_l3 = 1; /* Enable IP csum calculation */ >   hdr->l3_offset = skb_network_offset(skb); >   hdr->l4_offset = skb_transport_offset(skb); >   Reviewed-by: Eric Dumazet Thanks !