From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <1511470178.5308.2.camel@perches.com>
Subject: Re: [PATCH] fat: Fix sb_rdonly() change
From: Joe Perches <joe@perches.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Date: Thu, 23 Nov 2017 12:49:38 -0800
In-Reply-To: <87ine15wzx.fsf@mail.parknet.co.jp>
References: <87mv3d5x51.fsf@mail.parknet.co.jp>
         <87ine15wzx.fsf@mail.parknet.co.jp>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2017-11-23 at 15:29 +0900, OGAWA Hirofumi wrote:
> Ouch forgot to add stable@
> 
> -- 
> commit bc98a42c1f7d0f886c0c1b75a92a004976a46d9f introduced bug.

I think your commit message needs a bit more information.

It'd be useful to describe that the introduction of
sb_rdonly converted the bitwise & to a boolean and so
this conversion and comparison was made defective.

Are there any other instances of defective comparisons?