From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:54463 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753910AbdKXReJ (ORCPT ); Fri, 24 Nov 2017 12:34:09 -0500 From: Trond Myklebust To: "linux-kernel@vger.kernel.org" , "jlayton@kernel.org" , "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "dvyukov@google.com" , "anna.schumaker@netapp.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" CC: "syzkaller@googlegroups.com" Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket Date: Fri, 24 Nov 2017 17:34:04 +0000 Message-ID: <1511544841.14300.4.camel@primarydata.com> References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDE3LTExLTIwIGF0IDE0OjAyICswMTAwLCBEbWl0cnkgVnl1a292IHdyb3RlOg0K PiBIZWxsbywNCj4gDQo+IFRoZSBmb2xsb3dpbmcgcHJvZ3JhbSB0cmlnZ2VycyBpbmZpbml0ZSBz dHJlYW0gb2YgdGhlIGZvbGxvd2luZw0KPiBvdXRwdXQNCj4gb24gY29uc29sZS4gVGhlIHByb2dy YW0gaXMgdW5raWxsYWJsZSBhbmQgdGhpcyBlZmZlY3RpdmVseSBicmluZ3MgdGhlDQo+IG1hY2hp bmUgZG93bjoNCj4gDQo+IA0KPiAqKiAxNiBwcmludGsgbWVzc2FnZXMgZHJvcHBlZCAqKiBbMTI4 NzUuMDIyOTE3XSB4c190Y3Bfc2V0dXBfc29ja2V0Og0KPiBjb25uZWN0IHJldHVybmVkIHVuaGFu ZGxlZCBlcnJvciAtMTEzDQo+DQoNCkRvZXMgdGhlIGZvbGxvd2luZyBmaXggdGhlIGlzc3VlPw0K DQo4PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t DQpGcm9tIGY0OGQzZjAxZGY0NWY1MGYwMTQ1MDYwZjUyNzJjY2YxYWVhODU1YWMgTW9uIFNlcCAx NyAwMDowMDowMCAyMDAxDQpGcm9tOiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBw cmltYXJ5ZGF0YS5jb20+DQpEYXRlOiBGcmksIDI0IE5vdiAyMDE3IDEyOjAwOjI0IC0wNTAwDQpT dWJqZWN0OiBbUEFUQ0hdIFNVTlJQQzogQWxsb3cgY29ubmVjdCB0byByZXR1cm4gRUhPU1RVTlJF QUNIDQoNClJlcG9ydGVkLWJ5OiBEbWl0cnkgVnl1a292IDxkdnl1a292QGdvb2dsZS5jb20+DQpT aWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0 YS5jb20+DQotLS0NCiBuZXQvc3VucnBjL3hwcnRzb2NrLmMgfCAxICsNCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBhL25ldC9zdW5ycGMveHBydHNvY2suYyBi L25ldC9zdW5ycGMveHBydHNvY2suYw0KaW5kZXggNGRhZDVkYTM4OGQ2Li44Y2I0MGY4ZmZhNWIg MTAwNjQ0DQotLS0gYS9uZXQvc3VucnBjL3hwcnRzb2NrLmMNCisrKyBiL25ldC9zdW5ycGMveHBy dHNvY2suYw0KQEAgLTI0MzcsNiArMjQzNyw3IEBAIHN0YXRpYyB2b2lkIHhzX3RjcF9zZXR1cF9z b2NrZXQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KIAljYXNlIC1FQ09OTlJFRlVTRUQ6DQog CWNhc2UgLUVDT05OUkVTRVQ6DQogCWNhc2UgLUVORVRVTlJFQUNIOg0KKwljYXNlIC1FSE9TVFVO UkVBQ0g6DQogCWNhc2UgLUVBRERSSU5VU0U6DQogCWNhc2UgLUVOT0JVRlM6DQogCQkvKg0KLS0g DQoyLjE0LjMNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754094AbdKXReM (ORCPT ); Fri, 24 Nov 2017 12:34:12 -0500 Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:38313 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753915AbdKXReJ (ORCPT ); Fri, 24 Nov 2017 12:34:09 -0500 From: Trond Myklebust To: "linux-kernel@vger.kernel.org" , "jlayton@kernel.org" , "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "dvyukov@google.com" , "anna.schumaker@netapp.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" CC: "syzkaller@googlegroups.com" Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket Thread-Topic: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket Thread-Index: AQHTYf/iDz46esRcbEiW2axMmfPOE6Mj0NSA Date: Fri, 24 Nov 2017 17:34:04 +0000 Message-ID: <1511544841.14300.4.camel@primarydata.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0073;20:Wm3YDotl/7tZOIjlG6rW2IPUJ7ccSNMO/hjbrutRZcOZ7BuH2IZ3mZAiby+K1Ps83HIGLTBPA18WfhWlUUkZRJgob5TBH0X3olcskbTRlIpYwm7d8GKA02UTcm6zHiMLfYFzlPD4mhDYKVIyZYT4P1qMAzrCA6O+bWk+mh2z5Xg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(2017052603258);SRVR:DM5PR11MB0073; x-ms-traffictypediagnostic: DM5PR11MB0073: x-ms-office365-filtering-correlation-id: 1172defb-c047-4094-14ad-08d533618ee2 x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(211936372134217)(153496737603132)(21532816269658); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(920507027)(3002001)(10201501046)(93006095)(93001095)(6041248)(2016111802025)(201703131423075)(201703061421075)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(20161123562025)(6072148)(6043046)(201708071742011);SRVR:DM5PR11MB0073;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR11MB0073; x-forefront-prvs: 05015EB482 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(366004)(376002)(24454002)(377424004)(189002)(199003)(6506006)(6486002)(53936002)(2906002)(3280700002)(6512007)(6246003)(6436002)(229853002)(508600001)(2900100001)(86362001)(50986999)(76176999)(54356999)(2501003)(14454004)(4001150100001)(2201001)(97736004)(4326008)(8936002)(3660700001)(110136005)(77096006)(33646002)(36756003)(99286004)(25786009)(53546010)(81166006)(66066001)(81156014)(102836003)(8676002)(3846002)(101416001)(6116002)(2950100002)(5660300001)(68736007)(189998001)(34040400001)(106356001)(103116003)(305945005)(105586002)(7736002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB0073;H:DM5PR11MB0075.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <531612B7F8A7C847B5126778420DAB37@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1172defb-c047-4094-14ad-08d533618ee2 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2017 17:34:04.2318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0073 X-MC-Unique: nhCY54ndOF6SoUVYkJLdmg-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vAOHYHfY029045 On Mon, 2017-11-20 at 14:02 +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers infinite stream of the following > output > on console. The program is unkillable and this effectively brings the > machine down: > > > ** 16 printk messages dropped ** [12875.022917] xs_tcp_setup_socket: > connect returned unhandled error -113 > Does the following fix the issue? 8<----------------------------------------------------- >>From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Fri, 24 Nov 2017 12:00:24 -0500 Subject: [PATCH] SUNRPC: Allow connect to return EHOSTUNREACH Reported-by: Dmitry Vyukov Signed-off-by: Trond Myklebust --- net/sunrpc/xprtsock.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 4dad5da388d6..8cb40f8ffa5b 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -2437,6 +2437,7 @@ static void xs_tcp_setup_socket(struct work_struct *work) case -ECONNREFUSED: case -ECONNRESET: case -ENETUNREACH: + case -EHOSTUNREACH: case -EADDRINUSE: case -ENOBUFS: /* -- 2.14.3 -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket Date: Fri, 24 Nov 2017 17:34:04 +0000 Message-ID: <1511544841.14300.4.camel@primarydata.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Cc: "syzkaller@googlegroups.com" To: "linux-kernel@vger.kernel.org" , "jlayton@kernel.org" , "bfields@fieldses.org" , "linux-nfs@vger.kernel.org" , "dvyukov@google.com" , "anna.schumaker@netapp.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" Return-path: In-Reply-To: Content-Language: en-US Content-ID: <531612B7F8A7C847B5126778420DAB37@namprd11.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org T24gTW9uLCAyMDE3LTExLTIwIGF0IDE0OjAyICswMTAwLCBEbWl0cnkgVnl1a292IHdyb3RlOg0K PiBIZWxsbywNCj4gDQo+IFRoZSBmb2xsb3dpbmcgcHJvZ3JhbSB0cmlnZ2VycyBpbmZpbml0ZSBz dHJlYW0gb2YgdGhlIGZvbGxvd2luZw0KPiBvdXRwdXQNCj4gb24gY29uc29sZS4gVGhlIHByb2dy YW0gaXMgdW5raWxsYWJsZSBhbmQgdGhpcyBlZmZlY3RpdmVseSBicmluZ3MgdGhlDQo+IG1hY2hp bmUgZG93bjoNCj4gDQo+IA0KPiAqKiAxNiBwcmludGsgbWVzc2FnZXMgZHJvcHBlZCAqKiBbMTI4 NzUuMDIyOTE3XSB4c190Y3Bfc2V0dXBfc29ja2V0Og0KPiBjb25uZWN0IHJldHVybmVkIHVuaGFu ZGxlZCBlcnJvciAtMTEzDQo+DQoNCkRvZXMgdGhlIGZvbGxvd2luZyBmaXggdGhlIGlzc3VlPw0K DQo4PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t DQpGcm9tIGY0OGQzZjAxZGY0NWY1MGYwMTQ1MDYwZjUyNzJjY2YxYWVhODU1YWMgTW9uIFNlcCAx NyAwMDowMDowMCAyMDAxDQpGcm9tOiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBw cmltYXJ5ZGF0YS5jb20+DQpEYXRlOiBGcmksIDI0IE5vdiAyMDE3IDEyOjAwOjI0IC0wNTAwDQpT dWJqZWN0OiBbUEFUQ0hdIFNVTlJQQzogQWxsb3cgY29ubmVjdCB0byByZXR1cm4gRUhPU1RVTlJF QUNIDQoNClJlcG9ydGVkLWJ5OiBEbWl0cnkgVnl1a292IDxkdnl1a292QGdvb2dsZS5jb20+DQpT aWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPHRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0 YS5jb20+DQotLS0NCiBuZXQvc3VucnBjL3hwcnRzb2NrLmMgfCAxICsNCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKykNCg0KZGlmZiAtLWdpdCBhL25ldC9zdW5ycGMveHBydHNvY2suYyBi L25ldC9zdW5ycGMveHBydHNvY2suYw0KaW5kZXggNGRhZDVkYTM4OGQ2Li44Y2I0MGY4ZmZhNWIg MTAwNjQ0DQotLS0gYS9uZXQvc3VucnBjL3hwcnRzb2NrLmMNCisrKyBiL25ldC9zdW5ycGMveHBy dHNvY2suYw0KQEAgLTI0MzcsNiArMjQzNyw3IEBAIHN0YXRpYyB2b2lkIHhzX3RjcF9zZXR1cF9z b2NrZXQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KIAljYXNlIC1FQ09OTlJFRlVTRUQ6DQog CWNhc2UgLUVDT05OUkVTRVQ6DQogCWNhc2UgLUVORVRVTlJFQUNIOg0KKwljYXNlIC1FSE9TVFVO UkVBQ0g6DQogCWNhc2UgLUVBRERSSU5VU0U6DQogCWNhc2UgLUVOT0JVRlM6DQogCQkvKg0KLS0g DQoyLjE0LjMNCg0KLS0gDQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRh aW5lciwgUHJpbWFyeURhdGENCnRyb25kLm15a2xlYnVzdEBwcmltYXJ5ZGF0YS5jb20NCg==