Re: [PATCH] drm/i915: Record default HW state in the GPU error state

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Record default HW state in the GPU error state
Date: Mon, 27 Nov 2017 14:02:03 +0200	[thread overview]
Message-ID: <1511784123.4627.28.camel@linux.intel.com> (raw)
In-Reply-To: <20171126220901.14735-1-chris@chris-wilson.co.uk>

On Sun, 2017-11-26 at 22:09 +0000, Chris Wilson wrote:
> It may be of interest to both compare the active HW context against the
> default (or NULL) context, to see what has been changed and if either are
> corrupt.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>

<SNIP>

> @@ -1414,6 +1417,23 @@ static void request_record_user_bo(struct drm_i915_gem_request *request,
>  	ee->user_bo_count = count;
>  }
>  
> +static struct drm_i915_error_object *
> +capture_object(struct drm_i915_private *dev_priv,
> +	       struct drm_i915_gem_object *obj)
> +{
> +	if (obj && i915_gem_object_has_pages(obj)) {
> +		struct i915_vma vma = {

fake_vma to put emphasis this is a trick?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx