From: Leonard Crestez <leonard.crestez@nxp.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pm@vger.kernel.org, kernel@pengutronix.de,
Shawn Guo <shawnguo@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Dong Aisheng <aisheng.dong@nxp.com>, Bai Ping <ping.bai@nxp.com>
Subject: Re: [PATCH 3/4] thermal: imx: use consistent style to write temperatures
Date: Mon, 27 Nov 2017 20:40:47 +0200 [thread overview]
Message-ID: <1511808047.20123.32.camel@nxp.com> (raw)
In-Reply-To: <20171121200225.23316-4-u.kleine-koenig@pengutronix.de>
On Tue, 2017-11-21 at 21:02 +0100, Uwe Kleine-König wrote:
>
> The previous commit already took care to use the right notation for
> temperatures. Add correct units to all values representing temperatures in
> the right notation for the rest of the file.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
I'm not sure adding unicode to source code adds much but OK.
> /*
> - * Set the critical trip point at 5C under max
> - * Set the passive trip point at 10C under max (can change via sysfs)
> + * Set the critical trip point at 5 °C under max
> + * Set the passive trip point at 10 °C under max (changable via sysfs)
It's spelled "changEable".
next prev parent reply other threads:[~2017-11-27 18:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 20:02 [PATCH 0/4] thermal: imx: cleanup and new formula Uwe Kleine-König
2017-11-21 20:02 ` [PATCH 1/4] thermal: imx: Use better parameter names than "val" Uwe Kleine-König
2017-11-27 18:39 ` Leonard Crestez
2017-11-27 19:50 ` Uwe Kleine-König
2017-11-28 13:20 ` Leonard Crestez
2017-11-21 20:02 ` [PATCH 2/4] thermal: imx: improve comments describing algorithm for temp calculation Uwe Kleine-König
2017-11-27 18:39 ` Leonard Crestez
2017-11-27 19:52 ` Uwe Kleine-König
2017-11-21 20:02 ` [PATCH 3/4] thermal: imx: use consistent style to write temperatures Uwe Kleine-König
2017-11-27 18:40 ` Leonard Crestez [this message]
2017-11-27 19:45 ` Uwe Kleine-König
2017-11-21 20:02 ` [PATCH 4/4] thermal: imx: update to new formula according to NXP AN5215 Uwe Kleine-König
2017-11-27 18:41 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511808047.20123.32.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=edubezval@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.