From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v10 1/2] drm/i915/guc : Removing enable_guc_loading and enable_guc_submission module parameters Date: Tue, 28 Nov 2017 12:27:36 +0200 Message-ID: <1511864856.4761.46.camel@linux.intel.com> References: <1511812473-16897-1-git-send-email-sujaritha.sundaresan@intel.com> <1511812473-16897-2-git-send-email-sujaritha.sundaresan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDD596E5B6 for ; Tue, 28 Nov 2017 10:27:39 +0000 (UTC) In-Reply-To: <1511812473-16897-2-git-send-email-sujaritha.sundaresan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sujaritha Sundaresan , intel-gfx@lists.freedesktop.org, Chris Wilson List-Id: intel-gfx@lists.freedesktop.org KyBMaSAoZm9yIFdPUENNKQoKT24gTW9uLCAyMDE3LTExLTI3IGF0IDExOjU0IC0wODAwLCBTdWph cml0aGEgU3VuZGFyZXNhbiB3cm90ZToKPiBXZSBjdXJyZW50bHkgaGF2ZSB0d28gbW9kdWxlIHBh cmFtZXRlcnMgdGhhdCBjb250cm9sIEd1QzoKPiAiZW5hYmxlX2d1Y19sb2FkaW5nIiBhbmQgImVu YWJsZV9ndWNfc3VibWlzc2lvbiIuIFdoZW5ldmVyCj4gd2UgbmVlZCBzdWJtaXNzaW9uPTEsIHdl IGFsc28gbmVlZCBsb2FkaW5nPTEuV2UgYWxzbyBuZWVkCj4gbG9hZGluZz0xIHdoZW4gd2Ugd2Fu dCB0byB3YW50IHRvIHZlcmlmeSB0aGUgSHVDLCB3aGljaAo+IGlzIGV2ZXJ5IHRpbWUgd2UgaGF2 ZSBhIEh1QyAoYnV0IGFsbCBwbGF0Zm9ybXMgd2l0aCBIdUMKPiBoYXZlIGEgR3VDIGFuZCB2aWNl dmVyc2EpLgo+IAo+IFRoZSBhYm92ZSBtb2R1bGUgcGFyYW1ldGVycyBhcmUgYmVpbmcgcmVwbGFj ZWQgYnkgYSBzaW5nbGUKPiBlbmFibGVfZ3VjIG1vZHBhcmFtLgo+IAo+IHYyOiBDbGFyaWZ5aW5n IHRoZSBjb21taXQgbWVzc2FnZSAoQW51c2hhKQo+IAo+IHYzOiBVbmlmeSBzZXFfcHV0cyBtZXNz YWdlcywgUmUtZmFjdG9yaW5nIGNvZGUgYXMgcGVyIHJldmlldyAoTWljaGFsKQo+IAo+IHY0OiBS ZWJhc2UKPiAKPiB2NTogU2VwYXJhdGluZyBtZXNzYWdlIHVuaWZpY2F0aW9uIGludG8gYSBzZXBh cmF0ZSBwYXRjaAo+IAo+IHY2OiBSZS1mYWN0b3JpbmcgY29kZSAoU2FnYXIsIE1pY2hhbCkKPiAg ICAgUmViYXNlCj4gCj4gdjc6IEFwcGx5aW5nIHJldmlldyBjb21tZW50cyAoU2FnYXIpCj4gICAg IFJlYmFzZQo+IAo+IHY4OiBDaGFuZ2UgdG8gTkVFRFNfR1VDX0ZXIChDaHJpcykKPiAgICAgQXBw bHlpbmcgcmV2aWV3IGNvbW1lbnRzIChNaWNoYWwpCj4gICAgIENsYXJpZnlpbmcgY29tbWl0IG1l c3NhZ2UgKEpvb25hcykKPiAKPiB2OTogQXBwbHlpbmcgcmV2aWV3IGNvbW1lbnRzIChNaWNoYWwp Cj4gCj4gdjEwOiBJbnRyb2R1Y2luZyBlbmFibGVfZ3VjIG1vZHBhcmFtCj4gCSBBcHBseWluZyBy ZXZpZXcgY29tbWVudHMgKE1pY2hhbCkKPiAKPiBTaWduZWQtb2ZmLWJ5OiBTdWphcml0aGEgU3Vu ZGFyZXNhbiA8c3VqYXJpdGhhLnN1bmRhcmVzYW5AaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENl cmFvbG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBKb29u YXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1pY2hh bCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBPc2NhciBNYXRl byA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+IENjOiBTYWdhciBBcnVuIEthbWJsZSA8c2FnYXIu YS5rYW1ibGVAaW50ZWwuY29tPgoKPFNOSVA+Cgo+IEBAIC0yNDY2LDcgKzI0NjYsNyBAQCBzdGF0 aWMgYm9vbCBjaGVja19ndWNfc3VibWlzc2lvbihzdHJ1Y3Qgc2VxX2ZpbGUgKm0pCj4gIAkJc2Vx X3ByaW50ZihtLCAiR3VDIHN1Ym1pc3Npb24gJXNcbiIsCj4gIAkJCQlIQVNfR1VDKGRldl9wcml2 KSA/Cj4gIAkJCQkibm90IHN1cHBvcnRlZCIgOgo+IC0JCQkJSEFTX0dVQ19TQ0hFRChkZXZfcHJp dikgPwo+ICsJCQkJTkVFRFNfR1VDX0xPQUQoZGV2X3ByaXYpID8KPiAgCQkJCSJkaXNhYmxlZCIg Ogo+ICAJCQkJImZhaWxlZCIpOwoKSSBkbyBub3QgcXVpdGUgZm9sbG93IHRoZSBsb2dpYywgaGVy ZS4gRXZlbiB0aGUgb2xkIGxvZ2ljIGlzIHJldmVyc2VkPwoKVGhpcyBwYXRjaCBkb2Vzbid0IHNl ZW0gdG8gYmUgb24gdG9wIG9mIGRybS10aXAsIHNvIHdoYXRldmVyIHBhdGNoIHRoaXMKd2FzIHdy aXR0ZW4gb24gdG9wIG9mLCBuZWVkcyBmaXhpbmcgdG9vLgoKV2hlbiBzZW5kaW5nIHBhdGNoZXMs IG1ha2Ugc3VyZSB0aGV5IGFjdHVhbGx5IGJ1aWxkIG9uIHRvcCBvZiBkcm0tdGlwCm5vdCB0byB3 YXN0ZSB0aGUgcmV2aWV3ZXJzJyB0aW1lLgoKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gQEAgLTMyMjAsMTAgKzMyMjAsMTYgQEAgc3RhdGljIGlubGluZSB1bnNpZ25l ZCBpbnQgaTkxNV9zZ19zZWdtZW50X3NpemUodm9pZCkKPiAgICogcHJvcGVydGllcywgc28gd2Ug aGF2ZSBzZXBhcmF0ZSBtYWNyb3MgdG8gdGVzdCB0aGVtLgo+ICAgKi8KPiAgI2RlZmluZSBIQVNf R1VDKGRldl9wcml2KQkoKGRldl9wcml2KS0+aW5mby5oYXNfZ3VjKQo+ICsjZGVmaW5lIEhBU19I VUMoZGV2X3ByaXYpCShIQVNfR1VDKGRldl9wcml2KSkKPiAgI2RlZmluZSBIQVNfR1VDX0NUKGRl dl9wcml2KQkoKGRldl9wcml2KS0+aW5mby5oYXNfZ3VjX2N0KQo+IC0jZGVmaW5lIEhBU19HVUNf VUNPREUoZGV2X3ByaXYpCShIQVNfR1VDKGRldl9wcml2KSkKPiAtI2RlZmluZSBIQVNfR1VDX1ND SEVEKGRldl9wcml2KQkoSEFTX0dVQyhkZXZfcHJpdikpCj4gLSNkZWZpbmUgSEFTX0hVQ19VQ09E RShkZXZfcHJpdikJKEhBU19HVUMoZGV2X3ByaXYpKQo+ICsjZGVmaW5lIEhBU19HVUNfRlcoZGV2 X3ByaXYpIFwKPiArCSgoZGV2X3ByaXYpLT5ndWMuZncuZmV0Y2hfc3RhdHVzID09IElOVEVMX1VD X0ZJUk1XQVJFX1NVQ0NFU1MpCj4gKyNkZWZpbmUgSEFTX0hVQ19GVyhkZXZfcHJpdikgXAo+ICsJ KChkZXZfcHJpdiktPmh1Yy5mdy5mZXRjaF9zdGF0dXMgPT0gSU5URUxfVUNfRklSTVdBUkVfU1VD Q0VTUykKClRoaXMgaXMgbm90IGEgZ29vZCBjYW5kaWRhdGUgZm9yIEhBU18qIGZ1bmN0aW9uIGFz IGl0J3MgYSByYXRoZXIKZHluYW1pYyBzdGF0ZS4gSW1hZ2luZSB0aGUgSEFTXyovSVNfKiBmdW5j dGlvbnMgYXMgc29tZXRoaW5nIHlvdSBtYXkKd2FudCB0byBmcmVlemUgYXQgY29tcGlsZSBzdGF0 ZS4KCj4gKwo+ICsjZGVmaW5lIE5FRURTX0dVQ19MT0FEKGRldl9wcml2KSBcCj4gKwkoSEFTX0dV QyhkZXZfcHJpdikgJiYgSEFTX0dVQ19GVyhkZXZfcHJpdikgJiYgXAo+ICsJKEhBU19IVUNfRlco ZGV2X3ByaXYpIHx8IGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWMpKQoKVGhpcyBldmVuIGxlc3Mg c28uCgo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYwo+IEBA IC0zMTYsNyArMzE2LDcgQEAgc3RhdGljIHUzMiBkZWZhdWx0X2Rlc2NfdGVtcGxhdGUoY29uc3Qg c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCj4gIAkgKiBwcmVzZW50IG9yIG5vdCBpbiB1 c2Ugd2Ugc3RpbGwgbmVlZCBhIHNtYWxsIGJpYXMgYXMgcmluZyB3cmFwYXJvdW5kCj4gIAkgKiBh dCBvZmZzZXQgMCBzb21ldGltZXMgaGFuZ3MuIE5vIGlkZWEgd2h5Lgo+ICAJICovCj4gLQlpZiAo SEFTX0dVQyhkZXZfcHJpdikgJiYgaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1Y19sb2FkaW5nKQo+ ICsJaWYgKE5FRURTX0dVQ19MT0FEKGRldl9wcml2KSkKPiAgCQljdHgtPmdndHRfb2Zmc2V0X2Jp YXMgPSBHVUNfV09QQ01fVE9QOwoKV2Ugc2hvdWxkIHJlYWxseSBtYWtlIHVwIG91ciBtaW5kIHdo ZW4gd2UgYWN0dWFsbHkgbmVlZCB0byBhdm9pZCB0aGUKV09QQ00uIEFjY29yZGluZyB0byBMaSwg aXQncyBub3QgYm91bmQgdG8gdGhlIHVzYWdlIG9mIHRoZQptaWNyb2NvbnRyb2xsZXJzIGJ1dCBy YXRoZXIgdGhlaXIgZXhpc3RlbmNlLgoKU28gdGhlIGNvcnJlY3QgY29uZGl0aW9uIHdvdWxkIGJl IGp1c3QgSEFTX0dVQygpPwoKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9n dHQuYwo+IEBAIC0zNTAzLDcgKzM1MDMsNyBAQCBpbnQgaTkxNV9nZ3R0X3Byb2JlX2h3KHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCSAqIGN1cnJlbnRseSBkb24ndCBoYXZl IGFueSBiaXRzIHNwYXJlIHRvIHBhc3MgaW4gdGhpcyB1cHBlcgo+ICAJICogcmVzdHJpY3Rpb24h Cj4gIAkgKi8KPiAtCWlmIChIQVNfR1VDKGRldl9wcml2KSAmJiBpOTE1X21vZHBhcmFtcy5lbmFi bGVfZ3VjX2xvYWRpbmcpIHsKPiArCWlmIChORUVEU19HVUNfTE9BRChkZXZfcHJpdikpIHsKPiAg CQlnZ3R0LT5iYXNlLnRvdGFsID0gbWluX3QodTY0LCBnZ3R0LT5iYXNlLnRvdGFsLCBHVUNfR0dU VF9UT1ApOwo+ICAJCWdndHQtPm1hcHBhYmxlX2VuZCA9IG1pbihnZ3R0LT5tYXBwYWJsZV9lbmQs IGdndHQtPmJhc2UudG90YWwpOwo+ICAJfQoKSSBndWVzcyBzYW1lIHF1ZXN0aW9uIGFwcGxpZXMg aGVyZS4gQWxzbywgZXZlbiB0aGlzIGZ1bmN0aW9uIHdhcwpjb3JyZWN0bHkgbmFtZWQgc29tZXRo aW5nIGxpa2UgaW50ZWxfZ3VjX25lZWRzX2xvYWRpbmcoKSwgaXQnZCBoYXZlIHRvCmJlIG11Y2gg bGVzcyBkeW5hbWljIGJlY2F1c2Ugd2UncmUgcmVhbGx5IG5vdCBnb2luZyB0byBydW4gdGhpcyBj b2RlCm11bHRpcGxlIHRpbWVzLgoKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91 Yy5jCj4gQEAgLTQ3LDM4ICs0Nyw0NSBAQCBzdGF0aWMgaW50IF9faW50ZWxfdWNfcmVzZXRfaHco c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ ICAKPiArLyoKPiArICogV2l0aCBlbmFibGVfZ3VjIGRlZmluZWQgYXMgZm9sbG93czoKPiArICoK PiArICogLTE9YXV0byBbZGVmYXVsdF0KPiArICogIDA9ZGlzYWJsZSBHdUMgbG9hZGluZwo+ICsg KiAgMT1lbmFibGUgR3VDIHN1Ym1pc3Npb24KPiArICogIDI9ZW5hYmxlIEh1Qwo+ICsgKiAgMz1l bmFibGUgR3VDIHN1Ym1pc3Npb24gYW5kIEh1Qwo+ICsgKi8KPiArCj4gIHZvaWQgaW50ZWxfdWNf c2FuaXRpemVfb3B0aW9ucyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsK PiAtCWlmICghSEFTX0dVQyhkZXZfcHJpdikpIHsKPiAtCQlpZiAoaTkxNV9tb2RwYXJhbXMuZW5h YmxlX2d1Y19sb2FkaW5nID4gMCB8fAo+IC0JCSAgICBpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3Vj X3N1Ym1pc3Npb24gPiAwKQo+IC0JCQlEUk1fSU5GTygiSWdub3JpbmcgR3VDIG9wdGlvbnMsIG5v IGhhcmR3YXJlXG4iKTsKPiAtCj4gLQkJaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1Y19sb2FkaW5n ID0gMDsKPiAtCQlpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX3N1Ym1pc3Npb24gPSAwOwo+IC0J CXJldHVybjsKPiArCWludCBhdXRvX2VuYWJsZV9ndWMgPSAwOwo+ICsJLy8gbm90ZSB0aGF0IGlu IHRoZSBmdXR1cmUgdGhpcyBjYW4gYmUgZGVmaW5lZCBpbiBtb3JlIGdyYW51bGFyIHdheQo+ICsJ Ly8gaW50IGF1dG9fZW5hYmxlX2d1YyA9ICFIQVNfR1VDX0ZXKGRldl9wcml2KSA/IDAgOgo+ICsJ Ly8JCQkJCUlTX0dFTjkoZGV2X3ByaXYpID8gMSA6Cj4gKwkvLyAgICAgICAgICAgICAgICAgIElT X0dFTjEwKGRldl9wcml2KSA/IDI6Cj4gKwkvLyAgICAgICAgICAgICAgICAgIDM7CgpQbGVhc2Us IG5vIEMrKyBzdHlsZSBjb21tZW50cyAoeW91IGRvbid0IHNlZSB0aGVtIGFyb3VuZCwgZG8geW91 KSwgYW5kCnRoZSBwc2V1ZG9jb2RlIHNlZW1zIG92ZXJseSBkZXRhaWxlZCBmb3IgcHNldWRvY29k ZS4KCj4gKwo+ICsJLyogTWFraW5nIHN1cmUgdGhhdCBvdXIgYXV0byBpcyB3ZWxsIGRlZmluZWQg Ki8KPiArCUdFTV9CVUdfT04oYXV0b19lbmFibGVfZ3VjIDwgMCk7Cj4gKwlHRU1fQlVHX09OKChh dXRvX2VuYWJsZV9ndWMgPiAwKSAmJiAhSEFTX0dVQ19GVyhkZXZfcHJpdikpOwo+ICsJR0VNX0JV R19PTigoYXV0b19lbmFibGVfZ3VjICYgMikgJiYgIUhBU19IVUNfRlcoZGV2X3ByaXYpKTsKPiAr Cj4gKwlpZiAoaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1YyA8IDApCj4gKwkJaTkxNV9tb2RwYXJh bXMuZW5hYmxlX2d1YyA9IGF1dG9fZW5hYmxlX2d1YzsKPiArCj4gKwlpZiAoaTkxNV9tb2RwYXJh bXMuZW5hYmxlX2d1YyA+IDApIHsKPiArCQlpZiAoIUhBU19HVUMoZGV2X3ByaXYpIHx8ICFIQVNf R1VDX0ZXKGRldl9wcml2KSkgewo+ICsJCQlEUk1fSU5GTygiSWdub3Jpbmcgb3B0aW9uIGVuYWJs ZV9ndWM9JWQgLSAlc1xuIiwKPiArCQkJCQkgaTkxNV9tb2RwYXJhbXMuZW5hYmxlX2d1YywKPiAr CQkJCSAgICAgIUhBU19HVUMoZGV2X3ByaXYpID8gIm5vIEd1QyBoYXJkd2FyZSIgOgo+ICsJCQkJ CSAibm8gR3VDIGZpcm13YXJlIik7Cj4gKwkJCWk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWMgPSAw Owo+ICsJCX0KClRoZSBpbmRlbnRzIGFyZSB3YXkgb2ZmLiBBcyB0aGlzIHBhdGNoIGlzIGFscmVh ZHkgYXQgcmV2aXNpb24gMTAsIEknbQpzdG9wcGluZyBoZXJlLgoKSSB3b3VsZCBzdWdnZXN0IHN0 YXJ0aW5nIHdpdGggc29tZSBzbWFsbGVyIGFuZCBsZXNzICJjb250cm92ZXJzaWFsIgpwYXRjaGVz IHRvIGdldCB0byBrbm93IHRoZSBjb2RlYmFzZSwgY29kaW5nIHN0eWxlIGFuZCBvdGhlciBjb25j ZXB0cy4KSXQgd2lsbCBtYWtlIHlvdXIgbGlmZSBtdWNoIG1vcmUgcGxlYXNhbnQgd29ya2luZyBv biBwYXRjaGVzIHRoYXQgbWFrZQphY3R1YWwgZm9yd2FyZCBwcm9ncmVzcy4KCkl0IGlzIG5vdCBh IGdvb2QgbGVhcm5pbmcgZXhwZXJpZW5jZSwgYW5kIG11c3QgYmUgZnJ1c3RyYXRpbmcgdG8gdHJ5 IHRvCmNvbXBvc2UgYSBwYXRjaCBlbnRpcmVseSBiYXNlZCBvbiB0aGUgcmV2aWV3IHJlc3BvbnNl cyB3aXRob3V0IGhhdmluZwp0aGUgdGltZSB0byBnZXQgdG8ga25vdyB0aGUgY29kZS4KClNvIEkg c3VnZ2VzdCBNaWNoYWwgb3IgU2FnYXIgd2lsbCB0YWtlIG92ZXIgdGhpcyBwYXRjaCwgZ2l2aW5n IGl0IGFuCm92ZXJoYXVsLiBUaGF0J3MgdGhlIGJlc3QgYWN0aW9uIEkgY2FuIHNlZSBmb3Igbm93 IGFzIHRoaXMgaXMgc3RhbmRpbmcKYmV0d2VlbiBkcm0tdGlwIGFuZCB0aGUgcmVzdCBvZiB0aGUg R3VDIHBhdGNoZXMuCgpSZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK