From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: "Rantala, Valtteri" <valtteri.rantala@intel.com>,
Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Cc: "Tamminen, Eero T" <eero.t.tamminen@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Auld, Matthew" <matthew.auld@intel.com>
Subject: Re: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
Date: Wed, 29 Nov 2017 10:00:27 +0200 [thread overview]
Message-ID: <1511942427.4747.1.camel@linux.intel.com> (raw)
In-Reply-To: <1A9631B909C2B54FA6BF24E8611EC0D15FF93A32@IRSMSX101.ger.corp.intel.com>
On Mon, 2017-11-27 at 13:36 +0000, Rantala, Valtteri wrote:
> > -----Original Message-----
> > From: Joonas Lahtinen [mailto:joonas.lahtinen@linux.intel.com]
> > Sent: Monday, November 27, 2017 11:13 AM
> > To: Intel graphics driver community testing & development <intel-
> > gfx@lists.freedesktop.org>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>; Auld, Matthew
> > <matthew.auld@intel.com>; Chris Wilson <chris@chris-wilson.co.uk>; Jani
> > Nikula <jani.nikula@linux.intel.com>; Vivi, Rodrigo <rodrigo.vivi@intel.com>;
> > Rantala, Valtteri <valtteri.rantala@intel.com>; Tamminen, Eero T
> > <eero.t.tamminen@intel.com>
> > Subject: [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A
> >
> > We seem to be missing some W/A for 2M pages and are getting a hit on raw
> > GPU read bandwidths (even 30%) even though the GPU write bandwidths
> > improve (even 10%).
> >
> > For now, disable THP, which is our only practical source of 2M pages until we
> > have a W/A for the issue.
> >
> > v2:
> > - Be explicit that we talk about GPU bandwidths (Eero)
> > - s/deny/never/ because that's why (Chris)
> >
> > Reported-by: Valtteri Rantala <valtteri.rantala@intel.com>
> > Fixes: b901bb89324a ("drm/i915/gemfs: enable THP")
> > Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Matthew Auld <matthew.auld@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Valtteri Rantala <valtteri.rantala@intel.com>
> > Cc: Eero Tamminen <eero.t.tamminen@intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Reviewed-by: Matthew Auld <matthew.auld@intel.com>
>
> Tested-by: Valtteri Rantala <valtteri.rantala@intel.com>
I'm merging the patch, thanks for the report, reviews and testing!
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-11-29 8:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 9:12 [PATCH] drm/i915: Disable THP until we have a GPU read BW W/A Joonas Lahtinen
2017-11-27 9:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-27 10:33 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-11-27 13:36 ` [PATCH] " Rantala, Valtteri
2017-11-29 8:00 ` Joonas Lahtinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511942427.4747.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=eero.t.tamminen@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=valtteri.rantala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.