From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jason Yan <yanaijie@huawei.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Zhaohongjiang <zhaohongjiang@huawei.com>,
Miao Xie <miaoxie@huawei.com>
Subject: Re: [PATCH] scsi: fix race condition when removing target
Date: Wed, 29 Nov 2017 08:47:02 -0800 [thread overview]
Message-ID: <1511974022.3222.11.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171129163421.GA32495@lst.de>
On Wed, 2017-11-29 at 17:34 +0100, Christoph Hellwig wrote:
> On Wed, Nov 29, 2017 at 08:31:48AM -0800, James Bottomley wrote:
> >
> > This analysis fails here: get_device() on something with refcount 0
> > returns NULL. That triggers the if clause to ignore this device.
>
> No, it doesn't. Take a look at the get_device and kobject_get
> implementations,
Hm, so why doesn't get_device use kref_get_unless_zero()?
James
next prev parent reply other threads:[~2017-11-29 16:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 3:05 [PATCH] scsi: fix race condition when removing target Jason Yan
2017-11-29 7:41 ` Hannes Reinecke
2017-11-29 16:18 ` Bart Van Assche
2017-11-29 16:20 ` hch
2017-11-29 17:39 ` Bart Van Assche
2017-11-30 1:18 ` Jason Yan
2017-11-30 16:08 ` Bart Van Assche
2017-11-30 16:40 ` gregkh
2017-11-30 23:56 ` James Bottomley
2017-12-01 1:12 ` Finn Thain
2017-12-01 8:40 ` Jason Yan
2017-12-01 14:41 ` Ewan D. Milne
2017-12-01 15:35 ` James Bottomley
2017-12-05 12:37 ` Jason Yan
2017-12-05 15:37 ` James Bottomley
2017-12-06 0:41 ` Jason Yan
2017-12-06 2:07 ` James Bottomley
2017-12-06 2:43 ` Jason Yan
2017-11-29 17:39 ` gregkh
2017-11-29 18:49 ` Ewan D. Milne
2017-11-29 19:11 ` Bart Van Assche
2017-11-29 19:20 ` Ewan D. Milne
2017-11-29 19:50 ` Bart Van Assche
2017-11-29 17:39 ` gregkh
2017-11-29 17:47 ` Bart Van Assche
2017-11-29 16:31 ` James Bottomley
2017-11-29 16:34 ` Christoph Hellwig
2017-11-29 16:47 ` James Bottomley [this message]
2017-11-29 19:05 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511974022.3222.11.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=miaoxie@huawei.com \
--cc=yanaijie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.