From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Wed, 29 Nov 2017 17:51:36 +0000 Subject: Re: [PATCH] jsm_tty: Fix a possible null pointer dereference in two functions Message-Id: <1511977896.19952.69.camel@perches.com> List-Id: References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net> <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com> In-Reply-To: <20171129173504.GA20581@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: SF Markus Elfring , linux-serial@vger.kernel.org, "Guilherme G. Piccoli" , Jiri Slaby , LKML , kernel-janitors@vger.kernel.org On Wed, 2017-11-29 at 17:35 +0000, Greg Kroah-Hartman wrote: > On Wed, Nov 29, 2017 at 09:23:07AM -0800, Joe Perches wrote: > > On Wed, 2017-11-29 at 17:40 +0100, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Wed, 29 Nov 2017 17:30:36 +0100 > > > > > > Move two debug messages so that a null pointer access can not happen > > > for the variable "ch" in these functions. > > > > An actual defect fix! > > Nope, not at all, this does not "fix" anything. Well, I believe it does in unusual cases like a CONFIG_DYNAMIC_DEBUG when this is enabled by an odd +p in the dynamic debug control file. > > Here you could probably cc stable too. > > Nope, not worth it. It's pretty unlikely, but it is an actual defect. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] jsm_tty: Fix a possible null pointer dereference in two functions Date: Wed, 29 Nov 2017 09:51:36 -0800 Message-ID: <1511977896.19952.69.camel@perches.com> References: <5c78db97-88f5-8655-9a47-eeee0a043fba@users.sourceforge.net> <1511976187.19952.65.camel@perches.com> <20171129173504.GA20581@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20171129173504.GA20581@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: SF Markus Elfring , linux-serial@vger.kernel.org, "Guilherme G. Piccoli" , Jiri Slaby , LKML , kernel-janitors@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Wed, 2017-11-29 at 17:35 +0000, Greg Kroah-Hartman wrote: > On Wed, Nov 29, 2017 at 09:23:07AM -0800, Joe Perches wrote: > > On Wed, 2017-11-29 at 17:40 +0100, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Wed, 29 Nov 2017 17:30:36 +0100 > > > > > > Move two debug messages so that a null pointer access can not happen > > > for the variable "ch" in these functions. > > > > An actual defect fix! > > Nope, not at all, this does not "fix" anything. Well, I believe it does in unusual cases like a CONFIG_DYNAMIC_DEBUG when this is enabled by an odd +p in the dynamic debug control file. > > Here you could probably cc stable too. > > Nope, not worth it. It's pretty unlikely, but it is an actual defect.