From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752825AbdK2SQi convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 13:16:38 -0500
Received: from mout.gmx.net ([212.227.15.15]:63536 "EHLO mout.gmx.net"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752258AbdK2SQN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 13:16:13 -0500
Message-ID: <1511979321.8321.141.camel@gmx.de>
Subject: Re: [PATCH RFC 1/2] sched: Minimize the idle cpu selection race
 window.
From: Mike Galbraith <efault@gmx.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Atish Patra <atish.patra@oracle.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Joel Fernandes <joelaf@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Brendan Jackman <brendan.jackman@arm.com>, Josef Bacik <jbacik@fb.com>,
        Ingo Molnar <mingo@redhat.com>
Date: Wed, 29 Nov 2017 19:15:21 +0100
In-Reply-To: <20171129104147.dcc25xv64o4bwdyv@pc636>
References: <1509427662-25114-2-git-send-email-atish.patra@oracle.com>
         <20171031082009.rxxa57goto6q5xld@hirez.programming.kicks-ass.net>
         <CAJWu+ooYjFK3+cLnzKgmchOL_bwdYjvHkOL0de=SixVT_CLy=Q@mail.gmail.com>
         <49e98b00-80c7-b3a4-30fd-bccb382d002b@oracle.com>
         <20171123105247.wcl2fiypge2pvile@pc636> <1511442781.6505.26.camel@gmx.de>
         <20171124102636.zqqjqa3sru7ebh4k@pc636> <1511549190.8029.233.camel@gmx.de>
         <20171128093422.5hmrkonj3z6twy2y@pc636> <1511866151.8472.51.camel@gmx.de>
         <20171129104147.dcc25xv64o4bwdyv@pc636>
Content-Type: text/plain; charset="ISO-8859-15"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
X-Provags-ID: V03:K0:pOANkwU2GazZJScwkXLnFdzOIR2qQWxHT+RzItfRCTbUBQNlZ5W
 hn8HVmcZ42aCxf0Z7c4vSXh5xKsEXq9N6XhKEvVgNUqaVPBk4rTQi9GWMnS1wG/6As6bq39
 KFZh1sjTtcl0GKGdTVvLQFExSrG0MLDtH0AO6Fsilit8EdfxG0oMcmVXtSuMJUHAi/1CUO9
 D+iQbZstb16zu9+Th1jAw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:pNm0mflifYM=:GH0oSjlkskzeKEXk3uFHa7
 6eF5k99cWnj29R7rce6qYLx/6e1i+tsCIj7ib6ibRMPc/cLYCnG/K+leLvTGB76vc7r6LKfju
 DNQaPZdo7H76XE/K3/yz4g7ci+CTuhE4HuJ8JBifO8PV2ZzSNSrWUicILwwUgrs80AmYYm1Tt
 IcLyllZVu0dAlPx1X7/b5qsVwDtP48snyFMW3MMTdzwQXoJPwv56sQbgiTqdKBac6cvkCQCmi
 OdBbKrwSj04Tvd8viCWwcMaEwtrTf0l7RcptTbbJ9AdBSwzB8rMbz6dw5WOO5giWWoJRFXmjS
 eTXMCoeCCnQ4uJArDDetB9egBXMair8Umv1R9zovaDUzZs3kCos1SaKNYJ0ZywCdxbKAfvzbB
 M9rPyvTrgWFCUj70H6QmdJi7oAY5Pbp6gd/jTXg/1k712M5kjgaql0ct0O+OrSUAuUvC4PlYw
 phB3iV4pl4S6UPuVI/QaP3CF0UN7EKkDI3te6zfxa56djZtiAOUrfrKFVDL4M8ogTtEMxVmGK
 cQvKEhqri+uvn1mxF9WFnkgoSRrRx/I3oKw3EIenM8aI/qt+E5F79MbO7Q7yfIy1tNqpoDcOs
 kA3eC6b8SzirKJbIT7hwYzu0OGPghtz4SsYMrEZ+H78f3+trTlXMcAnnT8MGOlNTf3KyY3I7H
 apu++8/IJFqztI6xEnYUOUnbwYYRnClrQNeGR0hnz9VT83gblIDshLyEMgxsrfp+R0B2x++X0
 SlR+Nim1/+qRB5mPirTIw/cxUi/bNZDojWqjrfY/7HvbiPGj/m4vaSyVqbbWwkwe2L/6Fvtir
 WWzN/ic89hbvlqzGshqRhGaHHJRbnTWfXnPmOIflw0gLpWp+Rg=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2017-11-29 at 11:41 +0100, Uladzislau Rezki wrote:
> On Tue, Nov 28, 2017 at 11:49:11AM +0100, Mike Galbraith wrote:
> > On Tue, 2017-11-28 at 10:34 +0100, Uladzislau Rezki wrote:
> > > On Fri, Nov 24, 2017 at 07:46:30PM +0100, Mike Galbraith wrote:
> > > 
> > > > My view is you're barking up the wrong tree: you're making the idle
> > > > data SIS is using more accurate, but I question the benefit.  That it
> > > > makes an imperfect placement decision occasionally due to raciness is
> > > > nearly meaningless compared to the cost of frequent bounce.
> > 
> > > Before sitting down and start testing, i just illustrated how we can
> > > apply claim_wake_up to ilb asking community a specific view on it:
> > > drawbacks, pros/cons, proposals etc.
> > 
> > Even if you make the thing atomic, what is ILB supposed to do, look
> > over its shoulder every step of the way and sh*t it's pants if somebody
> > touches claim_wake_up as it's about to or just after it did something?
> If nohz.idle_cpus_mask is set for particular CPU together with claim mask,
> it means that TIF_NEED_RESCHED is coming or is already in place. When a
> CPU hits idle_thread a claim bit gets reset and proceed to no_hz mode
> unless it runs into scheduler_ipi or so.

Which means nothing to an LB operation in progress.

But whatever, I'm not going to argue endlessly about something I think
should be blatantly obvious.  IMO, this is a couple points shy of
pointless.  That's my 'C' to this RFC in a nutshell.  I'm done.

	-Mike