From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbdLALK4 (ORCPT ); Fri, 1 Dec 2017 06:10:56 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:44124 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752241AbdLALKw (ORCPT ); Fri, 1 Dec 2017 06:10:52 -0500 X-Google-Smtp-Source: AGs4zMZHLe5mERWUgvdrp2iPUnhDLxfo0DLDKv4dDKpBpLAENBRRZ7/756Fvjd7ea8ggvWF5wFdFwA== Message-ID: <1512126649.4897.192.camel@gmail.com> Subject: Re: [PATCH v2 06/10] trace-cmd: Extr. profile-specific code from record_trace From: Vladislav Valtchev To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com Date: Fri, 01 Dec 2017 13:10:49 +0200 In-Reply-To: <20171130120514.5eb4518f@gandalf.local.home> References: <20171130131957.21617-1-vladislav.valtchev@gmail.com> <20171130131957.21617-7-vladislav.valtchev@gmail.com> <20171130120514.5eb4518f@gandalf.local.home> Organization: VMware Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-11-30 at 12:05 -0500, Steven Rostedt wrote: > I modified the subject to: > > trace-cmd: Extract profile-specific code from record_trace > > Let's not abbreviate in the subject if we don't need to. It makes it > harder to read. > I'm totally fine with not abbreviating so much the subject! I did that because of posts like this: https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting and because vim shows in yellow the first 50 characters of the summary, to help people following that limitation. In order words, I've understood that I shall try to fit in 50 chars and never exceed 72 chars. That lead me to desperate attempts to save characters, like in patch 7 where I tried to abbreviate "move" with "mov", but I couldn't add a dot for obvious reasons. [Until now, I was used to make the summary fit in 80 characters.] What is the convention for trace-cmd? In particular, what's the hard-limit I shall never exceed ? Vlad