All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luciano Coelho <luciano.coelho@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
	Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames
Date: Fri, 01 Dec 2017 13:48:45 +0200	[thread overview]
Message-ID: <1512128925.4827.49.camel@intel.com> (raw)
In-Reply-To: <1509353300.2637.2.camel@sipsolutions.net>

On Mon, 2017-10-30 at 09:48 +0100, Johannes Berg wrote:
> On Sun, 2017-10-29 at 11:51 +0200, Luca Coelho wrote:
> > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > 
> > The 2016 version of the spec is more generic about when the
> > AP should update the power management state of the peer:
> > the AP shall update the state based on any management or
> > data frames. This means that even non-bufferable management
> > frames should be looked at to update to maintain the power
> > management state of the peer.
> > 
> > This can avoid problematic cases for example if a station
> > disappears while being asleep and then re-appears. The AP
> > would remember it as in power save, but the Authentication
> > frame couldn't be used to set the peer as awake again.
> > Note that this issues wasn't really critical since at some
> > point (after the association) we would have removed the
> > station and created another one with all the states cleared.
> 
> IIRC this caused a hwsim test failure - is that addressed yet?

FTR, I'm sending a separate patch with the hwsim fix, as we agreed, as
part of the patchset I'm sending today.

--
Luca.

  reply	other threads:[~2017-12-01 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-29  9:51 [PATCH 0/5] cfg80211/mac80211 patches from our internal tree 2017-10-29 Luca Coelho
2017-10-29  9:51 ` [PATCH 1/5] mac80211: always update the PM state of a peer on MGMT / DATA frames Luca Coelho
2017-10-30  8:48   ` Johannes Berg
2017-12-01 11:48     ` Luciano Coelho [this message]
2017-12-01 12:09       ` Johannes Berg
2017-12-01 13:07         ` Luciano Coelho
2017-10-29  9:51 ` [PATCH 2/5] mac80211: call synchronize_net once in the restart flow Luca Coelho
2017-10-29  9:51 ` [PATCH 3/5] mac80211: tear down RX aggregations first Luca Coelho
2017-10-29  9:51 ` [PATCH 4/5] mac80211: remove BUG() when interface type is invalid Luca Coelho
2017-10-29  9:51 ` [PATCH 5/5] cfg80211: IBSS: Add support for static WEP in driver for IBSS Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512128925.4827.49.camel@intel.com \
    --to=luciano.coelho@intel.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.