diff for duplicates of <1512314250.3673.6.camel@primarydata.com> diff --git a/a/1.txt b/N1/1.txt index 9914a0c..532c4ea 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,35 +1,53 @@ -T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 -ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo -ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs -ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz -X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw -MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx -My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt -Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs -aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0 -cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg -c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s -bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl -ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj -fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm -cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv -dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl -L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw -aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 -ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs -dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0 -ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv -bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv -YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls -ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K -PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz -b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp -b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0 -aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl -DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa -aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj -aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg -TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u -ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo +On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote: +> Hello, +> +> I came along some software modules where I suggested source code +> adjustments. +> +> Example: +> nfs/write: Use common error handling code in +> nfs_lock_and_join_requests() +> +> https://lkml.org/lkml/2017/11/7/599 +> https://patchwork.kernel.org/patch/10047013/ +> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users +> .sourceforge.net>; +> +> I would like to check corresponding build results then without extra +> optimisation applied by the compiler. +> But I got surprised by error messages for a command like the +> following. +> +> elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && +> LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' +> allmodconfig fs/nfs/write.o +> … +> In file included from ./include/linux/compiler.h:58:0, +> from ./include/uapi/linux/stddef.h:1, +> from ./include/linux/stddef.h:4, +> from ./include/uapi/linux/posix_types.h:4, +> from ./include/uapi/linux/types.h:13, +> from ./include/linux/types.h:5, +> from fs/nfs/write.c:9: +> ./arch/x86/include/asm/jump_label.h: In function +> ‘trace_nfs_writeback_page_enter’: +> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 +> probably doesn’t match constraints +> #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while +> (0) +> … +> +> +> How do you think about to improve this software situation anyhow? + +I'm not seeing anything obviously wrong with the NFS use of tracepoints +there, and the warning suggests rather that gcc has an issue with the +inlined assembly code in jump_label.h. + +Ccing Peter Zijlstra (who appears to have been the last person to touch +that assembly code) and Steven Rostedt. + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust at primarydata.com diff --git a/a/content_digest b/N1/content_digest index 82ed98b..ed16651 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,45 +1,62 @@ "ref\07f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net\0" "ref\0a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net\0" - "From\0Trond Myklebust <trondmy@primarydata.com>\0" - "Subject\0Re: Difficulties for compilation without extra optimisation\0" - "Date\0Sun, 03 Dec 2017 15:17:32 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "From\0trondmy at primarydata.com (Trond Myklebust)\0" + "Subject\0[Linux-kselftest-mirror] Difficulties for compilation without extra optimisation\0" + "Date\0Sun, 3 Dec 2017 15:17:32 +0000\0" "\00:1\0" "b\0" - "T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90\n" - "ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo\n" - "ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs\n" - "ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz\n" - "X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw\n" - "MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx\n" - "My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt\n" - "Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs\n" - "aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0\n" - "cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg\n" - "c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s\n" - "bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl\n" - "ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj\n" - "fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm\n" - "cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv\n" - "dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl\n" - "L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw\n" - "aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1\n" - "ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs\n" - "dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0\n" - "ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv\n" - "bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv\n" - "YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls\n" - "ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K\n" - "PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz\n" - "b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp\n" - "b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0\n" - "aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl\n" - "DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa\n" - "aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj\n" - "aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg\n" - "TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u\n" - ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo + "On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote:\n" + "> Hello,\n" + "> \n" + "> I came along some software modules where I suggested source code\n" + "> adjustments.\n" + "> \n" + "> Example:\n" + "> nfs/write: Use common error handling code in\n" + "> nfs_lock_and_join_requests()\n" + "> \n" + "> https://lkml.org/lkml/2017/11/7/599\n" + "> https://patchwork.kernel.org/patch/10047013/\n" + "> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users\n" + "> .sourceforge.net>;\n" + "> \n" + "> I would like to check corresponding build results then without extra\n" + "> optimisation applied by the compiler.\n" + "> But I got surprised by error messages for a command like the\n" + "> following.\n" + "> \n" + "> elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 &&\n" + "> LANG=C make -j4 CC=\"${my_cc}\" HOSTCC=\"${my_cc}\" EXTRA_CFLAGS='-O0'\n" + "> allmodconfig fs/nfs/write.o\n" + "> \342\200\246\n" + "> In file included from ./include/linux/compiler.h:58:0,\n" + "> from ./include/uapi/linux/stddef.h:1,\n" + "> from ./include/linux/stddef.h:4,\n" + "> from ./include/uapi/linux/posix_types.h:4,\n" + "> from ./include/uapi/linux/types.h:13,\n" + "> from ./include/linux/types.h:5,\n" + "> from fs/nfs/write.c:9:\n" + "> ./arch/x86/include/asm/jump_label.h: In function\n" + "> \342\200\230trace_nfs_writeback_page_enter\342\200\231:\n" + "> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0\n" + "> probably doesn\342\200\231t match constraints\n" + "> #define asm_volatile_goto(x...) do { asm goto(x); asm (\"\"); } while\n" + "> (0)\n" + "> \342\200\246\n" + "> \n" + "> \n" + "> How do you think about to improve this software situation anyhow?\n" + "\n" + "I'm not seeing anything obviously wrong with the NFS use of tracepoints\n" + "there, and the warning suggests rather that gcc has an issue with the\n" + "inlined assembly code in jump_label.h.\n" + "\n" + "Ccing Peter Zijlstra (who appears to have been the last person to touch\n" + "that assembly code) and Steven Rostedt.\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust at primarydata.com -5f095dbbf3730abc192d5333f7b9c83830890b6f3b8c4355472392201fc17dca +c70fe9eea47c4d1daf015c7505fb8b46fb4923c51450552558a6ac899b3eea58
diff --git a/a/1.txt b/N2/1.txt index 9914a0c..212c1eb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,35 +1,53 @@ -T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 -ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo -ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs -ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz -X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw -MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx -My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt -Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs -aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0 -cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg -c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s -bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl -ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj -fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm -cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv -dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl -L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw -aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 -ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs -dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0 -ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv -bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv -YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls -ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K -PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz -b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp -b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0 -aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl -DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa -aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj -aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg -TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u -ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo +On Sun, 2017-12-03@15:15 +0100, SF Markus Elfring wrote: +> Hello, +> +> I came along some software modules where I suggested source code +> adjustments. +> +> Example: +> nfs/write: Use common error handling code in +> nfs_lock_and_join_requests() +> +> https://lkml.org/lkml/2017/11/7/599 +> https://patchwork.kernel.org/patch/10047013/ +> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users +> .sourceforge.net>; +> +> I would like to check corresponding build results then without extra +> optimisation applied by the compiler. +> But I got surprised by error messages for a command like the +> following. +> +> elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && +> LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' +> allmodconfig fs/nfs/write.o +> … +> In file included from ./include/linux/compiler.h:58:0, +> from ./include/uapi/linux/stddef.h:1, +> from ./include/linux/stddef.h:4, +> from ./include/uapi/linux/posix_types.h:4, +> from ./include/uapi/linux/types.h:13, +> from ./include/linux/types.h:5, +> from fs/nfs/write.c:9: +> ./arch/x86/include/asm/jump_label.h: In function +> ‘trace_nfs_writeback_page_enter’: +> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 +> probably doesn’t match constraints +> #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while +> (0) +> … +> +> +> How do you think about to improve this software situation anyhow? + +I'm not seeing anything obviously wrong with the NFS use of tracepoints +there, and the warning suggests rather that gcc has an issue with the +inlined assembly code in jump_label.h. + +Ccing Peter Zijlstra (who appears to have been the last person to touch +that assembly code) and Steven Rostedt. + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust at primarydata.com diff --git a/a/content_digest b/N2/content_digest index 82ed98b..021d33f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,45 +1,62 @@ "ref\07f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net\0" "ref\0a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net\0" - "From\0Trond Myklebust <trondmy@primarydata.com>\0" - "Subject\0Re: Difficulties for compilation without extra optimisation\0" - "Date\0Sun, 03 Dec 2017 15:17:32 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "From\0trondmy@primarydata.com (Trond Myklebust)\0" + "Subject\0[Linux-kselftest-mirror] Difficulties for compilation without extra optimisation\0" + "Date\0Sun, 3 Dec 2017 15:17:32 +0000\0" "\00:1\0" "b\0" - "T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90\n" - "ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo\n" - "ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs\n" - "ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz\n" - "X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw\n" - "MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx\n" - "My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt\n" - "Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs\n" - "aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0\n" - "cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg\n" - "c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s\n" - "bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl\n" - "ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj\n" - "fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm\n" - "cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv\n" - "dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl\n" - "L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw\n" - "aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1\n" - "ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs\n" - "dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0\n" - "ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv\n" - "bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv\n" - "YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls\n" - "ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K\n" - "PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz\n" - "b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp\n" - "b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0\n" - "aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl\n" - "DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa\n" - "aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj\n" - "aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg\n" - "TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u\n" - ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo + "On Sun, 2017-12-03@15:15 +0100, SF Markus Elfring wrote:\n" + "> Hello,\n" + "> \n" + "> I came along some software modules where I suggested source code\n" + "> adjustments.\n" + "> \n" + "> Example:\n" + "> nfs/write: Use common error handling code in\n" + "> nfs_lock_and_join_requests()\n" + "> \n" + "> https://lkml.org/lkml/2017/11/7/599\n" + "> https://patchwork.kernel.org/patch/10047013/\n" + "> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users\n" + "> .sourceforge.net>;\n" + "> \n" + "> I would like to check corresponding build results then without extra\n" + "> optimisation applied by the compiler.\n" + "> But I got surprised by error messages for a command like the\n" + "> following.\n" + "> \n" + "> elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 &&\n" + "> LANG=C make -j4 CC=\"${my_cc}\" HOSTCC=\"${my_cc}\" EXTRA_CFLAGS='-O0'\n" + "> allmodconfig fs/nfs/write.o\n" + "> \342\200\246\n" + "> In file included from ./include/linux/compiler.h:58:0,\n" + "> from ./include/uapi/linux/stddef.h:1,\n" + "> from ./include/linux/stddef.h:4,\n" + "> from ./include/uapi/linux/posix_types.h:4,\n" + "> from ./include/uapi/linux/types.h:13,\n" + "> from ./include/linux/types.h:5,\n" + "> from fs/nfs/write.c:9:\n" + "> ./arch/x86/include/asm/jump_label.h: In function\n" + "> \342\200\230trace_nfs_writeback_page_enter\342\200\231:\n" + "> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0\n" + "> probably doesn\342\200\231t match constraints\n" + "> #define asm_volatile_goto(x...) do { asm goto(x); asm (\"\"); } while\n" + "> (0)\n" + "> \342\200\246\n" + "> \n" + "> \n" + "> How do you think about to improve this software situation anyhow?\n" + "\n" + "I'm not seeing anything obviously wrong with the NFS use of tracepoints\n" + "there, and the warning suggests rather that gcc has an issue with the\n" + "inlined assembly code in jump_label.h.\n" + "\n" + "Ccing Peter Zijlstra (who appears to have been the last person to touch\n" + "that assembly code) and Steven Rostedt.\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust at primarydata.com -5f095dbbf3730abc192d5333f7b9c83830890b6f3b8c4355472392201fc17dca +dcc3ab46c306b5992d0f8d14805175aecad05befd66cb4632f58388b7c378a0c
diff --git a/a/1.txt b/N3/1.txt index 9914a0c..885a889 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -32,4 +32,4 @@ DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u -ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo +ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo= diff --git a/a/content_digest b/N3/content_digest index 82ed98b..78c1c9a 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -2,8 +2,14 @@ "ref\0a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net\0" "From\0Trond Myklebust <trondmy@primarydata.com>\0" "Subject\0Re: Difficulties for compilation without extra optimisation\0" - "Date\0Sun, 03 Dec 2017 15:17:32 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "Date\0Sun, 3 Dec 2017 15:17:32 +0000\0" + "To\0linux-kselftest@vger.kernel.org <linux-kselftest@vger.kernel.org>" + elfring@users.sourceforge.net <elfring@users.sourceforge.net> + linux-nfs@vger.kernel.org <linux-nfs@vger.kernel.org> + " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + peterz@infradead.org <peterz@infradead.org> + " rostedt@goodmis.org <rostedt@goodmis.org>\0" "\00:1\0" "b\0" "T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90\n" @@ -40,6 +46,6 @@ "aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj\n" "aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg\n" "TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u\n" - ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo + ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo= -5f095dbbf3730abc192d5333f7b9c83830890b6f3b8c4355472392201fc17dca +aa8ce8408de7e6af938c3b08740b645218e9e6150b900a25dc14201e4a76aa77
diff --git a/a/1.txt b/N4/1.txt index 9914a0c..8e93da6 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -1,35 +1,53 @@ -T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 -ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo -ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs -ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz -X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw -MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx -My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt -Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs -aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0 -cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg -c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s -bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl -ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj -fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm -cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv -dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl -L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw -aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 -ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs -dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0 -ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv -bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s -aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv -YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls -ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K -PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz -b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp -b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0 -aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl -DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa -aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj -aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg -TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u -ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo +On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote: +> Hello, +> +> I came along some software modules where I suggested source code +> adjustments. +> +> Example: +> nfs/write: Use common error handling code in +> nfs_lock_and_join_requests() +> +> https://lkml.org/lkml/2017/11/7/599 +> https://patchwork.kernel.org/patch/10047013/ +> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32@users +> .sourceforge.net>; +> +> I would like to check corresponding build results then without extra +> optimisation applied by the compiler. +> But I got surprised by error messages for a command like the +> following. +> +> elfring@Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && +> LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' +> allmodconfig fs/nfs/write.o +> … +> In file included from ./include/linux/compiler.h:58:0, +> from ./include/uapi/linux/stddef.h:1, +> from ./include/linux/stddef.h:4, +> from ./include/uapi/linux/posix_types.h:4, +> from ./include/uapi/linux/types.h:13, +> from ./include/linux/types.h:5, +> from fs/nfs/write.c:9: +> ./arch/x86/include/asm/jump_label.h: In function +> ‘trace_nfs_writeback_page_enter’: +> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 +> probably doesn’t match constraints +> #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while +> (0) +> … +> +> +> How do you think about to improve this software situation anyhow? + +I'm not seeing anything obviously wrong with the NFS use of tracepoints +there, and the warning suggests rather that gcc has an issue with the +inlined assembly code in jump_label.h. + +Ccing Peter Zijlstra (who appears to have been the last person to touch +that assembly code) and Steven Rostedt. + +-- +Trond Myklebust +Linux NFS client maintainer, PrimaryData +trond.myklebust@primarydata.com diff --git a/a/content_digest b/N4/content_digest index 82ed98b..908fe72 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -2,44 +2,68 @@ "ref\0a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net\0" "From\0Trond Myklebust <trondmy@primarydata.com>\0" "Subject\0Re: Difficulties for compilation without extra optimisation\0" - "Date\0Sun, 03 Dec 2017 15:17:32 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "Date\0Sun, 3 Dec 2017 15:17:32 +0000\0" + "To\0linux-kselftest@vger.kernel.org <linux-kselftest@vger.kernel.org>" + elfring@users.sourceforge.net <elfring@users.sourceforge.net> + linux-nfs@vger.kernel.org <linux-nfs@vger.kernel.org> + " kernel-janitors@vger.kernel.org <kernel-janitors@vger.kernel.org>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + peterz@infradead.org <peterz@infradead.org> + " rostedt@goodmis.org <rostedt@goodmis.org>\0" "\00:1\0" "b\0" - "T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90\n" - "ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo\n" - "ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs\n" - "ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz\n" - "X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw\n" - "MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx\n" - "My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt\n" - "Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs\n" - "aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0\n" - "cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg\n" - "c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s\n" - "bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl\n" - "ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj\n" - "fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm\n" - "cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv\n" - "dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl\n" - "L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw\n" - "aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1\n" - "ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs\n" - "dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0\n" - "ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv\n" - "bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s\n" - "aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv\n" - "YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls\n" - "ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K\n" - "PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz\n" - "b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp\n" - "b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0\n" - "aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl\n" - "DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa\n" - "aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj\n" - "aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg\n" - "TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u\n" - ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo + "On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote:\n" + "> Hello,\n" + "> \n" + "> I came along some software modules where I suggested source code\n" + "> adjustments.\n" + "> \n" + "> Example:\n" + "> nfs/write: Use common error handling code in\n" + "> nfs_lock_and_join_requests()\n" + "> \n" + "> https://lkml.org/lkml/2017/11/7/599\n" + "> https://patchwork.kernel.org/patch/10047013/\n" + "> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32@users\n" + "> .sourceforge.net>;\n" + "> \n" + "> I would like to check corresponding build results then without extra\n" + "> optimisation applied by the compiler.\n" + "> But I got surprised by error messages for a command like the\n" + "> following.\n" + "> \n" + "> elfring@Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 &&\n" + "> LANG=C make -j4 CC=\"${my_cc}\" HOSTCC=\"${my_cc}\" EXTRA_CFLAGS='-O0'\n" + "> allmodconfig fs/nfs/write.o\n" + "> \342\200\246\n" + "> In file included from ./include/linux/compiler.h:58:0,\n" + "> from ./include/uapi/linux/stddef.h:1,\n" + "> from ./include/linux/stddef.h:4,\n" + "> from ./include/uapi/linux/posix_types.h:4,\n" + "> from ./include/uapi/linux/types.h:13,\n" + "> from ./include/linux/types.h:5,\n" + "> from fs/nfs/write.c:9:\n" + "> ./arch/x86/include/asm/jump_label.h: In function\n" + "> \342\200\230trace_nfs_writeback_page_enter\342\200\231:\n" + "> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0\n" + "> probably doesn\342\200\231t match constraints\n" + "> #define asm_volatile_goto(x...) do { asm goto(x); asm (\"\"); } while\n" + "> (0)\n" + "> \342\200\246\n" + "> \n" + "> \n" + "> How do you think about to improve this software situation anyhow?\n" + "\n" + "I'm not seeing anything obviously wrong with the NFS use of tracepoints\n" + "there, and the warning suggests rather that gcc has an issue with the\n" + "inlined assembly code in jump_label.h.\n" + "\n" + "Ccing Peter Zijlstra (who appears to have been the last person to touch\n" + "that assembly code) and Steven Rostedt.\n" + "\n" + "-- \n" + "Trond Myklebust\n" + "Linux NFS client maintainer, PrimaryData\n" + trond.myklebust@primarydata.com -5f095dbbf3730abc192d5333f7b9c83830890b6f3b8c4355472392201fc17dca +b209b70a5337b3016585ed3b01eaa0c9580354ffc6e0ed18936d42e9d8d5b659
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.