From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Date: Sun, 03 Dec 2017 15:17:32 +0000 Subject: Re: Difficulties for compilation without extra optimisation Message-Id: <1512314250.3673.6.camel@primarydata.com> List-Id: References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0 cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0 ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0 aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo From mboxrd@z Thu Jan 1 00:00:00 1970 From: trondmy at primarydata.com (Trond Myklebust) Date: Sun, 3 Dec 2017 15:17:32 +0000 Subject: [Linux-kselftest-mirror] Difficulties for compilation without extra optimisation In-Reply-To: References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> Message-ID: <1512314250.3673.6.camel@primarydata.com> On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote: > Hello, > > I came along some software modules where I suggested source code > adjustments. > > Example: > nfs/write: Use common error handling code in > nfs_lock_and_join_requests() > > https://lkml.org/lkml/2017/11/7/599 > https://patchwork.kernel.org/patch/10047013/ > https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users > .sourceforge.net>; > > I would like to check corresponding build results then without extra > optimisation applied by the compiler. > But I got surprised by error messages for a command like the > following. > > elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && > LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' > allmodconfig fs/nfs/write.o > … > In file included from ./include/linux/compiler.h:58:0, > from ./include/uapi/linux/stddef.h:1, > from ./include/linux/stddef.h:4, > from ./include/uapi/linux/posix_types.h:4, > from ./include/uapi/linux/types.h:13, > from ./include/linux/types.h:5, > from fs/nfs/write.c:9: > ./arch/x86/include/asm/jump_label.h: In function > ‘trace_nfs_writeback_page_enter’: > ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 > probably doesn’t match constraints > #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while > (0) > … > > > How do you think about to improve this software situation anyhow? I'm not seeing anything obviously wrong with the NFS use of tracepoints there, and the warning suggests rather that gcc has an issue with the inlined assembly code in jump_label.h. Ccing Peter Zijlstra (who appears to have been the last person to touch that assembly code) and Steven Rostedt. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust at primarydata.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: trondmy@primarydata.com (Trond Myklebust) Date: Sun, 3 Dec 2017 15:17:32 +0000 Subject: [Linux-kselftest-mirror] Difficulties for compilation without extra optimisation In-Reply-To: References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> Message-ID: <1512314250.3673.6.camel@primarydata.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20171203151732.TmZtdSum5LY5NKp92eE5qHHd1wbenbJmAOIQ47k7LYA@z> On Sun, 2017-12-03@15:15 +0100, SF Markus Elfring wrote: > Hello, > > I came along some software modules where I suggested source code > adjustments. > > Example: > nfs/write: Use common error handling code in > nfs_lock_and_join_requests() > > https://lkml.org/lkml/2017/11/7/599 > https://patchwork.kernel.org/patch/10047013/ > https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32 at users > .sourceforge.net>; > > I would like to check corresponding build results then without extra > optimisation applied by the compiler. > But I got surprised by error messages for a command like the > following. > > elfring at Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && > LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' > allmodconfig fs/nfs/write.o > … > In file included from ./include/linux/compiler.h:58:0, > from ./include/uapi/linux/stddef.h:1, > from ./include/linux/stddef.h:4, > from ./include/uapi/linux/posix_types.h:4, > from ./include/uapi/linux/types.h:13, > from ./include/linux/types.h:5, > from fs/nfs/write.c:9: > ./arch/x86/include/asm/jump_label.h: In function > ‘trace_nfs_writeback_page_enter’: > ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 > probably doesn’t match constraints > #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while > (0) > … > > > How do you think about to improve this software situation anyhow? I'm not seeing anything obviously wrong with the NFS use of tracepoints there, and the warning suggests rather that gcc has an issue with the inlined assembly code in jump_label.h. Ccing Peter Zijlstra (who appears to have been the last person to touch that assembly code) and Steven Rostedt. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust at primarydata.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:55602 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752482AbdLCPRj (ORCPT ); Sun, 3 Dec 2017 10:17:39 -0500 From: Trond Myklebust To: "linux-kselftest@vger.kernel.org" , "elfring@users.sourceforge.net" , "linux-nfs@vger.kernel.org" , "kernel-janitors@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" Subject: Re: Difficulties for compilation without extra optimisation Date: Sun, 3 Dec 2017 15:17:32 +0000 Message-ID: <1512314250.3673.6.camel@primarydata.com> References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gU3VuLCAyMDE3LTEyLTAzIGF0IDE1OjE1ICswMTAwLCBTRiBNYXJrdXMgRWxmcmluZyB3cm90 ZToNCj4gSGVsbG8sDQo+IA0KPiBJIGNhbWUgYWxvbmcgc29tZSBzb2Z0d2FyZSBtb2R1bGVzIHdo ZXJlIEkgc3VnZ2VzdGVkIHNvdXJjZSBjb2RlDQo+IGFkanVzdG1lbnRzLg0KPiANCj4gRXhhbXBs ZToNCj4gbmZzL3dyaXRlOiBVc2UgY29tbW9uIGVycm9yIGhhbmRsaW5nIGNvZGUgaW4NCj4gbmZz X2xvY2tfYW5kX2pvaW5fcmVxdWVzdHMoKQ0KPiANCj4gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIw MTcvMTEvNy81OTkNCj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDA0NzAx My8NCj4gaHR0cHM6Ly9sa21sLmtlcm5lbC5vcmcvci88N2YwNzJmNzgtZWVmNC02ZDg3LWQyMzMt Y2VlNzFkYWM1YTMyQHVzZXJzDQo+IC5zb3VyY2Vmb3JnZS5uZXQ+Ow0KPiANCj4gSSB3b3VsZCBs aWtlIHRvIGNoZWNrIGNvcnJlc3BvbmRpbmcgYnVpbGQgcmVzdWx0cyB0aGVuIHdpdGhvdXQgZXh0 cmENCj4gb3B0aW1pc2F0aW9uIGFwcGxpZWQgYnkgdGhlIGNvbXBpbGVyLg0KPiBCdXQgSSBnb3Qg c3VycHJpc2VkIGJ5IGVycm9yIG1lc3NhZ2VzIGZvciBhIGNvbW1hbmQgbGlrZSB0aGUNCj4gZm9s bG93aW5nLg0KPiANCj4gZWxmcmluZ0BTb25uZTp+L1Byb2pla3RlL0xpbnV4L25leHQtcGF0Y2hl ZD4gbXlfY2M9L3Vzci9iaW4vZ2NjLTcgJiYNCj4gTEFORz1DIG1ha2UgLWo0IENDPSIke215X2Nj fSIgSE9TVENDPSIke215X2NjfSIgRVhUUkFfQ0ZMQUdTPSctTzAnDQo+IGFsbG1vZGNvbmZpZyBm cy9uZnMvd3JpdGUubw0KPiDigKYNCj4gSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4vaW5jbHVkZS9s aW51eC9jb21waWxlci5oOjU4OjAsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUv dWFwaS9saW51eC9zdGRkZWYuaDoxLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNsdWRl L2xpbnV4L3N0ZGRlZi5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1ZGUvdWFw aS9saW51eC9wb3NpeF90eXBlcy5oOjQsDQo+ICAgICAgICAgICAgICAgICAgZnJvbSAuL2luY2x1 ZGUvdWFwaS9saW51eC90eXBlcy5oOjEzLA0KPiAgICAgICAgICAgICAgICAgIGZyb20gLi9pbmNs dWRlL2xpbnV4L3R5cGVzLmg6NSwNCj4gICAgICAgICAgICAgICAgICBmcm9tIGZzL25mcy93cml0 ZS5jOjk6DQo+IC4vYXJjaC94ODYvaW5jbHVkZS9hc20vanVtcF9sYWJlbC5oOiBJbiBmdW5jdGlv bg0KPiDigJh0cmFjZV9uZnNfd3JpdGViYWNrX3BhZ2VfZW50ZXLigJk6DQo+IC4vaW5jbHVkZS9s aW51eC9jb21waWxlci1nY2MuaDoyNzU6Mzg6IHdhcm5pbmc6IGFzbSBvcGVyYW5kIDANCj4gcHJv YmFibHkgZG9lc27igJl0IG1hdGNoIGNvbnN0cmFpbnRzDQo+ICAjZGVmaW5lIGFzbV92b2xhdGls ZV9nb3RvKHguLi4pIGRvIHsgYXNtIGdvdG8oeCk7IGFzbSAoIiIpOyB9IHdoaWxlDQo+ICgwKQ0K PiDigKYNCj4gDQo+IA0KPiBIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIGltcHJvdmUgdGhpcyBz b2Z0d2FyZSBzaXR1YXRpb24gYW55aG93Pw0KDQpJJ20gbm90IHNlZWluZyBhbnl0aGluZyBvYnZp b3VzbHkgd3Jvbmcgd2l0aCB0aGUgTkZTIHVzZSBvZiB0cmFjZXBvaW50cw0KdGhlcmUsIGFuZCB0 aGUgd2FybmluZyBzdWdnZXN0cyByYXRoZXIgdGhhdCBnY2MgaGFzIGFuIGlzc3VlIHdpdGggdGhl DQppbmxpbmVkIGFzc2VtYmx5IGNvZGUgaW4ganVtcF9sYWJlbC5oLg0KDQpDY2luZyBQZXRlciBa aWpsc3RyYSAod2hvIGFwcGVhcnMgdG8gaGF2ZSBiZWVuIHRoZSBsYXN0IHBlcnNvbiB0byB0b3Vj aA0KdGhhdCBhc3NlbWJseSBjb2RlKSBhbmQgU3RldmVuIFJvc3RlZHQuDQoNCi0tIA0KVHJvbmQg TXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXIsIFByaW1hcnlEYXRhDQp0cm9u ZC5teWtsZWJ1c3RAcHJpbWFyeWRhdGEuY29tDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbdLCPR4 (ORCPT ); Sun, 3 Dec 2017 10:17:56 -0500 Received: from us-smtp-delivery-194.mimecast.com ([63.128.21.194]:37862 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbdLCPRj (ORCPT ); Sun, 3 Dec 2017 10:17:39 -0500 From: Trond Myklebust To: "linux-kselftest@vger.kernel.org" , "elfring@users.sourceforge.net" , "linux-nfs@vger.kernel.org" , "kernel-janitors@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" Subject: Re: Difficulties for compilation without extra optimisation Thread-Topic: Difficulties for compilation without extra optimisation Thread-Index: AQHTbEFGE6l/WCtPOkq86gSp2T9pvKMxuykA Date: Sun, 3 Dec 2017 15:17:32 +0000 Message-ID: <1512314250.3673.6.camel@primarydata.com> References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [68.49.162.121] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR11MB0073;20:bTyZo8Tg2u0U/0/OvUiQSQN3oaToJBDwc6oeRmIr8iyuyZwE7n2Bv/eMckU0Dl6gbkQoPuV9quxBQDIZS9FhmIxBNM7udvN85F8O57DSOibcfl3uPLsy0TRYSCespYipP2DIAEicheZib3Bo5o/SKDABmXAR+dAua1j6tc08KWQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: aa7b31fe-0fa0-49cb-a02c-08d53a60f9d7 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4603075)(4627115)(201702281549075)(5600026)(4604075)(2017052603286);SRVR:DM5PR11MB0073; x-ms-traffictypediagnostic: DM5PR11MB0073: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(42262312472803)(42068640409301); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123564025)(2016111802025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6043046)(6072148)(201708071742011);SRVR:DM5PR11MB0073;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DM5PR11MB0073; x-forefront-prvs: 05102978A2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(39830400002)(346002)(366004)(199003)(377424004)(24454002)(189002)(81166006)(81156014)(105586002)(106356001)(66066001)(99286004)(316002)(305945005)(103116003)(2501003)(76176011)(33646002)(7736002)(68736007)(25786009)(6486002)(77096006)(6116002)(36756003)(3846002)(8676002)(3660700001)(189998001)(8936002)(966005)(102836003)(14454004)(110136005)(3280700002)(2906002)(6306002)(101416001)(97736004)(2900100001)(2950100002)(229853002)(6246003)(5660300001)(54356011)(6436002)(53936002)(2201001)(86362001)(6512007)(6506006)(478600001)(4326008)(54906003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR11MB0073;H:DM5PR11MB0075.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa7b31fe-0fa0-49cb-a02c-08d53a60f9d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2017 15:17:32.4316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0073 X-MC-Unique: Ek1MImEaN42doopLO7AJog-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB3FI0TX001362 On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote: > Hello, > > I came along some software modules where I suggested source code > adjustments. > > Example: > nfs/write: Use common error handling code in > nfs_lock_and_join_requests() > > https://lkml.org/lkml/2017/11/7/599 > https://patchwork.kernel.org/patch/10047013/ > https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32@users > .sourceforge.net>; > > I would like to check corresponding build results then without extra > optimisation applied by the compiler. > But I got surprised by error messages for a command like the > following. > > elfring@Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 && > LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0' > allmodconfig fs/nfs/write.o > … > In file included from ./include/linux/compiler.h:58:0, > from ./include/uapi/linux/stddef.h:1, > from ./include/linux/stddef.h:4, > from ./include/uapi/linux/posix_types.h:4, > from ./include/uapi/linux/types.h:13, > from ./include/linux/types.h:5, > from fs/nfs/write.c:9: > ./arch/x86/include/asm/jump_label.h: In function > ‘trace_nfs_writeback_page_enter’: > ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0 > probably doesn’t match constraints > #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while > (0) > … > > > How do you think about to improve this software situation anyhow? I'm not seeing anything obviously wrong with the NFS use of tracepoints there, and the warning suggests rather that gcc has an issue with the inlined assembly code in jump_label.h. Ccing Peter Zijlstra (who appears to have been the last person to touch that assembly code) and Steven Rostedt. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@primarydata.com