Re: [PATCH] Revert "drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk"

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

Hi,

Thanks, this was included in the pull.

One comment below, not strictly related to this patch.

On Wed, 2017-12-06 at 14:25 -0800, Rodrigo Vivi wrote:
> From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> 
> This reverts commit 8f067837c4b713ce2e69be95af7b2a5eb3bd7de8.
> 
> HSD says "WA withdrawn. It was causing corruption with some images.
> WA is not strictly necessary since this bug just causes loss of FBC
> compression with some sizes and images, but doesn't break anything."
> 
> Fixes: 8f067837c4b7 ("drm/i915: Display WA #1133 WaFbcSkipSegments:cnl, glk")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20171117010825.23118-1-radhakrishna.sripada@intel.com
> (cherry picked from commit 0cfecb7c4b9b45ed1776162e132b43f92564f3f4)

<SNIP>

> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -124,7 +124,6 @@ static void bxt_init_clock_gating(struct drm_i915_private *dev_priv)
>  
>  static void glk_init_clock_gating(struct drm_i915_private *dev_priv)
>  {
> -	u32 val;

This resulted being a pain because it got reused by another upstream
patch, so while this revert removed the variable, the newly added non-
conflicting code still depended on it.

More specific variable names like "dpfc" and allowing compiler to
decide when to optimize and recycle variables would have helped :)

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx