From: Joe Perches <joe@perches.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] checkpatch: warn for use of %px
Date: Thu, 07 Dec 2017 13:17:52 -0800 [thread overview]
Message-ID: <1512681472.1845.7.camel@perches.com> (raw)
In-Reply-To: <20171207210653.GK2191@eros>
On Fri, 2017-12-08 at 08:06 +1100, Tobin C. Harding wrote:
> On Wed, Dec 06, 2017 at 02:37:08PM +1100, Tobin C. Harding wrote:
> > Usage of the new %px specifier potentially leaks sensitive
> > inforamtion. Printing kernel addresses exposes the kernel layout in
> > memory, this is potentially exploitable. We have tools in the kernel to
> > help us do the right thing. We can have checkpatch warn developers of
> > potential dangers of using %px.
> >
> > Have checkpatch emit a warning for usage of specifier %px.
> >
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > Co-developed-by: Joe Perches <joe@perches.com>
>
> Co-Developed-by:
>
> Woops.
>
> Joe I didn't quite understand what you meant when you said that this
> could go in via any tree. I'm still learning the whole kernel tree
> management thing. Don't checkpatch patches go in via Andy's tree?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/apw/checkpatch.git/
No, not in quite awhile.
Most checkpatch patches go through Andrew Morton's
quilt/mm tree.
prev parent reply other threads:[~2017-12-07 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 3:37 [PATCH v2 0/3] checkpatch: warn for use of %px Tobin C. Harding
2017-12-06 3:37 ` [PATCH v2 1/3] checkpatch: add sub routine get_stat_real() Tobin C. Harding
2017-12-06 3:37 ` [PATCH v2 2/3] checkpatch: add sub routine get_stat_here() Tobin C. Harding
2017-12-06 3:37 ` [PATCH v2 3/3] checkpatch: warn for use of %px Tobin C. Harding
2017-12-07 21:06 ` Tobin C. Harding
2017-12-07 21:15 ` Tobin C. Harding
2017-12-07 21:27 ` Joe Perches
2017-12-07 21:17 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512681472.1845.7.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.