From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4.4,13/49] usb: dwc2: Fix UDC state tracking From: Ben Hutchings Message-Id: <1512704237.18523.221.camel@codethink.co.uk> Date: Fri, 08 Dec 2017 03:37:17 +0000 To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin List-ID: T24gVGh1LCAyMDE3LTEyLTA3IGF0IDE0OjA3ICswMTAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6Cj4gNC40LXN0YWJsZSByZXZpZXcgcGF0Y2guwqDCoElmIGFueW9uZSBoYXMgYW55IG9iamVj dGlvbnMsIHBsZWFzZSBsZXQgbWUKPiBrbm93Lgo+IAo+IC0tLS0tLS0tLS0tLS0tLS0tLQo+IAo+ IEZyb206IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBsaW5hcm8ub3JnPgo+IAo+IAo+IFsgVXBz dHJlYW0gY29tbWl0IGNlMmIyMWE0ZTVjZTA0MmMwYTQyYzlkYjhmYTllMGY4NDk0MjdkNWUgXQo+ IAo+IEl0IGhhcyBiZWVuIG5vdGljZWQgdGhhdCB0aGUgZHdjMiB1ZGMgc3RhdGUgcmVwb3J0aW5n IGRvZXNuJ3QKPiBzZWVtIHRvIHdvcmsgKGF0IGxlYXN0IG9uIEhpS2V5IGJvYXJkcykuIFdoZXJl IGFmdGVyIHRoZSBpbml0aWFsCj4gc2V0dXAsIHRoZSBzeXNmcyAvc3lzL2NsYXNzL3VkYy9mNzJj MDAwMC51c2Ivc3RhdGUgZmlsZSB3b3VsZAo+IHJlcG9ydCAiY29uZmlndXJlZCIgbm8gbWF0dGVy IHRoZSBzdGF0ZSBvZiB0aGUgT1RHIHBvcnQuCj4gCj4gVGhpcyBwYXRjaCBhZGRzIGEgY2FsbCBz byB0aGF0IHdlIHJlcG9ydCB0byB0aGUgVURDIGxheWVyIHdoZW4KPiB0aGUgZ2FkZ2V0IGRldmlj ZSBpcyBkaXNjb25uZWN0ZWQuCj4gCj4gVGhpcyBwYXRjaCBkb2VzIGRlcGVuZCBvbiB0aGUgcHJl dmlvdXMgcGF0Y2ggKCJ1c2I6IGR3YzI6Cj4gSW1wcm92ZSBnYWRnZXQgc3RhdGUgZGlzY29ubmVj dGlvbiBoYW5kbGluZyIpIGluIHRoaXMgcGF0Y2ggc2V0Cj4gaW4gb3JkZXIgdG8gcHJvcGVybHkg d29yay4KClRoZW4geW91IHNob3VsZCBhZGQgdGhhdCAoY29tbWl0IGQyNDcxZDRhMjRkZikuCgpC ZW4uCgo+IENjOiBXZWkgWHUgPHh1d2VpNUBoaXNpbGljb24uY29tPgo+IENjOiBHdW9kb25nIFh1 IDxndW9kb25nLnh1QGxpbmFyby5vcmc+Cj4gQ2M6IEFtaXQgUHVuZGlyIDxhbWl0LnB1bmRpckBs aW5hcm8ub3JnPgo+IENjOiBZb25nUWluIExpdSA8eW9uZ3Fpbi5saXVAbGluYXJvLm9yZz4KPiBD YzogSm9obiBZb3VuIDxqb2hueW91bkBzeW5vcHN5cy5jb20+Cj4gQ2M6IE1pbmFzIEhhcnV0eXVu eWFuIDxNaW5hcy5IYXJ1dHl1bnlhbkBzeW5vcHN5cy5jb20+Cj4gQ2M6IERvdWdsYXMgQW5kZXJz b24gPGRpYW5kZXJzQGNocm9taXVtLm9yZz4KPiBDYzogQ2hlbiBZdSA8Y2hlbnl1NTZAaHVhd2Vp LmNvbT4KPiBDYzogRmVsaXBlIEJhbGJpIDxmZWxpcGUuYmFsYmlAbGludXguaW50ZWwuY29tPgo+ IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+IENj OiBsaW51eC11c2JAdmdlci5rZXJuZWwub3JnCj4gQWNrZWQtYnk6IE1pbmFzIEhhcnV0eXVueWFu IDxobWluYXNAc3lub3BzeXMuY29tPgo+IFRlc3RlZC1ieTogTWluYXMgSGFydXR5dW55YW4gPGht aW5hc0BzeW5vcHN5cy5jb20+Cj4gUmVwb3J0ZWQtYnk6IEFtaXQgUHVuZGlyIDxhbWl0LnB1bmRp ckBsaW5hcm8ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEpvaG4gU3R1bHR6IDxqb2huLnN0dWx0ekBs aW5hcm8ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEZlbGlwZSBCYWxiaSA8ZmVsaXBlLmJhbGJpQGxp bnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8YWxleGFuZGVyLmxl dmluQHZlcml6b24uY29tPgo+IFNpZ25lZC1vZmYtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3Jl Z2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gLS0tCj4gwqBkcml2ZXJzL3VzYi9kd2MyL2dhZGdl dC5jIHzCoMKgwqDCoDIgKysKPiDCoDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAK PiAtLS0gYS9kcml2ZXJzL3VzYi9kd2MyL2dhZGdldC5jCj4gKysrIGIvZHJpdmVycy91c2IvZHdj Mi9nYWRnZXQuYwo+IEBAIC0yMjA2LDYgKzIyMDYsOCBAQCB2b2lkIGR3YzJfaHNvdGdfZGlzY29u bmVjdChzdHJ1Y3QgZHdjMl9oCj4gwqAKPiDCoAljYWxsX2dhZGdldChoc290ZywgZGlzY29ubmVj dCk7Cj4gwqAJaHNvdGctPmx4X3N0YXRlID0gRFdDMl9MMzsKPiArCj4gKwl1c2JfZ2FkZ2V0X3Nl dF9zdGF0ZSgmaHNvdGctPmdhZGdldCwgVVNCX1NUQVRFX05PVEFUVEFDSEVEKTsKPiDCoH0KPiDC oAo+IMKgLyoqCj4gCj4gCj4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbdLHDhZ (ORCPT ); Thu, 7 Dec 2017 22:37:25 -0500 Received: from imap1.codethink.co.uk ([176.9.8.82]:46408 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751633AbdLHDhX (ORCPT ); Thu, 7 Dec 2017 22:37:23 -0500 Message-ID: <1512704237.18523.221.camel@codethink.co.uk> Subject: Re: [PATCH 4.4 13/49] usb: dwc2: Fix UDC state tracking From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Wei Xu , Guodong Xu , Amit Pundir , YongQin Liu , John Youn , Minas Harutyunyan , Douglas Anderson , Chen Yu , Felipe Balbi , linux-usb@vger.kernel.org, Minas Harutyunyan , John Stultz , Sasha Levin Date: Fri, 08 Dec 2017 03:37:17 +0000 In-Reply-To: <20171207124705.660131394@linuxfoundation.org> References: <20171207124703.742654162@linuxfoundation.org> <20171207124705.660131394@linuxfoundation.org> Organization: Codethink Ltd. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-12-07 at 14:07 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me > know. > > ------------------ > > From: John Stultz > > > [ Upstream commit ce2b21a4e5ce042c0a42c9db8fa9e0f849427d5e ] > > It has been noticed that the dwc2 udc state reporting doesn't > seem to work (at least on HiKey boards). Where after the initial > setup, the sysfs /sys/class/udc/f72c0000.usb/state file would > report "configured" no matter the state of the OTG port. > > This patch adds a call so that we report to the UDC layer when > the gadget device is disconnected. > > This patch does depend on the previous patch ("usb: dwc2: > Improve gadget state disconnection handling") in this patch set > in order to properly work. Then you should add that (commit d2471d4a24df). Ben. > Cc: Wei Xu > Cc: Guodong Xu > Cc: Amit Pundir > Cc: YongQin Liu > Cc: John Youn > Cc: Minas Harutyunyan > Cc: Douglas Anderson > Cc: Chen Yu > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-usb@vger.kernel.org > Acked-by: Minas Harutyunyan > Tested-by: Minas Harutyunyan > Reported-by: Amit Pundir > Signed-off-by: John Stultz > Signed-off-by: Felipe Balbi > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman > --- >  drivers/usb/dwc2/gadget.c |    2 ++ >  1 file changed, 2 insertions(+) > > --- a/drivers/usb/dwc2/gadget.c > +++ b/drivers/usb/dwc2/gadget.c > @@ -2206,6 +2206,8 @@ void dwc2_hsotg_disconnect(struct dwc2_h >   >   call_gadget(hsotg, disconnect); >   hsotg->lx_state = DWC2_L3; > + > + usb_gadget_set_state(&hsotg->gadget, USB_STATE_NOTATTACHED); >  } >   >  /** > > > -- Ben Hutchings Software Developer, Codethink Ltd.