All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: simo.ghannam@gmail.com, netdev@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] net: ipv4: fix for a race condition in raw_sendmsg
Date: Sat, 09 Dec 2017 20:30:55 -0800	[thread overview]
Message-ID: <1512880255.25033.36.camel@gmail.com> (raw)
In-Reply-To: <5a2caf2e.4ce61c0a.5017a.575f@mx.google.com>

On Sun, 2017-12-10 at 03:50 +0000, simo.ghannam@gmail.com wrote:
> From: Mohamed Ghannam <simo.ghannam@gmail.com>
> 
> inet->hdrincl is racy, and could lead to uninitialized stack pointer
> usage, so its value should be read only once.
> 
> Signed-off-by: Mohamed Ghannam <simo.ghannam@gmail.com>
> ---
>  net/ipv4/raw.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Thanks a lot for fixing this very serious bug.

Reviewed-by: Eric Dumazet <edumazet@google.com>

Please David add :

Fixes: c008ba5bdc9f ("ipv4: Avoid reading user iov twice after raw_probe_proto_opt")

Thanks !

  reply	other threads:[~2017-12-10  4:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-10  3:50 [PATCH] net: ipv4: fix for a race condition in raw_sendmsg simo.ghannam
2017-12-10  4:30 ` Eric Dumazet [this message]
2017-12-11 19:05 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1512880255.25033.36.camel@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=simo.ghannam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.