From: Joe Perches <joe@perches.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Whitcroft <apw@canonical.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: don't require octal permissions for "0"
Date: Sun, 10 Dec 2017 14:56:46 -0800 [thread overview]
Message-ID: <1512946606.26342.21.camel@perches.com> (raw)
In-Reply-To: <20171210140401.7698-1-brgl@bgdev.pl>
On Sun, 2017-12-10 at 15:04 +0100, Bartosz Golaszewski wrote:
> If the permission value is 0, don't raise the NON_OCTAL_PERMISSIONS
> error. There's no possibility of an error if there are no permissions.
Hi Bartosz
This response below is the same as another email thread
-------------
Personally, I prefer 4 digit octal in most cases as it
shows the coder knows that the argument is a permissions
use and not just some generic 0.
There are not many uses of 0 for permissions outside of
module_param*.
I suppose all the variants of module_param calls, as a
0 there is specifically a "not to appear in sysfs" flag,
could or should be excluded from that octal test.
next prev parent reply other threads:[~2017-12-10 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-10 14:04 [PATCH] checkpatch: don't require octal permissions for "0" Bartosz Golaszewski
2017-12-10 22:56 ` Joe Perches [this message]
2017-12-11 2:19 ` Joe Perches
2017-12-11 9:39 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512946606.26342.21.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=apw@canonical.com \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.