From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Stop showing seqno info from debugfs/i915_interrupt_info
Date: Mon, 11 Dec 2017 11:08:53 +0200 [thread overview]
Message-ID: <1512983333.5315.3.camel@linux.intel.com> (raw)
In-Reply-To: <20171209104418.4223-2-chris@chris-wilson.co.uk>
On Sat, 2017-12-09 at 10:44 +0000, Chris Wilson wrote:
> Since the seqno information shown from i915_interrupt_info is just a
> small subset of i915_engine_info, remove it.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
One comment below.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> @@ -1690,6 +1690,11 @@ void intel_engine_dump(struct intel_engine_cs *engine,
> if (i915_terminally_wedged(&engine->i915->gpu_error))
> drm_printf(m, "*** WEDGED ***\n");
>
> + if (INTEL_GEN(dev_priv) >= 6) {
> + drm_printf(m, "\tInterrupt mask: %08x\n",
> + I915_READ_IMR(engine));
Next printf is not capitalized.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-11 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 10:44 [PATCH 1/2] drm/i915: Remove debugfs/i915_seqno_info Chris Wilson
2017-12-09 10:44 ` [PATCH 2/2] drm/i915: Stop showing seqno info from debugfs/i915_interrupt_info Chris Wilson
2017-12-11 9:08 ` Joonas Lahtinen [this message]
2017-12-11 11:03 ` Chris Wilson
2017-12-09 11:15 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Remove debugfs/i915_seqno_info Patchwork
2017-12-11 9:07 ` [PATCH 1/2] " Joonas Lahtinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512983333.5315.3.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.