From: Oliver Neukum <oneukum@suse.com>
To: Ladislav Michl <ladis@linux-mips.org>, linux-usb@vger.kernel.org
Cc: Johan Hovold <johan@kernel.org>
Subject: USB: serial: Avoid goto in bulk callbacks
Date: Mon, 11 Dec 2017 11:58:21 +0100 [thread overview]
Message-ID: <1512989901.22920.3.camel@suse.com> (raw)
Am Montag, den 11.12.2017, 00:11 +0100 schrieb Ladislav Michl:
> Refactor bulk callback functions to make use of goto pointless.
>
>
Hi,
you seem to assume that this is a good thing by itself which
needs no further justification. I disagree. You duplicated
code.
Regards
Oliver
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-12-11 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 10:58 Oliver Neukum [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 11:16 USB: serial: Avoid goto in bulk callbacks Ladislav Michl
2017-12-11 10:13 Johan Hovold
2017-12-10 23:11 Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512989901.22920.3.camel@suse.com \
--to=oneukum@suse.com \
--cc=johan@kernel.org \
--cc=ladis@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.