From: Johannes Berg <johannes@sipsolutions.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Kalle Valo <kvalo@codeaurora.org>,
Wireless <linux-wireless@vger.kernel.org>
Cc: "Linux-Next Mailing List" <linux-next@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Felix Fietkau" <nbd@nbd.name>,
"Lorenzo Bianconi" <lorenzo.bianconi83@gmail.com>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"David Miller" <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the mac80211-next tree
Date: Tue, 12 Dec 2017 09:46:59 +0100 [thread overview]
Message-ID: <1513068419.26976.86.camel@sipsolutions.net> (raw)
In-Reply-To: <20171212125805.5f7813fd@canb.auug.org.au>
Hi Stephen,
Thanks!
Felix made me aware of this yesterday evening and said he's going to
work out the required changes to mt76.
Kalle and I will make sure to submit the trees to Dave one by one so he
doesn't have to deal with it :)
Unfortunately, this might take a few days to resolve.
> -void mt76_wake_tx_queue(struct ieee80211_hw *hw, struct ieee80211_txq *txq)
> +void mt76_wake_tx_queue(struct ieee80211_hw *hw)
> {
> + struct ieee80211_txq *txq;
> struct mt76_dev *dev = hw->priv;
> - struct mt76_txq *mtxq = (struct mt76_txq *) txq->drv_priv;
> - struct mt76_queue *hwq = mtxq->hwq;
> + struct mt76_txq *mtxq;
> + struct mt76_queue *hwq;
>
> + txq = ieee80211_next_txq(hw);
> + mtxq = (struct mt76_txq *) txq->drv_priv;
> + hwq = mtxq->hwq;
Looks pretty much right to me - perhaps for safety there should be a
NULL check on txq, but OTOH when you get here it should be non-NULL.
Sorry for the inconvenience, I hadn't realized mt76 went in now.
johannes
next prev parent reply other threads:[~2017-12-12 8:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 1:58 linux-next: build failure after merge of the mac80211-next tree Stephen Rothwell
2017-12-12 8:46 ` Johannes Berg [this message]
[not found] ` <1513068419.26976.86.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-12-12 8:59 ` Toke Høiland-Jørgensen
2017-12-12 8:59 ` Toke Høiland-Jørgensen
2017-12-12 11:45 ` Kalle Valo
2017-12-12 11:45 ` Kalle Valo
2017-12-12 13:24 ` Toke Høiland-Jørgensen
2017-12-12 13:24 ` Toke Høiland-Jørgensen
-- strict thread matches above, loose matches on Subject: below --
2021-12-21 0:50 Stephen Rothwell
2021-12-21 11:02 ` Johannes Berg
2021-12-21 11:15 ` Stephen Rothwell
2021-12-21 11:17 ` Johannes Berg
2021-12-21 12:31 ` Kalle Valo
2020-11-11 1:24 Stephen Rothwell
2020-04-28 2:29 Stephen Rothwell
2020-04-28 7:01 ` Johannes Berg
2020-04-28 7:25 ` Sergey Matyukevich
2020-04-28 7:24 ` Johannes Berg
2020-04-28 7:45 ` Sergey Matyukevich
2020-04-28 7:46 ` Johannes Berg
2020-04-28 8:10 ` Sergey Matyukevich
2016-02-24 0:59 Stephen Rothwell
2016-02-24 8:12 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513068419.26976.86.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.