From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mehta, Sohil" Subject: Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals Date: Wed, 13 Dec 2017 04:30:43 +0000 Message-ID: <1513139481.16043.2.camel@intel.com> References: <1512531807-24268-1-git-send-email-sohil.mehta@intel.com> <1512531807-24268-3-git-send-email-sohil.mehta@intel.com> <5A27A74C.9070201@linux.intel.com> <1512678006.120652.17.camel@intel.com> <5A30905D.9000303@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <5A30905D.9000303-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Content-Language: en-US Content-ID: <3801C21E6576734F8FD1DAA3DCBE4EF8-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org" , "alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" Cc: "Yu, Fenghua" , "Shevchenko, Andriy" , "Shankar, Ravi V" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , "Kammela, Gayatri" List-Id: iommu@lists.linux-foundation.org T24gV2VkLCAyMDE3LTEyLTEzIGF0IDEwOjI4ICswODAwLCBMdSBCYW9sdSB3cm90ZToNCj7CoA0K PiA+IFdvdWxkIHRoZSByZWNvbW1lbmRhdGlvbiBiZSB0byB1c2UgcHJfd2FybiBpbnN0ZWFkIG9m IHByX2VyciBvcg0KPiA+IHNob3VsZA0KPiA+IHdlIGVudGlyZWx5IHNraXAgdGhlIG1lc3NhZ2Ug YWx0b2dldGhlcj8NCj4gR3JlZyBldmVyIGVkdWNhdGVkIG1lIGFib3V0IHRoZSB1c2Ugb2YgZGVi dWdmc18gZnVuY3Rpb25zIGluDQo+IHRoaXMgdGhyZWFkLg0KPiANCj4gaHR0cHM6Ly9zcGluaWNz Lm5ldC9saXN0cy9saW51eC11c2IvbXNnMTU5Mzg0Lmh0bWwNCj4gDQo+IEF0IGxlYXN0IHdlIHNo b3VsZCBhdm9pZCB0aGUgd2FybmluZy9lcnJvciBtZXNzYWdlcyBoZXJlLg0KPiANCg0KVGhhbmtz LiBXZSdsbCByZW1vdmUgdGhlIGVycm9yIG1lc3NhZ2VzLgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVAbGlzdHMu bGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21h aWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbdLMEat (ORCPT ); Tue, 12 Dec 2017 23:30:49 -0500 Received: from mga09.intel.com ([134.134.136.24]:64468 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbdLMEap (ORCPT ); Tue, 12 Dec 2017 23:30:45 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,396,1508828400"; d="scan'208";a="2290985" From: "Mehta, Sohil" To: "joro@8bytes.org" , "alex.williamson@redhat.com" , "baolu.lu@linux.intel.com" CC: "Yu, Fenghua" , "Shankar, Ravi V" , "linux-kernel@vger.kernel.org" , "Kammela, Gayatri" , "iommu@lists.linux-foundation.org" , "dwmw2@infradead.org" , "Shevchenko, Andriy" Subject: Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals Thread-Topic: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals Thread-Index: AQHTbkRjcaPb2F0o/0Wv8AU5+t1WG6M2focAgAJclwCACEKogIAAIkGA Date: Wed, 13 Dec 2017 04:30:43 +0000 Message-ID: <1513139481.16043.2.camel@intel.com> References: <1512531807-24268-1-git-send-email-sohil.mehta@intel.com> <1512531807-24268-3-git-send-email-sohil.mehta@intel.com> <5A27A74C.9070201@linux.intel.com> <1512678006.120652.17.camel@intel.com> <5A30905D.9000303@linux.intel.com> In-Reply-To: <5A30905D.9000303@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: <3801C21E6576734F8FD1DAA3DCBE4EF8@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBD4Ursl008433 On Wed, 2017-12-13 at 10:28 +0800, Lu Baolu wrote: >  > > Would the recommendation be to use pr_warn instead of pr_err or > > should > > we entirely skip the message altogether? > Greg ever educated me about the use of debugfs_ functions in > this thread. > > https://spinics.net/lists/linux-usb/msg159384.html > > At least we should avoid the warning/error messages here. > Thanks. We'll remove the error messages.