From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl
From: Oliver Neukum <oneukum@suse.com>
Message-Id: <1513160248.26281.5.camel@suse.com>
Date: Wed, 13 Dec 2017 11:17:28 +0100
To: Mikhail Zaytsev <flashed@mail.ru>, Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
List-ID: <linux-usb.vger.kernel.org>

QW0gTWl0dHdvY2gsIGRlbiAxMy4xMi4yMDE3LCAxMjozMCArMDMwMCBzY2hyaWViIE1pa2hhaWwg
WmF5dHNldjoKPiArI2RlZmluZSBSUzIzMl9WRU5ET1IgMHg2NTQ3Cj4gKyNkZWZpbmUgUlMyMzJf
UFJPRFVDVCAweDAyMzIKPiArI2RlZmluZSBJUkRBX1ZFTkRPUiAweDE4ZWMKPiArI2RlZmluZSBJ
UkRBX1BST0RVQ1QgMHgzMTE4Cj4gwqAKPiDCoC8qIHVzYiB0aW1lb3V0IG9mIDEgc2Vjb25kICov
Cj4gwqAjZGVmaW5lIEFSS19USU1FT1VUIDEwMDAKPiDCoAo+IMKgc3RhdGljIGNvbnN0IHN0cnVj
dCB1c2JfZGV2aWNlX2lkIGlkX3RhYmxlW10gPSB7Cj4gLcKgwqDCoMKgwqDCoMKgeyBVU0JfREVW
SUNFKDB4NjU0NywgMHgwMjMyKSB9LAo+IC3CoMKgwqDCoMKgwqDCoHsgVVNCX0RFVklDRSgweDE4
ZWMsIDB4MzExOCkgfSzCoMKgwqDCoMKgwqDCoMKgwqAvKiBVU0IgdG8gSXJEQSBhZGFwdGVyICov
Cj4gK8KgwqDCoMKgwqDCoMKgeyBVU0JfREVWSUNFKFJTMjMyX1ZFTkRPUiwgUlMyMzJfUFJPRFVD
VCkgfSwKPiArwqDCoMKgwqDCoMKgwqB7IFVTQl9ERVZJQ0UoSVJEQV9WRU5ET1IsIElSREFfUFJP
RFVDVCkgfSzCoCAvKiBVU0IgdG8gSXJEQSBhZGFwdGVyICovCgpIaSwKCndoYXQgaXMgdGhlIHB1
cnBvc2Ugb2YgdGhpcyBjaGFuZ2U/IEl0IGp1c3QgbWFrZXMgaXQgaGFyZGVyIHRvIGdyZXAuClRo
ZSBjb25zdGFudHMgYXJlIGFyYml0cmFyeSBhbmQgdGhleSBhcmUgY2xlYXJseSBkZXZpY2UgSURz
LgoKwqDCoMKgwqDCoMKgwqDCoFJlZ2FyZHMKwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqBPbGl2ZXIKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l
ICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpv
cmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy
Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752532AbdLMKWE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 05:22:04 -0500
Received: from mx2.suse.de ([195.135.220.15]:37473 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751515AbdLMKWC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 05:22:02 -0500
Message-ID: <1513160248.26281.5.camel@suse.com>
Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case
 from ioctl
From: Oliver Neukum <oneukum@suse.com>
To: Mikhail Zaytsev <flashed@mail.ru>, Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Date: Wed, 13 Dec 2017 11:17:28 +0100
In-Reply-To: <20171213123004.4619000a@zaytsev.tver.pg>
References: <20171213123004.4619000a@zaytsev.tver.pg>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev:
> +#define RS232_VENDOR 0x6547
> +#define RS232_PRODUCT 0x0232
> +#define IRDA_VENDOR 0x18ec
> +#define IRDA_PRODUCT 0x3118
>  
>  /* usb timeout of 1 second */
>  #define ARK_TIMEOUT 1000
>  
>  static const struct usb_device_id id_table[] = {
> -       { USB_DEVICE(0x6547, 0x0232) },
> -       { USB_DEVICE(0x18ec, 0x3118) },         /* USB to IrDA adapter */
> +       { USB_DEVICE(RS232_VENDOR, RS232_PRODUCT) },
> +       { USB_DEVICE(IRDA_VENDOR, IRDA_PRODUCT) },  /* USB to IrDA adapter */

Hi,

what is the purpose of this change? It just makes it harder to grep.
The constants are arbitrary and they are clearly device IDs.

        Regards
                Oliver