From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl From: Oliver Neukum Message-Id: <1513165248.26281.11.camel@suse.com> Date: Wed, 13 Dec 2017 12:40:48 +0100 To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: QW0gTWl0dHdvY2gsIGRlbiAxMy4xMi4yMDE3LCAxNDozMSArMDMwMCBzY2hyaWViIE1pa2hhaWwg WmF5dHNldjoKPiBPbiBXZWQsIDEzIERlYyAyMDE3IDExOjE3OjI4ICswMTAwIE9saXZlciBOZXVr dW0gPG9uZXVrdW1Ac3VzZS5jb20+IHdyb3RlOgo+IAo+ID4gCj4gPiBBbSBNaXR0d29jaCwgZGVu IDEzLjEyLjIwMTcsIDEyOjMwICswMzAwIHNjaHJpZWIgTWlraGFpbCBaYXl0c2V2Ogo+ID4gPiAK PiA+ID4gKyNkZWZpbmUgUlMyMzJfVkVORE9SIDB4NjU0Nwo+ID4gPiArI2RlZmluZSBSUzIzMl9Q Uk9EVUNUIDB4MDIzMgo+ID4gPiArI2RlZmluZSBJUkRBX1ZFTkRPUiAweDE4ZWMKPiA+ID4gKyNk ZWZpbmUgSVJEQV9QUk9EVUNUIDB4MzExOAo+ID4gPiDCoAo+ID4gPiDCoC8qIHVzYiB0aW1lb3V0 IG9mIDEgc2Vjb25kICovCj4gPiA+IMKgI2RlZmluZSBBUktfVElNRU9VVCAxMDAwCj4gPiA+IMKg Cj4gPiA+IMKgc3RhdGljIGNvbnN0IHN0cnVjdCB1c2JfZGV2aWNlX2lkIGlkX3RhYmxlW10gPSB7 Cj4gPiA+IC3CoMKgwqDCoMKgwqDCoHsgVVNCX0RFVklDRSgweDY1NDcsIDB4MDIzMikgfSwKPiA+ ID4gLcKgwqDCoMKgwqDCoMKgeyBVU0JfREVWSUNFKDB4MThlYywgMHgzMTE4KSB9LMKgwqDCoMKg wqDCoMKgwqDCoC8qIFVTQiB0byBJckRBIGFkYXB0ZXIgKi8KPiA+ID4gK8KgwqDCoMKgwqDCoMKg eyBVU0JfREVWSUNFKFJTMjMyX1ZFTkRPUiwgUlMyMzJfUFJPRFVDVCkgfSwKPiA+ID4gK8KgwqDC oMKgwqDCoMKgeyBVU0JfREVWSUNFKElSREFfVkVORE9SLCBJUkRBX1BST0RVQ1QpIH0swqAgLyog VVNCIHRvIElyREEgYWRhcHRlciAqLyAgCj4gPiAKPiA+IEhpLAo+ID4gCj4gPiB3aGF0IGlzIHRo ZSBwdXJwb3NlIG9mIHRoaXMgY2hhbmdlPyBJdCBqdXN0IG1ha2VzIGl0IGhhcmRlciB0byBncmVw Lgo+ID4gVGhlIGNvbnN0YW50cyBhcmUgYXJiaXRyYXJ5IGFuZCB0aGV5IGFyZSBjbGVhcmx5IGRl dmljZSBJRHMuCj4gCj4gVGhlIGNvbnN0YW50cyBhcmUgdXNpbmcgaW4gc2V2ZXJhbCBwbGFjZXMu IAo+IEkgdGhpbmsgdGhlIG5hbWVzIGVhc2llciB0byByZWFkLgoKVGhleSBnaXZlIHlvdSBub3Ro aW5nLiBJZiB5b3UgYXJlIGxvb2tpbmcgYXQgYSB2ZW5kb3IgSUQgbm90aGluZyBidXQgdGhlCmJh cmUgbnVtYmVyIG1ha2VzIHNlbnNlLiBZb3UgYXJlIGp1c3QgbWFraW5nIHBlb3BsZXMnIGxpZmUg aGFyZGVyIHdoZW4KdGhleSBoYXZlIHRvIGxvb2sgdXAgdGhhdCBkZWZpbml0aW9uLiBBIHN5bWJv bGljIG5hbWUgaXMgZmluZSBpZiBpdCBnaXZlcwptZWFuaW5nLiBFdmVuIGlmIHRoZSBpbmZvcm1h dGlvbiB5b3UgZ2l2ZSBpcyB0aGF0IHRoZSB2YWx1ZSBpcyBtYWdpYwphbmQgdGhlcmVmb3JlIG5v dCB1bmRlcnN0b29kLiBCdXQgYSB2ZW5kb3IgSUQgaXMgYW4gYXJiaXRyYXJ5IHlldAptZWFuaW5n ZnVsIG51bWJlci4gVGhlcmUgaXMgbm8gcG9pbnQgaW4gaGlkaW5nIGl0LgoKCVJlZ2FyZHMKCQlP bGl2ZXIKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1 bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRv bW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtl cm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752768AbdLMLpY (ORCPT ); Wed, 13 Dec 2017 06:45:24 -0500 Received: from mx2.suse.de ([195.135.220.15]:45724 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752646AbdLMLpW (ORCPT ); Wed, 13 Dec 2017 06:45:22 -0500 Message-ID: <1513165248.26281.11.camel@suse.com> Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl From: Oliver Neukum To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 13 Dec 2017 12:40:48 +0100 In-Reply-To: <20171213143142.1c312b57@zaytsev.tver.pg> References: <20171213123004.4619000a@zaytsev.tver.pg> <1513160248.26281.5.camel@suse.com> <20171213143142.1c312b57@zaytsev.tver.pg> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 13.12.2017, 14:31 +0300 schrieb Mikhail Zaytsev: > On Wed, 13 Dec 2017 11:17:28 +0100 Oliver Neukum wrote: > > > > > Am Mittwoch, den 13.12.2017, 12:30 +0300 schrieb Mikhail Zaytsev: > > > > > > +#define RS232_VENDOR 0x6547 > > > +#define RS232_PRODUCT 0x0232 > > > +#define IRDA_VENDOR 0x18ec > > > +#define IRDA_PRODUCT 0x3118 > > >   > > >  /* usb timeout of 1 second */ > > >  #define ARK_TIMEOUT 1000 > > >   > > >  static const struct usb_device_id id_table[] = { > > > -       { USB_DEVICE(0x6547, 0x0232) }, > > > -       { USB_DEVICE(0x18ec, 0x3118) },         /* USB to IrDA adapter */ > > > +       { USB_DEVICE(RS232_VENDOR, RS232_PRODUCT) }, > > > +       { USB_DEVICE(IRDA_VENDOR, IRDA_PRODUCT) },  /* USB to IrDA adapter */ > > > > Hi, > > > > what is the purpose of this change? It just makes it harder to grep. > > The constants are arbitrary and they are clearly device IDs. > > The constants are using in several places. > I think the names easier to read. They give you nothing. If you are looking at a vendor ID nothing but the bare number makes sense. You are just making peoples' life harder when they have to look up that definition. A symbolic name is fine if it gives meaning. Even if the information you give is that the value is magic and therefore not understood. But a vendor ID is an arbitrary yet meaningful number. There is no point in hiding it. Regards Oliver