All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dhaval Shah <dhaval.shah@softnautics.com>,
	Philippe Ombredanne <pombredanne@nexb.com>
Cc: "pali.rohar@gmail.com" <pali.rohar@gmail.com>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines
Date: Wed, 13 Dec 2017 04:25:07 -0800	[thread overview]
Message-ID: <1513167907.27409.3.camel@perches.com> (raw)
In-Reply-To: <e482b906981f4b46b2336bebba28888bBM1PR0101MB144449CA7ADDBA3A03061AAFE6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>

On Wed, 2017-12-13 at 10:53 +0000, Dhaval Shah wrote:
> > > This is different issue. If we need to fix the issue of this if we update SPDX licensing as well.
> > > I am agree with you on the use of the new SPDX IDs instead of the long legalese.
> > > For this, we have to add the text "// SPDX-License-Identifier: GPL-2.0" at the top of the file and remove the
> > > whole license part and keep on copyright and Author name related info. After change, it looks like
> > > // SPDX-License-Identifier: GPL-2.0
> > > /*
> > >   *  Dell Airplane Mode Switch driver
> > >   *  Copyright (C) 2014-2015  Pali Rohár <pali.rohar@gmail.com>
> > >   */
> > 
> > And for a short comment block like this, Linus preference is to avoid
> > mixing comment style and go all the way C++ style as in:
> > 
> > > // SPDX-License-Identifier: GPL-2.0
> > > // Dell Airplane Mode Switch driver
> > > // Copyright (C) 2014-2015  Pali Rohár <pali.rohar@gmail.com>
> > > 
> > > ... for even less boilerplate ;)
> 
> Thanks a lot for the link.
> Do you want to me to update along with SPDX in this patchset with V2 or we will update in the next patchset once this patch merge?

If anyone does conversions of these license texts
you have to be _extremely_ careful about what
specific license identifier you use.

This license includes the text
	"or (at your option) any later version"
which is not the same as using
	SPDX-License-Identifier: GPL-2.0

  reply	other threads:[~2017-12-13 12:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  8:23 [PATCH] platform/x86: dell-rbtn: Block comments use * on subsequent lines Dhaval Shah
2017-12-13  9:24 ` Philippe Ombredanne
2017-12-13  9:52   ` Dhaval Shah
2017-12-13 10:01     ` Philippe Ombredanne
2017-12-13 10:53       ` Dhaval Shah
2017-12-13 12:25         ` Joe Perches [this message]
2017-12-13 12:41           ` Dhaval Shah
2017-12-13 13:07             ` Pali Rohár
2017-12-13 15:39             ` Joe Perches
2017-12-14  9:12               ` Dhaval Shah
2017-12-14 17:56                 ` Andy Shevchenko
     [not found]       ` <BM1PR0101MB144449CA7ADDBA3A03061AAFE6350@BM1PR0101MB1444.INDPRD01.PROD.OUTLOOK.COM>
2017-12-13 12:57         ` Philippe Ombredanne
2017-12-13 13:08           ` Dhaval Shah
2017-12-13 13:08             ` Dhaval Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1513167907.27409.3.camel@perches.com \
    --to=joe@perches.com \
    --cc=andy@infradead.org \
    --cc=dhaval.shah@softnautics.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.