From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl From: Oliver Neukum Message-Id: <1513175961.26281.20.camel@suse.com> Date: Wed, 13 Dec 2017 15:39:21 +0100 To: Mikhail Zaytsev Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-ID: QW0gTWl0dHdvY2gsIGRlbiAxMy4xMi4yMDE3LCAxNTozMCArMDMwMCBzY2hyaWViIE1pa2hhaWwg WmF5dHNldjoKPiBPbiBXZWQsIDEzIERlYyAyMDE3IDEyOjQwOjQ4ICswMTAwIE9saXZlciBOZXVr dW0gPG9uZXVrdW1Ac3VzZS5jb20+IHdyb3RlOgo+IAo+ID4gCj4gPiBUaGV5IGdpdmUgeW91IG5v dGhpbmcuIElmIHlvdSBhcmUgbG9va2luZyBhdCBhIHZlbmRvciBJRCBub3RoaW5nIGJ1dCB0aGUK PiA+IGJhcmUgbnVtYmVyIG1ha2VzIHNlbnNlLiBZb3UgYXJlIGp1c3QgbWFraW5nIHBlb3BsZXMn IGxpZmUgaGFyZGVyIHdoZW4KPiA+IHRoZXkgaGF2ZSB0byBsb29rIHVwIHRoYXQgZGVmaW5pdGlv bi4gQSBzeW1ib2xpYyBuYW1lIGlzIGZpbmUgaWYgaXQgZ2l2ZXMKPiA+IG1lYW5pbmcuIEV2ZW4g aWYgdGhlIGluZm9ybWF0aW9uIHlvdSBnaXZlIGlzIHRoYXQgdGhlIHZhbHVlIGlzIG1hZ2ljCj4g PiBhbmQgdGhlcmVmb3JlIG5vdCB1bmRlcnN0b29kLiBCdXQgYSB2ZW5kb3IgSUQgaXMgYW4gYXJi aXRyYXJ5IHlldAo+ID4gbWVhbmluZ2Z1bCBudW1iZXIuIFRoZXJlIGlzIG5vIHBvaW50IGluIGhp ZGluZyBpdC4KPiAKPiBUaGFua3MuIEkgaGVhciB5b3UsIE9saXZlci4gV2hhdCBhYm91dDoKPiAK PiAtCQlzZXJzdHJ1Y3QuYmF1ZF9iYXNlID0gNDYwODAwOwo+IAo+IElzIGl0IGEgbWFnaWMgbnVt YmVyPyBJIHRoaW5rIHllcy4KPiAKCkhpLAoKeWVzIHN1cmUuIFRoYXQgaXMgYSBjYW5kaWRhdGUg Zm9yIGEgc3ltYm9saWMgbmFtZS4gVGhvdWdoIGlmIHlvdSB1c2UKaXQgb25jZSwgSSBzZWUgbm8g YmVuZWZpdCwgYnV0IGl0IGRvZXMgbm90IGh1cnQgZWl0aGVyLiBUaGUgbWVtYmVyCmlzIG5hbWVk IGFuZCB0aGF0IGlzIHRoZSBpbXBvcnRhbnQgdGhpbmcuCgpBIGxpbmUgbGlrZQoKaWYgKHJhdGUg PiAzODQwMCkgcmV0dXJuIC1FSU5WQUw7CgppcyBub3Qgc28gZ29vZAoKaWYgKHJhdGUgPiBNQVhf QkFVRCkgcmV0dXJuIC1FSU5WQUw7CgpiZXR0ZXIKCkJ1dDoKCmRldmljZS0+bWF4YmF1ZHJhdGUg PSAzODQwMAoKaXMgYmV0dGVyIHRoYW4KCmRldmljZS0+bWF4YmF1ZHJhdGUgPSBNQVhfQkFVRAoK WW91IHNlZSB0aGUgcG9pbnQ/CgoJUmVnYXJkcwoJCU9saXZlcgotLS0KVG8gdW5zdWJzY3JpYmUg ZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4K dGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBt YWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5o dG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbdLMOn6 (ORCPT ); Wed, 13 Dec 2017 09:43:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:60845 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753291AbdLMOnz (ORCPT ); Wed, 13 Dec 2017 09:43:55 -0500 Message-ID: <1513175961.26281.20.camel@suse.com> Subject: Re: [PATCH] USB: serial: ark3116.c: Remove unused TIOCSSERIAL case from ioctl From: Oliver Neukum To: Mikhail Zaytsev Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 13 Dec 2017 15:39:21 +0100 In-Reply-To: <20171213153027.7aaab62b@zaytsev.tver.pg> References: <20171213123004.4619000a@zaytsev.tver.pg> <1513160248.26281.5.camel@suse.com> <20171213143142.1c312b57@zaytsev.tver.pg> <1513165248.26281.11.camel@suse.com> <20171213153027.7aaab62b@zaytsev.tver.pg> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 13.12.2017, 15:30 +0300 schrieb Mikhail Zaytsev: > On Wed, 13 Dec 2017 12:40:48 +0100 Oliver Neukum wrote: > > > > > They give you nothing. If you are looking at a vendor ID nothing but the > > bare number makes sense. You are just making peoples' life harder when > > they have to look up that definition. A symbolic name is fine if it gives > > meaning. Even if the information you give is that the value is magic > > and therefore not understood. But a vendor ID is an arbitrary yet > > meaningful number. There is no point in hiding it. > > Thanks. I hear you, Oliver. What about: > > - serstruct.baud_base = 460800; > > Is it a magic number? I think yes. > Hi, yes sure. That is a candidate for a symbolic name. Though if you use it once, I see no benefit, but it does not hurt either. The member is named and that is the important thing. A line like if (rate > 38400) return -EINVAL; is not so good if (rate > MAX_BAUD) return -EINVAL; better But: device->maxbaudrate = 38400 is better than device->maxbaudrate = MAX_BAUD You see the point? Regards Oliver