From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdLNGs3 (ORCPT ); Thu, 14 Dec 2017 01:48:29 -0500 Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:35783 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750720AbdLNGs2 (ORCPT ); Thu, 14 Dec 2017 01:48:28 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3871:4321:5007:10004:10400:10848:11026:11232:11657:11658:11914:12043:12295:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: deer73_f6d2fcd74847 X-Filterd-Recvd-Size: 1819 Message-ID: <1513234104.27409.49.camel@perches.com> Subject: Re: [PATCH v2] staging: comedi: ni_*: Fix style warnings. From: Joe Perches To: Aniruddha Shastri Cc: Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , Saber Rezvani , Matthew Giassa , Christopher =?ISO-8859-1?Q?M=E5rtensson?= , Karthik Nayak , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 13 Dec 2017 22:48:24 -0800 In-Reply-To: <1513232885-60710-1-git-send-email-aniruddha.shastri@gmail.com> References: <20171213120733.GA3402@kroah.com> <1513232885-60710-1-git-send-email-aniruddha.shastri@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-12-14 at 00:27 -0600, Aniruddha Shastri wrote: > Three of these warnings are now line-too-long warnings. I think these > warnings are preferable to the ones listed below. The longest line > is only 87 chars wide, which is reasonable. [] > diff --git a/drivers/staging/comedi/drivers/ni_670x.c b/drivers/staging/comedi/drivers/ni_670x.c [] > @@ -209,7 +209,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev, > const struct comedi_lrange **range_table_list; > > range_table_list = kmalloc_array(32, > - sizeof(struct comedi_lrange *), > + sizeof(const struct comedi_lrange *), Adding const to a sizeof is unnecessary