From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Fri, 15 Dec 2017 11:20:41 +0000 Subject: rsi_91x: Low bandwidth: sends ~100 Kbits/sec, receives ~1.5 Mbits/sec In-Reply-To: References: <1512490314.4977.143.camel@synopsys.com> <1513277783.8750.27.camel@synopsys.com> List-ID: Message-ID: <1513336840.29404.21.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Prameela, On Fri, 2017-12-15@11:13 +0530, Prameela Rani Garnepudi wrote: > Hi Alexey, > > Please use the attached patch to improve TX throughput. We will be > submitting this patch along with few others soon. Could you please specify which branch this patch is based on? I tried to apply on 4.14.5 (whatever is latests in "linux-4.14.y") but first 3 hunks failed to apply. Maybe there're other dependencies? Also a couple of questions about this patch. Even though I'm not a networking/Wi-Fi expert of any kind but just looking at your changes: 1. I assume for upstreaming that patch will be split in 5 seperate patches each addressing its own item instead of doing all at once, right? 2. The only obvious change that might help me with bandwidth is increase of a number of aggregated Tx frames. But bumping from 6 to 8 doesn't look as a significant improvement. How that might bring Tx bandwidth at least to what I see on Rx, i.e. make things 10 times faster? Also while at it I'm wondering why 5GHz mode didn't work for me even though "iw list" reports 5 GHz mode supported: ----------------------->8------------------ # iw list Wiphy phy0 ... Frequencies: * 5180 MHz [36] (20.0 dBm) (no IR) # cat /etc/hostapd.conf interface=wlan0 ctrl_interface=/var/run/hostapd ctrl_interface_group=0 ssid=HSDK-AP hw_mode=a channel=36 # hostapd -B /etc/hostapd.conf Starting hostapd: Configuration file: /etc/hostapd.conf rsi_91x: ===> Interface UP <=== rfkill: Cannot open RFKILL contrIPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready ol device wlan0: IEEE 802.11 Configured channel (36) not found from the channel list of current mode (2) IEEE 802.11a wlan0: IEEE 802.11 Hardware does not support configured channel Could not select hw_mode and channel. (-3) wlan0: interface state UNINITIALIZED->DISABLED wlan0: AP-DISABLED wlan0: Unable to setup interface. wlan0: interface state DISABLED->DISABLED wlan0: AP-DISABLED hostapd_free_hapd_data: Interface wlan0 wasn't started ----------------------->8------------------ Has it something to do with your another fix in that patch? -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:59376 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbdLOLUp (ORCPT ); Fri, 15 Dec 2017 06:20:45 -0500 From: Alexey Brodkin To: "prameela.garnepudi@redpinesignals.com" CC: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "amitkarwar@gmail.com" , "amit.karwar@redpinesignals.com" , "linux-snps-arc@lists.infradead.org" Subject: Re: rsi_91x: Low bandwidth: sends ~100 Kbits/sec, receives ~1.5 Mbits/sec Date: Fri, 15 Dec 2017 11:20:41 +0000 Message-ID: <1513336840.29404.21.camel@synopsys.com> (sfid-20171215_122051_198957_201CE935) References: <1512490314.4977.143.camel@synopsys.com> <1513277783.8750.27.camel@synopsys.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: SGkgUHJhbWVlbGEsDQoNCk9uIEZyaSwgMjAxNy0xMi0xNSBhdCAxMToxMyArMDUzMCwgUHJhbWVl bGEgUmFuaSBHYXJuZXB1ZGkgd3JvdGU6DQo+IEhpIEFsZXhleSwgDQo+IA0KPiBQbGVhc2UgdXNl IHRoZSBhdHRhY2hlZCBwYXRjaCB0byBpbXByb3ZlIFRYIHRocm91Z2hwdXQuIFdlIHdpbGwgYmUg DQo+IHN1Ym1pdHRpbmcgdGhpcyBwYXRjaCBhbG9uZyB3aXRoIGZldyBvdGhlcnMgc29vbi4gDQoN CkNvdWxkIHlvdSBwbGVhc2Ugc3BlY2lmeSB3aGljaCBicmFuY2ggdGhpcyBwYXRjaCBpcyBiYXNl ZCBvbj8NCkkgdHJpZWQgdG8gYXBwbHkgb24gNC4xNC41ICh3aGF0ZXZlciBpcyBsYXRlc3RzIGlu ICJsaW51eC00LjE0LnkiKQ0KYnV0IGZpcnN0IDMgaHVua3MgZmFpbGVkIHRvIGFwcGx5Lg0KDQpN YXliZSB0aGVyZSdyZSBvdGhlciBkZXBlbmRlbmNpZXM/DQoNCkFsc28gYSBjb3VwbGUgb2YgcXVl c3Rpb25zIGFib3V0IHRoaXMgcGF0Y2guDQpFdmVuIHRob3VnaCBJJ20gbm90IGEgbmV0d29ya2lu Zy9XaS1GaSBleHBlcnQgb2YgYW55IGtpbmQgYnV0IGp1c3QNCmxvb2tpbmcgYXQgeW91ciBjaGFu Z2VzOg0KDQoxLiBJIGFzc3VtZSBmb3IgdXBzdHJlYW1pbmcgdGhhdCBwYXRjaCB3aWxsIGJlIHNw bGl0IGluIDUgc2VwZXJhdGUgcGF0Y2hlcw0KICAgZWFjaCBhZGRyZXNzaW5nIGl0cyBvd24gaXRl bSBpbnN0ZWFkIG9mIGRvaW5nIGFsbCBhdCBvbmNlLCByaWdodD8NCg0KMi4gVGhlIG9ubHkgb2J2 aW91cyBjaGFuZ2UgdGhhdCBtaWdodCBoZWxwIG1lIHdpdGggYmFuZHdpZHRoIGlzIGluY3JlYXNl DQogICBvZiBhIG51bWJlciBvZiBhZ2dyZWdhdGVkIFR4IGZyYW1lcy4gQnV0IGJ1bXBpbmcgZnJv bSA2IHRvIDggZG9lc24ndCBsb29rDQogICBhcyBhIHNpZ25pZmljYW50IGltcHJvdmVtZW50LiBI b3cgdGhhdCBtaWdodCBicmluZyBUeCBiYW5kd2lkdGggYXQgbGVhc3QgdG8NCiAgIHdoYXQgSSBz ZWUgb24gUngsIGkuZS4gbWFrZSB0aGluZ3MgMTAgdGltZXMgZmFzdGVyPw0KDQpBbHNvIHdoaWxl IGF0IGl0IEknbSB3b25kZXJpbmcgd2h5IDVHSHogbW9kZSBkaWRuJ3Qgd29yayBmb3IgbWUgZXZl biB0aG91Z2gNCiJpdyBsaXN0IiByZXBvcnRzIDUgR0h6IG1vZGUgc3VwcG9ydGVkOg0KLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0tLS0tLS0tLQ0KIyBpdyBsaXN0DQpXaXBoeSBw aHkwDQouLi4NCiAgICAgIEZyZXF1ZW5jaWVzOg0KICAgICAgICAgICAqIDUxODAgTUh6IFszNl0g KDIwLjAgZEJtKSAobm8gSVIpDQoNCiMgY2F0IC9ldGMvaG9zdGFwZC5jb25mDQppbnRlcmZhY2U9 d2xhbjANCmN0cmxfaW50ZXJmYWNlPS92YXIvcnVuL2hvc3RhcGQNCmN0cmxfaW50ZXJmYWNlX2dy b3VwPTANCnNzaWQ9SFNESy1BUA0KaHdfbW9kZT1hDQpjaGFubmVsPTM2DQoNCiMgaG9zdGFwZCAt QiAvZXRjL2hvc3RhcGQuY29uZg0KU3RhcnRpbmcgaG9zdGFwZDogQ29uZmlndXJhdGlvbiBmaWxl OiAvZXRjL2hvc3RhcGQuY29uZg0KcnNpXzkxeDogPT09PiBJbnRlcmZhY2UgVVAgPD09PQ0KcmZr aWxsOiBDYW5ub3Qgb3BlbiBSRktJTEwgY29udHJJUHY2OiBBRERSQ09ORihORVRERVZfVVApOiB3 bGFuMDogbGluayBpcyBub3QgcmVhZHkNCm9sIGRldmljZQ0Kd2xhbjA6IElFRUUgODAyLjExIENv bmZpZ3VyZWQgY2hhbm5lbCAoMzYpIG5vdCBmb3VuZCBmcm9tIHRoZSBjaGFubmVsIGxpc3Qgb2Yg Y3VycmVudCBtb2RlICgyKSBJRUVFIDgwMi4xMWENCndsYW4wOiBJRUVFIDgwMi4xMSBIYXJkd2Fy ZSBkb2VzIG5vdCBzdXBwb3J0IGNvbmZpZ3VyZWQgY2hhbm5lbA0KQ291bGQgbm90IHNlbGVjdCBo d19tb2RlIGFuZCBjaGFubmVsLiAoLTMpDQp3bGFuMDogaW50ZXJmYWNlIHN0YXRlIFVOSU5JVElB TElaRUQtPkRJU0FCTEVEDQp3bGFuMDogQVAtRElTQUJMRUQgDQp3bGFuMDogVW5hYmxlIHRvIHNl dHVwIGludGVyZmFjZS4NCndsYW4wOiBpbnRlcmZhY2Ugc3RhdGUgRElTQUJMRUQtPkRJU0FCTEVE DQp3bGFuMDogQVAtRElTQUJMRUQgDQpob3N0YXBkX2ZyZWVfaGFwZF9kYXRhOiBJbnRlcmZhY2Ug d2xhbjAgd2Fzbid0IHN0YXJ0ZWQNCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0t LS0tLS0tLS0NCg0KSGFzIGl0IHNvbWV0aGluZyB0byBkbyB3aXRoIHlvdXIgYW5vdGhlciBmaXgg aW4gdGhhdCBwYXRjaD8NCg0KLUFsZXhleQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755265AbdLOLUt (ORCPT ); Fri, 15 Dec 2017 06:20:49 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:59376 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbdLOLUp (ORCPT ); Fri, 15 Dec 2017 06:20:45 -0500 From: Alexey Brodkin To: "prameela.garnepudi@redpinesignals.com" CC: "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "amitkarwar@gmail.com" , "amit.karwar@redpinesignals.com" , "linux-snps-arc@lists.infradead.org" Subject: Re: rsi_91x: Low bandwidth: sends ~100 Kbits/sec, receives ~1.5 Mbits/sec Thread-Topic: rsi_91x: Low bandwidth: sends ~100 Kbits/sec, receives ~1.5 Mbits/sec Thread-Index: AQHTdQ09tj3vFqEndUaOMAD8nxarzqND1HoAgABeIQA= Date: Fri, 15 Dec 2017 11:20:41 +0000 Message-ID: <1513336840.29404.21.camel@synopsys.com> References: <1512490314.4977.143.camel@synopsys.com> <1513277783.8750.27.camel@synopsys.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.225.15.88] Content-Type: text/plain; charset="utf-8" Content-ID: <28CA97D9101E4E40A86396F498DB54EF@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vBFBKr2L000339 Hi Prameela, On Fri, 2017-12-15 at 11:13 +0530, Prameela Rani Garnepudi wrote: > Hi Alexey, > > Please use the attached patch to improve TX throughput. We will be > submitting this patch along with few others soon. Could you please specify which branch this patch is based on? I tried to apply on 4.14.5 (whatever is latests in "linux-4.14.y") but first 3 hunks failed to apply. Maybe there're other dependencies? Also a couple of questions about this patch. Even though I'm not a networking/Wi-Fi expert of any kind but just looking at your changes: 1. I assume for upstreaming that patch will be split in 5 seperate patches each addressing its own item instead of doing all at once, right? 2. The only obvious change that might help me with bandwidth is increase of a number of aggregated Tx frames. But bumping from 6 to 8 doesn't look as a significant improvement. How that might bring Tx bandwidth at least to what I see on Rx, i.e. make things 10 times faster? Also while at it I'm wondering why 5GHz mode didn't work for me even though "iw list" reports 5 GHz mode supported: ----------------------->8------------------ # iw list Wiphy phy0 ... Frequencies: * 5180 MHz [36] (20.0 dBm) (no IR) # cat /etc/hostapd.conf interface=wlan0 ctrl_interface=/var/run/hostapd ctrl_interface_group=0 ssid=HSDK-AP hw_mode=a channel=36 # hostapd -B /etc/hostapd.conf Starting hostapd: Configuration file: /etc/hostapd.conf rsi_91x: ===> Interface UP <=== rfkill: Cannot open RFKILL contrIPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready ol device wlan0: IEEE 802.11 Configured channel (36) not found from the channel list of current mode (2) IEEE 802.11a wlan0: IEEE 802.11 Hardware does not support configured channel Could not select hw_mode and channel. (-3) wlan0: interface state UNINITIALIZED->DISABLED wlan0: AP-DISABLED wlan0: Unable to setup interface. wlan0: interface state DISABLED->DISABLED wlan0: AP-DISABLED hostapd_free_hapd_data: Interface wlan0 wasn't started ----------------------->8------------------ Has it something to do with your another fix in that patch? -Alexey