From: Steve Brown <sbrown@cortland.com>
To: "Stotland, Inga" <inga.stotland@intel.com>,
"sbrown@cortland.com" <sbrown@cortland.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH V3 3/9] mesh: meshctl: Add set heartbeat publish
Date: Sun, 17 Dec 2017 01:47:44 -0700 [thread overview]
Message-ID: <1513500464.18172.87.camel@ewol.com> (raw)
In-Reply-To: <1513491536.13970.9.camel@intel.com>
On Sun, 2017-12-17 at 06:18 +0000, Stotland, Inga wrote:
> Hi Steve,
>
> On Fri, 2017-12-15 at 06:46 +0000, sbrown@cortland.com wrote:
> > From: Steve Brown <sbrown@cortland.com>
> >
> > Sets heartbeat for node 0100
> >
> > [config: Target = 0100]# hb-set 0100 0 0 0 0
> >
> > Set heartbeat for node 0100 status: Success
> > Destination: 0100
> > Count: 00
> > Period: 00
> > TTL: ff
> > Features: 0000
> > Net_Idx: 0000
> > ---
> >
> After applying this patch, the code fails to compile because of
> undeclared functions for get/set proxy, get/set relay, get/set ident
> and get pub.
> I believe the expectation is that the code should cleanly compile
> after
> applying each patch. Plus, you would want to keep the new added
> fuctionalities bundled together, i.e., introduce new command menu
> items
> along with the command handling (e.g., "proxy-set" & "proxy-get"
> belong
> in
> "[PATCH Vxxx 6/9] mesh: meshctl: Add set/get proxy"
>
> Regards,
>
> Inga
I messed up my tree while changing the heartbeat command. I'll sort it
out and send a V4.
Sorry for the noise.
Steve
next prev parent reply other threads:[~2017-12-17 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 6:45 [PATCH V3 0/9] mesh: Add configuration commands to meshctl sbrown
2017-12-15 6:45 ` [PATCH V3 1/9] mesh: meshctl: Change command names to <cmd>-<get/set> sbrown
2017-12-15 6:45 ` [PATCH V3 2/9] mesh: meshctl: Add add/get subscribe sbrown
2017-12-15 6:46 ` [PATCH V3 3/9] mesh: meshctl: Add set heartbeat publish sbrown
2017-12-17 6:18 ` Stotland, Inga
2017-12-17 8:47 ` Steve Brown [this message]
2017-12-15 6:46 ` [PATCH V3 4/9] mesh: meshctl: Add get app keys sbrown
2017-12-15 6:46 ` [PATCH V3 5/9] mesh: meshctl: Add get publish sbrown
2017-12-15 6:46 ` [PATCH V3 6/9] mesh: meshctl: Add set/get proxy sbrown
2017-12-15 6:46 ` [PATCH V3 7/9] mesh: meshctl: Add get/set identity sbrown
2017-12-16 15:49 ` Johan Hedberg
2017-12-16 16:43 ` Steve Brown
2017-12-15 6:46 ` [PATCH V3 8/9] mesh: meshctl: Add get/set relay sbrown
2017-12-15 6:46 ` [PATCH V3 9/9] mesh: meshctl: Add Company ID parameter to pub-set and pub-get sbrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513500464.18172.87.camel@ewol.com \
--to=sbrown@cortland.com \
--cc=inga.stotland@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.